Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
O
openmc
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Shikhar Kumar
  • openmc
  • Merge Requests
  • !948

Merged
Opened Dec 20, 2017 by Shikhar Kumar@shikhark
  • Report abuse
Report abuse

Fix source normalization for fixed-source simulations

  • Overview 3
  • Commits 5
  • Changes 32

Created by: paulromano

Closes #943 (closed). The actual fix in src/tallies/tally_header.F90 is pretty trivial. However, it created a circular dependency (tally_header -> source_header -> geometry -> tally_header) that I had to break, hence the larger diff. In summary:

  • write_particle_restart is now Particle % write_restart
  • handle_lost_particle is now Particle % mark_as_lost
  • cross_surface was moved to tracking.F90
  • write_message was moved to error.F90
  • I changed test_fixed_source to be a PyAPI test and increased the source strength by a factor of 10 to make sure we're testing this.
Assignee
Assign to
v0.10
Milestone
v0.10
Assign milestone
Time tracking
2
Labels
Other Enhancement Tallies
Assign labels
  • View project labels
Reference: shikhark/openmc!948