Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
O
openmc
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Shikhar Kumar
  • openmc
  • Issues
  • #1228

Closed
Open
Opened May 02, 2019 by Shikhar Kumar@shikhark
  • Report abuse
  • New issue
Report abuse New issue

Finer-grained control of execution in Picard loops

Created by: aprilnovak

For multiphysics simulations with Picard-style iterations of OpenMC and a second code, it would be helpful to have finer-grained user control of OpenMC execution from within a coupled physics driver. Currently, openmc_simulation_init() and openmc_simulation_finalize() perform many actions that in Picard iterations you might not want to always perform together. For example, openmc_simulation_init() both initializes the source and resets the tallies. For Picard iterations, we will want to reset tallies for each iteration, but might only want to initialize a source at the very start of the simulation.

For Picard iterations, having the following conceptual methods would be helpful:

  • Initialization at the start of the coupled simulation; this is performed only once, and is called from the constructor of the coupled physics driver [openmc_init()]
    • Initialization before entering physics iteration loops; this is performed only once and might use information from CoupledDriver not available in the constructor [openmc_simulation_init()]

      • Initialization before each Picard iteration such as resetting tallies [new method: openmc_simulation_preset() ?]
      • Run OpenMC given initialization and finalization in other methods [new method: openmc_simulation_run() ?]
      • Finalization after each Picard iteration such as writing tallies.out [new method: openmc_simulation_postset() ?]
    • Finalization after leaving physics iteration loops; this is performed only once [openmc_simulation_finalize()]

  • Finalization at the end of the coupled simulation; this is performed only once, and is called from the destructor of a coupled physics driver [openmc_finalize()]

As suggested by @paulromano, adding a couple new methods would be minimally intrusive and wouldn't change the meaning behind the existing openmc_simulation_... methods.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
0
Labels
None
Assign labels
  • View project labels
Reference: shikhark/openmc#1228