Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
S
ssg
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
18
Issues
18
List
Boards
Labels
Milestones
Merge Requests
2
Merge Requests
2
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
sds
ssg
Commits
0dcb3fdc
Commit
0dcb3fdc
authored
Nov 08, 2018
by
Shane Snyder
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
don't dup returned group ids
parent
f008b9ce
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
25 deletions
+2
-25
src/ssg.c
src/ssg.c
+2
-25
No files found.
src/ssg.c
View file @
0dcb3fdc
...
...
@@ -152,19 +152,7 @@ ssg_group_id_t ssg_group_create(
g
=
ssg_group_create_internal
(
group_name
,
group_addr_strs
,
group_size
,
update_cb
,
update_cb_dat
);
if
(
g
)
{
/* on successful creation, dup the group descriptor and return
* it for the caller to hold on to
*/
g_id
=
(
ssg_group_id_t
)
ssg_group_descriptor_dup
(
g
->
descriptor
);
if
(
g_id
==
SSG_GROUP_ID_NULL
)
{
ABT_rwlock_wrlock
(
ssg_inst
->
lock
);
HASH_DELETE
(
hh
,
ssg_inst
->
group_table
,
g
);
ABT_rwlock_unlock
(
ssg_inst
->
lock
);
ssg_group_destroy_internal
(
g
);
}
}
g_id
=
(
ssg_group_id_t
)
g
->
descriptor
;
return
g_id
;
}
...
...
@@ -414,18 +402,7 @@ ssg_group_id_t ssg_group_join(
update_cb
,
update_cb_dat
);
if
(
g
)
{
/* on successful creation, dup the group descriptor and return
* it for the caller to hold on to
*/
g_id
=
(
ssg_group_id_t
)
ssg_group_descriptor_dup
(
g
->
descriptor
);
if
(
g_id
==
SSG_GROUP_ID_NULL
)
{
ABT_rwlock_wrlock
(
ssg_inst
->
lock
);
HASH_DELETE
(
hh
,
ssg_inst
->
group_table
,
g
);
ABT_rwlock_unlock
(
ssg_inst
->
lock
);
ssg_group_destroy_internal
(
g
);
goto
fini
;
}
g_id
=
(
ssg_group_id_t
)
g
->
descriptor
;
/* don't free on success */
group_name
=
NULL
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment