Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • M margo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • sds
  • margo
  • Merge requests
  • !4

refactor provider multiplexing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Carns requested to merge dev-provider-id into master Mar 23, 2018
  • Overview 0
  • Commits 14
  • Changes 17

This PR breaks the Margo api; need to coordinate merge with other sds repos if accepted.

API changes:

  • mplex/MPLEX -> provider/PROVIDER to reflect that we think of these as provider identifiers now
  • removes margo_set_target_id() in favor of *forward() variants that let you specify provider_id
  • replaces margo_lookup_mplex() with margo_hg_handle_get_handler_pool() for cleaner code path in handler (pool is looked up straight from rpc id)

Internal changes: Doesn't use target_id field in Mercury handle anymore, but instead integrates provider_id into a portion of the hg_id_t handle space. This will work better when Mercury PR lands that increases hg_id_t to 64 bits, but won't change any logic here, as margo just takes 1/4th of handle space for provider_id regardless.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dev-provider-id