Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • M margo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • sds
  • margo
  • Merge requests
  • !29

WIP: priority pool implementation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Philip Carns requested to merge carns/dev-prio-pool into master Jul 30, 2020
  • Overview 1
  • Commits 7
  • Changes 4

Replaces the default margo pool with one that prioritizes resumed ULTs over those that have not yet launched. Theoretically this will cause services to emphasize completing in-progress requests before starting new ones if both are possibilities.

ULT's will receive a priority boost no more than PUSH_COUNTER_PRIORITY_LIMIT times being resumed (currently set to 50). This is primarily intended to prevent long-running ULTs (like the progress ULT if co-scheduled with RPC handlers) from repeatedly bypassing runnable RPCs.

To do:

  • performance test
  • clean up code (locking etc.)
  • make configurable
  • expose pool definition for margo users that want to try it on externally-created pools

Pool based on draft implementation created by Shintaro Iwasaki.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: carns/dev-prio-pool