Commit 88ca3639 authored by Philip Carns's avatar Philip Carns
Browse files

document possible issue with benchmark

parent 8b0f2cb0
......@@ -146,6 +146,7 @@ static void abt_bench(int argc, char **argv, unsigned int concurrency, size_t si
progress_xstreams = malloc(concurrency * sizeof(*progress_xstreams));
assert(progress_xstreams);
printf("WARNING: this benchmark may have an issue with one core busy spinning, see comments.\n");
/* set up argobots */
ret = ABT_init(argc, argv);
assert(ret == 0);
......@@ -191,6 +192,10 @@ static void abt_bench(int argc, char **argv, unsigned int concurrency, size_t si
arg.start_time = wtime();
/* TODO: this is likely to be causing the main thread to busy spin
* waiting for the ULTs to complete. Need to confirm. Can be addressed
* in Argobots possibly or by working around with an eventual wait here.
*/
for(i=0; i<concurrency; i++)
ABT_thread_join(tid_array[i]);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment