GitLab

[svn-r10770] removed channel_private field in VC and used MPIDI_CH3_VC_DECL macro which is overridden by channel. Reviewed by Dinan

This removes macro copy-paste clutter that was left around from when this state
moved from MPID_Win into a separate structure.

Reviewer: goodell

Added an additional error check and better documentation of how the state is
tracked and updated for Fence.

Reviewer: goodell

This refinement to the existing PSCW state tracking more cleanly captures the
PSCW state and further restricts erroneous usage.

Reviewer: goodell

This fixes the performance regression that was introduced by concatenation of
per-target lists.

Reviewer: goodell

Moved fence_issued and start_assert MPID_Win members into CH3.  These should
not be a required part of the ADI, since they are not needed above the ADI and
implementations should be free to choose different mechanisms for tracking
the state of synchronization operations.

Reviewer: buntinas

This patch adds code to track the RMA epoch state of the local process.
Currently, we are tracking the synchronization states that are allowed by
MPICH; in the future, we may want to restrict this to only states that are
allowed by the standard.  The addition of epoch tracking has several benefits:

 * It allows us to detect synchronization errors (implemented in this patch).
 * It allows us to implement lock_all more efficiently (implemented in this
   patch).
 * It will allow us to distinguish between active and passive target epochs and
   avoid O(p) op list concatenation (future patch).

Reviewer: balaji

Updated RMA code to remove trailing "_e" and "_s" on enum and struct type
names to match the MPICH style.

Reviewer: goodell

Reviewer: goodell

Updated RMA implementation to track the passive target status individually, for
each target.  Includes new implementation for lock/unlock_all.  Lock_all is
currently unoptimized, see #1734 for future plans.

Reviewer: buntinas

The use of a dense array is a temporary measure to support the reference
implementation.  This will be much improved by ticket #1735.

Reviewer: goodell

In this patch, I have refactored the RMA ops list again to use the MPL UTList
doubly-linked list and to treat the list as a proper object.  This should set
us up to work with multiple lists, as we will soon have one list per target.
Doubly-linking the list is a big help in terms of maintainability (no more
prevNext pointers) and flexibility (better implementation of request-based
ops and other optimizations).

Reviewer: goodell

Implementation of MPI-3 window info query routines.

Reviewer: balaji

No reviewer.

This commit implements MPI-3 RMA's flush and flush_all operations.

Reviewer: buntinas

When enabled, this mode of operation immediately requests the lock when
MPI_Win_lock is called.  Currently, this is enabled by setting the
MPICH_RMA_LOCK_IMMED environment variable.  In the future, we can also make
this mode of operation available though an info/assert.  This capability is
needed to implement MPI-3's flush operations.

Reviewer: buntinas

Reviewer: goodell

By setting "indent-tabs-mode:nil" we should hopefully begin to slowly
squeeze out hard tabs from the source without a disruptive (to
downstream projects) whitespace-fixing change.

No reviewer.

This adds the win_fns table to ch3, which allows the channel to override the
default implementation of window creation routines provided by ch3.  This also
pushes the implementation of shared memory windows down into Nemesis, includes
window functions for sock, and contains multiple improvements to the window
creation functions code.

Reviewer: buntinas

[svn-r10070] fixed up the collective function override mechanism and it's usage in ch3.  Fixes #1634.  Reviewed by goodell@

Nemesis.  In MPI-3, ch3 will require shared memory in order to support
MPI_Win_allocate_shared().

yet implemented below the ADI level.

Without this change we are vulnerable to a nasty bit of compiler
behavior.  MPIDI_CH3_PktGeneric_t sometimes included padding between the
"kind" and "pktptrs" fields.  Then whole-structure assignments using the
generic packet (e.g., ch3_istartmsg.c:96) of buffers that are actually
MPIDI_CH3_Pkt_t unions under the hood will can fail to copy key parts of
the MPIDI_CH3_Pkt_t.

This specifically manifested itself for #1599 by transmitting garbage
"source_win_handle" values in a LOCK_GRANTED packet, which in turn
caused segfaults.

Removing this second type and directly using the actual packet union
eliminates this source of bugs.  The minor downside is that the
mpidpkt.h header becomes more tightly integrated into the rest of the
device.

Reviewed by buntinas@.

Forum ticket #286) and updates MPI_Intercomm_create to use a collectives tag
space which does not conflict with point-to-point communication (MPI Forum
ticket #305).

In addition, this fixes a deadlock bug in context id allocation and adds
several regression tests (comm_dup_deadlock.c exercises this specific bug).

Reviewer: David Goodell

[svn-r9424] Added MPIX_Comm_reenable_anysource functionality.  This is a manual merge of the dev/reenableas branch.  Reviewed by goodell@

Use automake+libtool instead of simplemake+createshlib.  Parallel make
now works for real, and shared library creation should be more robust on
more platforms.  "make dist" now works, modulo building the documentation,
although for boring reasons we can't actually use it for the final
distribution tarball generation.

This is a massive change and without a doubt has some bugs in it.  We'll
work through them as we find them.

No reviewer.

This change consists of four main parts:

 1. Updating all of the MPIR_Ifoo_impl routines to assume that all
    nonblocking collective functions are set in the coll_fns field.

 2. Defining the MPID_Sched_ portion of the ADI in mpir_nbc.h.

 3. Implementing that interface in src/mpid/common/sched

 4. Modifications to ch3:nemesis and ch3:sock in order to call the
    progress engine hook for the scheduling mechanism, as well as
    correctly including the various scheduling headers in CH3 headers.

Reviewed by balaji@.

[svn-r7416] Major improvement to RMA performance for long lists of operations, an immediate mode accumulate for single ints, store the MPID_Comm within the window, and added a basic performance instrumentation interface that was extensively used to improve the RMA performance (enabled with --enable-g=instr).  With these fixes, MPICH2 can run the one-sided version of the Graph500 benchmark at a respectable if not great rate

No reviewer.

[svn-r6115] Use a defined typedef for the message match information; this is needed by the debugger interface

[svn-r5977] Prepare for fix to the debugging interface by providing a name for the message_match_parts structure

This ticket also converts the MPIDI_Request_recv_pending macro into two
macros which have slightly clearer names and usages.  The side effect of
the old macro was very confusing.

Reviewed by buntinas@.

Reviewed by buntinas@.

[svn-r3298] Allow a configure option to set the rank to 16 or 32 bits. 16-bit rank is still the default. 32-bit ranks cannot be used till the Generic packet type size is fixed.

[svn-r3271] Committing the 64-bit optimization code for queue searching. This should make queue searches for the posted queue and the unexpected queue considerably faster for large queue lengths. Reviewed by
buntinas.

This paves the way for some context ID handling changes Pavan is about to make.