The configure script could accidentally override the user's selection
of Fortran compiler for mpif77. Move AC_PROG_F77 until after we've
potentially set F77 = FC.

Signed-off-by: Pavan Balaji <balaji@anl.gov>

Lisandro Dalcin authored Apr 23, 2014 and Rob Latham committed Apr 28, 2014

The standard says a user-defined error code without a string should
return "", not NULL.

Closes #2067

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

a successful test gives ' No Errors'

Lisandro Dalcin authored Apr 22, 2014 and Rob Latham committed Apr 28, 2014

The MPI-3 standard says (pp.354, lines 39-40):

"""
If MPI_ERROR_STRING is called when no string has been set, it will
return a empty
string (all spaces in Fortran, "" in C).
"""

RobL added bits to hook into the test infrastrucutre.

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

if there are a lot of mpi processes with memory errors, the output can
get horribly jumbled if the "memory at address" bit is emitted in one
fprintf call and the "at file/line" bit emitted in a second.  For each
memory region, Build up the address/file-name string in memory and make
one fprintf (instead of two) per memory region.

Signed-off-by: Pavan Balaji <balaji@anl.gov>

This has been essentially removed for a while now and has been
throwing an error when someone uses it.  This patch gets rid of the
code for good.

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

The --enable-f77 and --enable-fc options are deprecated in favor of
--enable-fortran.  However, instead of just breaking existing scripts
that use them, allow them to be used as well.

In the next major release (3.2), we should remove these options and
throw an error if someone uses them.

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

No ABI changes.  Just update the release count.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

This test is behaving badly now as well. Given the overhaul of the ft system
that's coming, we're marking these tests as xfail now instead of putting a lot
of work into fixing them. They'll get cleaned up when the ULFM changes go in.

No reviewer

We moved away from --enable-f77 and --enable-fc to --enable-fortran.

No reviewer.

Pavan Balaji authored Apr 23, 2014 and Kenneth Raffenetti committed Apr 25, 2014

We need a better way to maintain consistency between environment
variables common to the MPICH library and mpiexec.  This patch doesn't
do that, but manually moves all of the variables controlling the port
range to mpiexec as well.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Some NTFS deployments don't like the optimization where one process
creates a file and all processes open.  From Mark Allen: "On windows
when multiple hosts were used, it ended up that in ad_ntfs_open.c rank 0
used CreateFile() with OPEN_ALWAYS and everybody else used
OPEN_EXISTING, and those ranks all saw ERROR_FILE_NOT_FOUND.  As a fix I
added a retry loop and eventually (within 4-5 sec) the remote ranks
would see the file."

Simply have all processes create the file, as was done long long ago.

Signed-off-by: Mark Allen <markalle@us.ibm.com>

Before returning a larger than size 1 communicator in comm_split type,
make sure that the platform gives us the right tools to support shared
memory.  For example, on FreeBSD, pthread_mutexes don't work
correctly, even though they are a part of POSIX.  In such cases, we
return a size 1 communicator in comm_split_type.

Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

No reviewer.

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

The user can now enable/disable fortran using the --enable-fortran
option, instead of separate --enable-f77 and --enable-fc.  Expert
users can control specific Fortran standards to use with
--enable-fortran=f77,f90 (and f08 in the future).

Also allow the user to specify only "FC".  If "F77" is not specified,
we use the same compiler as FC.

We now use mpifort as the primary Fortran wrapper, with mpif90 as a
symlink to it for backward compatibility.  If the user specifies a
different F77 compiler than the FC compiler, or if FFLAGS and FCFLAGS
are different, then a separate mpif77 is generated.  Otherwise, mpif77
is a symlink to mpifort.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Also squash bad white space changes in the move and replace f90
references with fc.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

This was added when we were playing with inter-library dependencies.
Since we don't use it anymore, we can remove this code.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

When we are using the embedded version of libmpl/opa, we can merge it
into libmpi or libpmpi.  It doesn't need to be maintained as a
separate library.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Now that we have decided on consistent library names, we don't need to
do any special setting for ABI compatibility.  Just set the
LD_LIBRARY_PATH and run.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Don't provide a default prefix path since that's updated at make
install time anyway, for example, if the user specifies a new prefix.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

These were gratuitous variables that didn't serve any real purpose.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

The rerun of buildiface for rebuilding mpicxx.h wasn't use the
appropriate init file that reorders the virtual functions.  Also
remove an empty unused variable.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 22, 2014 and Pavan Balaji committed Apr 23, 2014

The paths used in the extractcvars script were not VPATH build safe
earlier.  Since this is mostly called from autogen.sh, it didn't
matter earlier.  But in cases where the make logic tries to run it
again, it was failing.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Lisandro Dalcin authored Apr 22, 2014 and Rob Latham committed Apr 22, 2014

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

Paul Coffman authored Apr 21, 2014 and Rob Latham committed Apr 21, 2014

a bug with the balancecontig optimization could result in the ions
having non-contiguous file offset ranges. this was hurting overall
performance of the optimization plus the gpfs access range hints.

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

In the MPIC_Sendrecv functions, the status object should always be defined
since we use it internally. This won't have any impact on performance since
the default is always to have FT collectives turned on anyway, but it will
prevent a crash when someone overwrites that default.

Fixes #2026

Signed-off-by: Sangmin Seo <sseo@anl.gov>

Pavan Balaji authored Apr 12, 2014 and Kenneth Raffenetti committed Apr 15, 2014

All ROMIO public symbols are being added into the libromio convenience
library, which is LIBADD'ed into libmpi.  The correct behavior would
be for libtool to add -Wl,--whole-archive to the link line, thus
forcing all symbols in libromio to end up in libmpi.  However, in some
cases, this is not working out correctly.  For example, with the
Absoft compiler, the linker flags were being reordered thus causing
the -Wl,--whole-archive flag to not correspond to libromio.
Consequently, only symbols that were used from within the other
functions of libmpi were being included.

For example, Absoft's linker reordering is below:

----8<----
% af77 -v -shared -fPIC src/mpi/attr/.libs/lib_libmpi_la-attrutil.o src/mpi_t/.libs/lib_libmpi_la-pvar_write.o \
  -Wl,--whole-archive src/mpi/romio/.libs/libromio.a -Wl,--no-whole-archive  \
  -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/mpl/.libs \
  -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/openpa/src/.libs \
  -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/install/lib \
  -L/sandbox/balaji/build-absoft/src/mpl -L/sandbox/balaji/build-absoft/src/openpa/src \
  /sandbox/balaji/build-absoft/src/mpl/.libs/libmpl.so /sandbox/balaji/build-absoft/src/openpa/src/.libs/libopa.so \
  -lrt -lpthread  -O0   -Wl,-soname -Wl,libmpi.so.12 -o lib/.libs/libmpi.so.12.0.0

gcc src/mpi/attr/.libs/lib_libmpi_la-attrutil.o src/mpi_t/.libs/lib_libmpi_la-pvar_write.o \
    /sandbox/balaji/build-absoft/src/mpl/.libs/libmpl.so /sandbox/balaji/build-absoft/src/openpa/src/.libs/libopa.so \
    -L/soft/com/packages/absoft11.0/shlib64 -Wl,--whole-archive -Wl,--no-whole-archive \
    -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/mpl/.libs \
    -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/openpa/src/.libs \
    -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/install/lib \
    -L/sandbox/balaji/build-absoft/src/mpl -L/sandbox/balaji/build-absoft/src/openpa/src \
    -Wl,-soname -Wl,libmpi.so.12 -shared -o lib/.libs/libmpi.so.12.0.0 src/mpi/romio/.libs/libromio.a \
    -lrt -lpthread -laf90math -lafio -lamisc -laf77math -lm -lmv
----8<----

In the past, we got lucky in two ways:

1. We were including all the Fortran 77 symbols into libmpi.  Since
the Fortran symbols were calling the C ROMIO symbols, those ROMIO
symbols were pulled in even without -Wl,--whole-archive.

2. The problem only showed up with absoft and nag, both of which are
Fortran-only compilers.  If a C compiler has this issue, it should
have shown up when Fortran support is disabled.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 15, 2014 and Kenneth Raffenetti committed Apr 15, 2014

We were adding both the ROMIO MPI_ and PMPI_ symbols into the
external_libs variable, which end up in the same library.  This patch
separates them out.  It also cleans up the variables to which other
libtool libraries (such as the debug library) are added.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 15, 2014 and Kenneth Raffenetti committed Apr 15, 2014

We were not explicitly linking the application binaries to libpmpi
earlier.  This works fine when the application uses the MPI_ symbols,
but not when the application uses the PMPI_ symbols.  On mac, where a
separate profiling library is built, we were using -flat_namespace to
supress this issue.  But on other platforms, without this flag, the
issue showed up when passing --disable-weak-symbols.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

MPIR_ERRTEST_ARGNULL is incorrect for validating an MPI_Info
handle, since MPI_INFO_NULL is not defined as 0. This updates the
test in MPI_Comm_set_info to match the one in MPI_Win_set_info.

Patch originally from thakur@mcs.anl.gov

if GPFS enabled, we were declaring all file systems GPFS.  This holdover
from the old BlueGene-specific days does not belong here.

Signed-off-by: Paul Coffman <pkcoff@us.ibm.com>

20 years of portability workarounds make for quite a tangle.  Only one
of the four methods is ever used in practice now.  Provide comments
about the older approaches and indicate which one we expect to be the
common case.

Signed-off-by: Paul Coffman <pkcoff@us.ibm.com>

only ad_fstype.c uses GPFS_SUPER_MAGIC now.  Also, GPFS_SUPER_MAGIC is
properly provided by gpfs.h, but we can fall back to old way of
declaring it ourselves if gpfs.h is not around.

Signed-off-by: Paul Coffman <pkcoff@us.ibm.com>