Commits · c83b6b2dbb34238ab371a08b2233bd84d2b463ce · Rob Latham / MPICH-BlueGene

14 Jun, 2015 2 commits

Always free issued OPs when window resource is used up. · c83b6b2d

Min Si authored Jun 10, 2015 and

Pavan Balaji committed Jun 14, 2015



When win resource is used up, the current code frees OPs before
completion only if flush_remote is ordered. However, we can always free
them even on out-of-order network. Because remote completion is waited
by ack counter, and local completion (flush_local) is translated to
remote completion (flush).
Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>
Signed-off-by: Pavan Balaji <balaji@anl.gov>

c83b6b2d

Move outstanding_acks increment to flush sending step. · eef0c70a

Min Si authored Jun 10, 2015 and

Pavan Balaji committed Jun 14, 2015



The outstanding_acks counter was increased at each sync call (such as
fence and flush). However, the counter had to be decreased again if
flush ack is not required. It is more straightforward if increasing it
only when the flush packet is issued (FLUSH flag piggyback or a separate
flush message).
Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>
Signed-off-by: Pavan Balaji <balaji@anl.gov>

eef0c70a

12 Jun, 2015 32 commits

White-space cleanup. · 82c2d652
Pavan Balaji authored Jun 12, 2015

82c2d652
Delete redundant function call. · b9974799
Xin Zhao authored Jun 10, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
b9974799
Move check_and_switch_target/window_state() into issue_ops_target/window(). · bb3e7476
Xin Zhao authored Jun 10, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
bb3e7476

Return a flag from check_and_switch_target/window_state() on issuing ops. · ec785084

Xin Zhao authored May 29, 2015 and

Pavan Balaji committed Jun 12, 2015



Here we make check_and_switch_target/window_state to return a flag
indicating if the current window/target states are OK for issuing
operations.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

ec785084

Change function name used in RMA progress. · 4a53f4cc

Xin Zhao authored May 29, 2015 and

Pavan Balaji committed Jun 12, 2015



check_window_state ---> check_and_switch_window_state
check_target_state ---> check_and_switch_target_state

Both of those two functions are used to check and switch
(if possible) RMA state. Here we change their name to
proper ones.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

4a53f4cc

Modify MPICH infrastructure to support atomic GET. · bf114ec3

Xin Zhao authored May 28, 2015 and

Pavan Balaji committed Jun 12, 2015



When GACC/FOP is used with MPI_NO_OP, the operation is essentially
an atomic GET. Originally MPICH implemented this by converting
GACC/FOP to GET, which lost the atomicity of that operation.

In this patch, we modify the implementation of GACC/FOP to support
atomic GET. Main modifications are listed below:

(1) When streaming GACC operation, originally we use origin data
    size to calculate the stream unit size. Since origin data is
    zero in atomic GET, here we use target data size instead
    to calculate the stream unit size.

(2) On the origin side, if it is atomic GET, CH3 just issues packet
    header and metadata for derived datatypes (if needed) and does
    not try to issue from origin buffer; on the target side, after
    packet header and metadata for derived datatypes (if needed) are
    received, the final request handler is triggered, CH3 does not
    try to receive any data from origin.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

bf114ec3

Delete code of converting GACC/FOP to GET when op is MPI_NO_OP. · 533b84c5
Xin Zhao authored May 28, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
533b84c5

Bug-fix: datatype in FOP should be predefined instead of builtin · 22c16664

Xin Zhao authored May 22, 2015 and

Pavan Balaji committed Jun 12, 2015



Originally MPICH check datatype of FOP by judging if it is a
BUILTIN type, this prohibits all pair types. This patch fix this
issue.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

22c16664

Add comments about MPI_NO_OP in GACC/FOP. · a59e6117
Xin Zhao authored May 28, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
a59e6117

Delete redundant branch for MPI_REPLACE. · 56ede554

Xin Zhao authored May 28, 2015 and

Pavan Balaji committed Jun 12, 2015



Originally, when op is MPI_REPLACE, MPICH does the related
work in a separate IF branch different with other OPs
in MPIR_Op_table[], which is unnecessary, since MPI_REPLACE
has already been implemented in MPIR_Op_table[] (in the
same way with the code in that IF branch). Here we delete
the redundant IF branch but just trigger MPI_REPLACE from
MPIR_Op_table[].
Signed-off-by: Pavan Balaji <balaji@anl.gov>

56ede554

Make do_accumulate_op() perform correctly when op is MPI_NO_OP. · 37cb95b1

Xin Zhao authored May 19, 2015 and

Pavan Balaji committed Jun 12, 2015



Originally before do_accumulate_op() is called, there is a separate
IF branch to deal with MPI_NO_OP, which is gross. Here we modify
do_accumulate_op() to make sure it works correctly for MPI_NO_OP,
and delete those IF branches.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

37cb95b1

Exit immed_copy() if src/dest address is NULL or data length is zero. · 092d6c8e
Xin Zhao authored May 15, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
092d6c8e
Delete redundant function call. · 69c2207d
Xin Zhao authored May 27, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
69c2207d

Code-refactoring: move completion judgement code out of GC function. · a7be0681

Xin Zhao authored May 22, 2015 and

Pavan Balaji committed Jun 12, 2015



In this patch, we move the judgement of local/remote completion
out of GC function to separate macros, so that GC function only
does the garbage collection work.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

a7be0681

Add namespace for num_active_issued_win and num_passive_win. · 77c07868
Xin Zhao authored May 20, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
77c07868
Fix typo error on variable names. · 9fb9c2d3
Xin Zhao authored May 20, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
9fb9c2d3

Change variable name of origin data_sz and target data_sz. · 0185437d

Xin Zhao authored May 19, 2015 and

Pavan Balaji committed Jun 12, 2015



Originally in GACC/GET, we use 'data_sz' for origin data size
and 'len/orig_len' for target data size. Here we change them
to 'orig_data_sz' for origin data size and 'target_data_sz'
for target data size to make it clearer.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

0185437d

Delete redundant variable "len". · 5b1b3bbf

Xin Zhao authored May 19, 2015 and

Pavan Balaji committed Jun 12, 2015



Since both "data_sz" and "len" store the same data (the length
of the entire origin data), here we delete "len" but just use
"data_sz".
Signed-off-by: Pavan Balaji <balaji@anl.gov>

5b1b3bbf

Simplify code of garbage collection functions. · 408c4abf

Xin Zhao authored May 14, 2015 and

Pavan Balaji committed Jun 12, 2015



The original code of going over all issued operation lists
and cleaning up operations is gross, this patches simplifies
the related code.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

408c4abf

Move disable_flush_local into sync struct and rename it. · 74c2007f

Xin Zhao authored May 14, 2015 and

Pavan Balaji committed Jun 12, 2015



Rename "disable_flush_local" to "upgrade_flush_local",
which indicates that we upgrade FLUSH_LOCAL to FLUSH.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

74c2007f

Add "issued_" prefix to read_op_list, write_op_list and dt_op_list. · 8a172d8b

Xin Zhao authored May 14, 2015 and

Pavan Balaji committed Jun 12, 2015



"read_op_list", "write_op_list" and "dt_op_list" are used to store
RMA operations that are issued but not completed. Here we add
prefix to make it clearer.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

8a172d8b

Add "_head" to name of linked lists. · 2db95ef9
Xin Zhao authored Mar 09, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
2db95ef9

Remove "is_dt" flag from op structure. · 299ede6e

Xin Zhao authored Mar 09, 2015 and

Pavan Balaji committed Jun 12, 2015



Originally we use is_dt flag stored in op structure
to track if derived datatypes are involved in the
current RMA operation. The flag is actually not
needed and we can directly check datatypes in the
current operation. Here we remove is_dt flag from
the op structure.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

299ede6e

Remove unused have_remote_incomplete_ops. · 35a05b3c

Xin Zhao authored Mar 09, 2015 and

Pavan Balaji committed Jun 12, 2015



have_remote_incomplete_ops is not actually used
in the code, we remove it here.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

35a05b3c

Simplify code: delete unncessary calculation in IMMED length. · 98c791a6
Xin Zhao authored Mar 09, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
98c791a6
Simplify code: use MPIDI_CH3U_Request_complete to complete user request. · 6ee07af4
Xin Zhao authored Mar 09, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
6ee07af4
Delete useless IF branch. · 6394c667
Xin Zhao authored Mar 09, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
6394c667

Change op pointer name 'new_ptr' to 'op_ptr'. · 86bb1834

Xin Zhao authored May 15, 2015 and

Pavan Balaji committed Jun 12, 2015



Originally 'new_ptr' is used for pointer to RMA operation.
Here we change it from 'new_ptr' to 'op_ptr' to make the
name clearer.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

86bb1834

Delete macros that no longer needed. · 5a1dd956

Xin Zhao authored Mar 09, 2015 and

Pavan Balaji committed Jun 12, 2015



We already drop the code that uses those macros when
re-implementing RMA, here we just delete those macros.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

5a1dd956

Add a test to test atomic GET (GACC/FOP + MPI_NO_OP). · 1e321d46
Xin Zhao authored May 31, 2015 and Pavan Balaji committed Jun 12, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
1e321d46

Test send cancellation issues with unmatched sends · 5bb03747

Halim Amer authored Jun 10, 2015 and

Kenneth Raffenetti committed Jun 12, 2015



In this test, two messages are sent with the same rank, comm, and tag,
and one of them is cancelled before it gets matched. If the
destination does not differentiate between the messages, e.g. by using
sequence numbers or the origin request handle, the wrong message might
be canceled.
Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

5bb03747

answer FIXME in comment for MPIDI_CH3U_Recvq_FDU · ed749773
Kenneth Raffenetti authored Jun 11, 2015
```
Signed-off-by: Halim Amer <aamer@anl.gov>
```
ed749773

11 Jun, 2015 6 commits

tsuite: add MPI version setting to runtests. · d2680c3c

Sangmin Seo authored Jun 11, 2015

To specify the MPI version to use in runtests, -mpiversion option and
the environment variable MPITEST_MPIVERSION were added to runtests.
If neither -mpiversion nor MPITEST_MPIVERSION is set, the default MPI
version, which has been detected by configure, is used for testing.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

d2680c3c

Mark the failing send cancel related tests as xfail · e7142a23
Halim Amer authored Jun 09, 2015
```
Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
```
e7142a23

Bug-fix: free lock entry queue when it was allocated. · 2efebedc

Xin Zhao authored Jun 07, 2015



Originally we allocate the lock entry queue in Win_create/allocate
(if no_locks is not set), and free the queue in Win_free (if no_locks
is not set). This is not correct because no_locks may be set after
Win_create/allocate and before Win_free. In this patch, we free
the queue in Win_free if the queue was allocated in Win_create/allocate.

Thanks to Lisandro Dalcin [dalcinl@gmail.com] for reporting this bug.

Fix #2273
Signed-off-by: Pavan Balaji <balaji@anl.gov>

2efebedc

Bug-fix: fix typo error in Win_set_info. · 9d149761

Xin Zhao authored Jun 07, 2015



Thanks to Lisandro Dalcin [dalcinl@gmail.com] for reporting this bug.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

9d149761

Add tests of setting window info no_locks to TRUE / FALSE. · 6d9d084a
Xin Zhao authored Jun 07, 2015
```
Signed-off-by: Pavan Balaji <balaji@anl.gov>
```
6d9d084a

OFI Netmod: Improve *msg functionality and fix bugs · c229b00e

Charles J Archer authored Jun 10, 2015



 * Fix 32-bit integer overflow
 * Add non-contig support for contig *Msg functions when OFI permits
 * Remove asserts for better error handling in out of memory condition

Change-Id: I0eaa848c9919b7f4b3088b64b9fef79fd5ad2406
Signed-off-by: Charles J Archer <charles.j.archer@intel.com>

c229b00e