Xin Zhao authored Jul 31, 2013 and Pavan Balaji committed Aug 01, 2013

When judging if origin and target process are on the same node, using vc->node_id flag instead of vc->ch.is_local flag.

Flag 'is_local' is not correct because it is defined in nemesis, not in CH3.
Flag 'node_id' is defined in CH3.

Note that for ch3:sock, even if origin and target are on the same node, they are not within the same SHM region.
Currently ch3:sock is filtered out by checking shm_allocated flag first. In future we need to figure out a way to
check if origin and target are within the same "SHM comm".

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 31, 2013 and Pavan Balaji committed Aug 01, 2013

Because if MPI_WIN_FLAVOR_SHARED is used in ch3:sock, it will allocate normal memory
instead of shared memory, therefore shm_base_addrs will not be used.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 30, 2013 and Pavan Balaji committed Aug 01, 2013

Because CH3 layer needs to know if shared memory region is allocated in lower layer.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

In general, added weak symbol support for compilers supporting
__attribute__((weak,alias)) instead of #pragma weak.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
Signed-off-by: William Gropp <wgropp@illinois.edu>

In MPICH, Win_attach/detach are essentially no-ops.  The actual
accumulate calls don't actually check if the actual buffer is attached
or not.  This is technically a user error.  The win_dynamic_acc test
had a wrong buffer attached, but was still passing because of this
reason.  This patch only corrects the test program.

Thanks to Michael Raymond @ SGI for reporting the error.

Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

Fault tolerance is only supported under hydra, so we configure the
tests to run only when it is the primary PM. Fixes #1914.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

While testing on the Blue Waters development system, builds failed
because the code for determining the Fortran Module options was unable to
figure out the Cray compiler (naturally, this used to work).  Investigation
showed that the compiler needs a "-em" option to create separate module
files.  This change adds a test for that, if the compiler is unable to
create module files without that option.  This also cleans up several other
minor problems with this code.

Fix touch command in autogen.sh that generates a random file and reruns
configure during first make.

Some systems (MACs) require the options to be specified prior to the target
file for the touch command. This commit fixes the option order in the touch
command in autogen.sh introduced to fix ticket #1870.

Signed-off-by: Antonio J. Pena <apenya@mcs.anl.gov>

Adds tests for when -disable-auto-cleanup is enabled and a process
dies or calls MPI_Abort. There is no communication in these cases.

Signed-off-by: Wesley Bland <wbland@mcs.anl.gov>

No reviewer necessary.

Xin Zhao authored Jul 24, 2013 and Pavan Balaji committed Jul 28, 2013

Because shared memory region is not exposed to the user but just an runtime
optimization, it is not useful to allocate a contiguous memory region.

If user set alloc_shared_noncontig to "false", alloc_shared_noncontig will be set to 0.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 22, 2013 and Pavan Balaji committed Jul 28, 2013

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 22, 2013 and Pavan Balaji committed Jul 28, 2013

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 22, 2013 and Pavan Balaji committed Jul 28, 2013

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 22, 2013 and Pavan Balaji committed Jul 28, 2013

If "alloc_shm" is set, it may happen that the target process is doing a RMA operation
from a remote process concurrently with a local process is also doing a RMA operation
on the same target and on overlapping memory location.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 26, 2013 and Pavan Balaji committed Jul 28, 2013

Delete decrementing ref count in SHM RMA operations, but add conditions in operaiton issue routines.

In RMA operation issue routines, judge if shm_allocate == 1 and target vc
is local, if so, do not add reference count on datatypes, because they will not
be referenced by the progress engine, but will be completed directly by origin.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 26, 2013 and Pavan Balaji committed Jul 28, 2013

If shared memory is allocated for window, and target vc is local,
do SHM RMA operations.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 26, 2013 and Pavan Balaji committed Jul 28, 2013

decrement datatype reference counts in SHM RMA operations.
because they will not be referenced by the progress engine, but be
completed directly by origin.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 22, 2013 and Pavan Balaji committed Jul 28, 2013

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 22, 2013 and Pavan Balaji committed Jul 28, 2013

Add "alloc_shm" to window's info arguments and initialize it to FALSE.
In MPID_Win_allocate, if "alloc_shm" is set to true, call ALLOCATE_SHARED,
otherwise call ALLOCATE.

Free window memory only when SHM region is not allocated, therwise it is
already freed in MPIDI_CH3I_SHM_Win_free.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 22, 2013 and Pavan Balaji committed Jul 28, 2013

The code in inline functions is moved from operation routines in
ch3u_rma_ops.c and ch3u_rma_acc_ops.c. By moving them in inline
functions, both operation routines and synchronization routines can call them.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 22, 2013 and Pavan Balaji committed Jul 28, 2013

MPIDI_CH3I_Win_allocate_shared can be called by both MPI_Win_allocate_shared
and MPI_Win_allocate. If it is called by MPI_Win_allocate, we need node_comm,
node_sizes and node_shm_base_addrs to allocate shm segment region, hence we need
to copy from win_ptr->sizes to node_sizes at beginning and copy from node_shm_base_addrs
to win_ptr->shm_base_addrs at last. If it is called by MPI_Win_allocate_shared,
these copies can be eliminated.

If there is only one process on this node, node_comm is NULL, we use comm_self instead.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 26, 2013 and Pavan Balaji committed Jul 28, 2013

This is for the optimization of allocating shared memory region in
MPI_Win_allocate. In this case MPIDI_CH3_SHM_Win_free must first wait
for passive RMA operations to finish before free the shared memory region.

Note that because MPIDI_CH3_SHM_Win_free calls MPIDI_Win_free at last,
and MPIDI_Win_free will also call inline function of waiting for passive
RMA operation to finish, in this case the inline function will be called
twice.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Xin Zhao authored Jul 26, 2013 and Pavan Balaji committed Jul 28, 2013

Moving code of waiting finish of passive RMA operations from MPIDI_Win_free
to an inline function in mpidrma.h.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Added checking to see if ckpoint context files exist
and are non-empty.

Antonio J. Pena authored Jul 24, 2013 and Pavan Balaji committed Jul 26, 2013

Fixes ticket #1870.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Checkpointing tests only run if --enable-checkpointing is
configured. First test is to see if mpiexec can successfully
checkpoint a job using blcr.

Signed-off-by: Wesley Bland <wbland@mcs.anl.gov>

Wesley Bland authored Jul 25, 2013 and Pavan Balaji committed Jul 25, 2013

This environment variable is no longer necessary now that FT and NBC will play
well together. We'll keep this one around for one more version, then delete it
in MPICH-3.2.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 23, 2013 and Pavan Balaji committed Jul 25, 2013

Add a description for the FT and NBC work to the CHANGES file.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.Rename MPIC_Send_ft to MPIC_Send

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.Rename MPIC_Send_ft to MPIC_Send

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>