1. 15 Nov, 2013 11 commits
    • Antonio J. Pena's avatar
      Fix compiler warning in tcp_init.c · c2dc7a35
      Antonio J. Pena authored
      
      
      Fixes the following warning when compiling tcp_init.c with --enable-strict:
      
      src/mpid/ch3/channels/nemesis/netmod/tcp/tcp_init.c: In function
      'GetSockInterfaceAddr':
      src/mpid/ch3/channels/nemesis/netmod/tcp/tcp_init.c:248:9: warning:
      dereferencing type-punned pointer will break strict-aliasing rules
      [-Wstrict-aliasing]
      
      Reported in ticket #1966
      Signed-off-by: default avatarWesley Bland <wbland@mcs.anl.gov>
      c2dc7a35
    • Antonio J. Pena's avatar
      Fix warnings about possible uninitialized accesses · d8b8eb6f
      Antonio J. Pena authored
      
      
      Fixes compiler warnings related to the possible use of uninitialized memory in
      mpiu_chkpmem_stk_[0] and mpir_sched_chkpmem_stk_[0]. A couple of examples:
      
      src/mpid/ch3/src/ch3u_rma_sync.c: In function 'MPIDI_CH3I_Recv_rma_msg':
      src/mpid/ch3/src/ch3u_rma_sync.c:1265:5: warning: 'mpiu_chkpmem_stk_[0]'
      may be used uninitialized in this function [-Wmaybe-uninitialized]
      
      src/mpi/coll/iallgather.c: In function 'MPIR_Iallgather_bruck':
      src/mpi/coll/iallgather.c:329:5: warning: 'mpir_sched_chkpmem_stk_[0]' may
      be used uninitialized in this function [-Wmaybe-uninitialized]
      
      While the code seems correct, this patch avoids the warning.
      
      See ticket #1966
      Signed-off-by: default avatarWesley Bland <wbland@mcs.anl.gov>
      d8b8eb6f
    • Antonio J. Pena's avatar
      Fix warning in opminloc.c and opmaxloc.c · 6e8dae1b
      Antonio J. Pena authored
      
      
      Fixes the following warnings (with --enable-strict):
      
      src/mpi/coll/opminloc.c: In function 'MPIR_MINLOC':
      src/mpi/coll/opminloc.c:85:24: warning: variable 'flen' set but not used
      [-Wunused-but-set-variable]
      
      src/mpi/coll/opmaxloc.c: In function 'MPIR_MAXLOC':
      src/mpi/coll/opmaxloc.c:86:24: warning: variable 'flen' set but not used
      [-Wunused-but-set-variable]
      
      See ticket #1966
      Signed-off-by: default avatarWesley Bland <wbland@mcs.anl.gov>
      6e8dae1b
    • Antonio J. Pena's avatar
      Fix warning in mpltrmem.c · 8822485c
      Antonio J. Pena authored
      
      
      Fixes the following warning (with --enable-strict):
      
      src/mpltrmem.c: In function 'MPL_trdump':
      src/mpltrmem.c:584:14: warning: variable 'old_head' set but not used
      [-Wunused-but-set-variable]
      
      See ticket #1966
      
      Modifications by: Wesley Bland <wbland@mcs.anl.gov>
      Signed-off-by: default avatarWesley Bland <wbland@mcs.anl.gov>
      8822485c
    • Antonio J. Pena's avatar
      Fixed --enabled-debuginfo segfaults · 65a3af43
      Antonio J. Pena authored
      
      
      Added support for Ibsend and persistent sends, and fixed all other cases by
      clearing out the dgb-next field of send requests. Closes #1932.
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      65a3af43
    • Xin Zhao's avatar
      Add more tests in test/mpi/rma/rmazero.c. · 5014a82c
      Xin Zhao authored
      
      
      Add tests of using derived datatype in MPI_ACCUMULATE to
      test handling of zero-byte transfer, because packet handler
      of MPI_ACCUMULATE is differernt for predefined datatype and
      derived datatype.
      Signed-off-by: default avatarWesley Bland <wbland@mcs.anl.gov>
      5014a82c
    • Xin Zhao's avatar
      Fix #1701 - cleanup code for zero-size data transfer. · dc9275be
      Xin Zhao authored
      
      
      Delete code for zero-size data transfer in packet handlers
      of Put/Accumulate/Accumulate_Immed/Get_AccumulateResp/GetResp/
      LockPutUnlock/LockAccumUnlock, because they are redundant.
      
      (Note that packet handlers of LockPutUnlock and LockAccumUnlock
      are for single operation optimization in passive RMA)
      
      Zero-size data transfer has already been handled when issuing
      RMA operations (L146, L258, L369 in src/mpid/ch3/src/ch3u_rma_ops.c
      and L50 in src/mpid/ch3/src/ch3u_rma_acc_ops.c). RMA operation
      routines will directly exit if data size is zero.
      Signed-off-by: default avatarWesley Bland <wbland@mcs.anl.gov>
      dc9275be
    • Antonio J. Pena's avatar
      Revert Fixed --enabled-debuginfo segfaults tt#1932 · b9531d3d
      Antonio J. Pena authored
      This reverts commit 676c29f9.
      b9531d3d
    • Antonio J. Pena's avatar
      Fixed --enabled-debuginfo segfaults tt #1932 · 676c29f9
      Antonio J. Pena authored
      
      
      Addresses #1932. Includes:
        - MPI_Bsend/MPI_Ibsend
        - Several collectives
        - Some RMA operations
        - MPI_Dist_graph_create
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      676c29f9
    • Xin Zhao's avatar
      Fix ticket-1960: delete redundant MPIU_Assert. · 0b126663
      Xin Zhao authored
      
      
      MPIU_Assert at L2311 checks if rma_ops_list is empty before exiting
      MPIDI_Win_flush. It causes /test/mpi/threads/rma/multirma to fail
      because while one thread is executing the loop of poking progress
      engine at L2293 ~ L2302, another thread may enqueue new RMA operations
      to rma_ops_list.
      
      rma_ops_list has already been checked for empty before exiting
      MPIDI_CH3I_Do_passive_target_rma (L2724) to ensure that all enqueued
      operations are issued out, therefore it does not need to be checked
      again here.
      Signed-off-by: default avatarWesley Bland <wbland@mcs.anl.gov>
      0b126663
    • Antonio J. Pena's avatar
      Fix manpages not installed for VPATH builds · a5412fec
      Antonio J. Pena authored
      
      
      Fixes #1976
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      a5412fec
  2. 14 Nov, 2013 5 commits
  3. 13 Nov, 2013 4 commits
    • Kenneth Raffenetti's avatar
      increase timeout for large_type_sendrec test · cba9da60
      Kenneth Raffenetti authored
      
      
      This should give our OSX build slaves enough time to pass.
      Signed-off-by: Rob Latham's avatarRob Latham <robl@mcs.anl.gov>
      cba9da60
    • Huiwei Lu's avatar
      Fix #1879 - fix test script · 40c6fda9
      Huiwei Lu authored
      
      
      fix testlist
      Signed-off-by: default avatarJunchao Zhang <jczhang@mcs.anl.gov>
      40c6fda9
    • Huiwei Lu's avatar
      Fix #1879 - false alarm, bug is in user code · 85e4a507
      Huiwei Lu authored
      First, this ticket is caused in the user code of ibsend.c where multiple
      pthreads are created using the same pthread variable. This leads
      to unexpected behaviors where detached threads screw
      up with MPI_Comm_free when both of them calls ALLFUNC lock in
      unexpected order, thus leads to the assertion failure in initthread.c:213.
      
      Second, BSEND lock in the proposed patch in trac is unnecessary.
      Basically the patch is to create a
      new lock, BSEND, to lock the function of MPIR_Bsend_isend for thread
      safety; however, MPIR_Bsend_isend is already called inside a ALLFUNC
      lock both in MPI_Bsend and MPI_Ibsend.
      
      See attached test/mpi/threads/pt2pt/ibsend.c for correct use of
      pthread_create and pthread_join
      85e4a507
    • Huiwei Lu's avatar
      Fix #1879 - Adds a test case for ibsend · ad44b6b3
      Huiwei Lu authored
      Adds a test case for ibsend/bsend/isend/send in threading
      execution.
      ad44b6b3
  4. 12 Nov, 2013 1 commit
  5. 11 Nov, 2013 3 commits
  6. 08 Nov, 2013 2 commits
  7. 07 Nov, 2013 6 commits
  8. 06 Nov, 2013 1 commit
  9. 05 Nov, 2013 4 commits
  10. 03 Nov, 2013 3 commits