GitLab

Moved RMA implementation constants from mpidimpl.h to the RMA implementation
header.  Also updated constants to use enumeration types and removed an old
fixme note, which indicated that this should be done.

Reviewer: buntinas

The MPIDI_CH3U_Request_load_recv_iov function must fill the iov in the
rreq at offset 0 *and* set rreq->dev.iov_offset to 0 because callers of
this function as an OnDataAvail function don't know what action is
occurring in the handler and can't set the offset to zero themselves.

See r4099 and ticket #462 for some info on the previous test1_dt bug.

Reviewed by buntinas@.

[svn-r3070] Added ATTRIBUTE((unused)) (which is defined to work with gcc and disappear for other compilers only to the functions whose arguments are defined by a general pattern (such as a request handler) and thus must be used even if not needed.  For functions that have parameters that are not used and are not needed to conform to a pattern, do not use ATTRIBUTE((unused)), instead, fix the routine to either make use of the argument in a real way or change the routine to not pass the argument.