Antonio J. Pena authored Jul 03, 2014 and Kenneth Raffenetti committed Jul 07, 2014

Moved the weak,alias attribute declarations from header files to the
implementation. Complies with the requirement that alias targets are
defined in the same compilation unit.

Fixes #2002

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

moved some error messages which should have been mpix to mpi.

Reviewed by dinan.

MPI_.

A slightly older version of this patch was reviewed by goodell.

In several places, after checking for a parameter (e.g., comm) we were
directly using it assuming that the parameter is valid.  Since the
previous ERRTEST macros did not jump to fn_fail on an error, this
could result in undefined behavior if the parameter was invalid.  Now,
since we jump on errors within the macros themselves, once the check
is done, we know that the parameter values are valid.

Reviewed by buntinas.

The default nonblocking implementations use the naive "as-if" code from
the draft MPI-3 standard.  No attempt is made to optimize the
communication patterns at this time.

The default blocking implementations simply call the corresponding
nonblocking versions.  NBC overheads are unlikely to be too large for
most neighborhood collective use cases.  If this assertion turns out to
be false at some point then we can revisit this implementation choice.

Reviewed by buntinas@.  (modulo a few last minute fixes)

Split up so that the later impl code is easier to find/read.

Reviewed by buntinas@.