Skip to content
GitLab
Switch branch/tag
  1. 03 Nov, 2014 8 commits
  3. 01 Nov, 2014 3 commits
    • Xin Zhao's avatar
      Bug-fix: avoid free NULL pointer in RMA. · 72a1e6f8
      Xin Zhao authored 
      

req->dev.user_buf points to the data sent from origin process
to target process, and for FOP sometimes it points to the IMMED
area in packet header when data can be fit in packet header.
In such case, we should not free req->dev.user_buf in final
request handler since that data area will be freed by the
runtime when packet header is freed.

In this patch we initialize user_buf to NULL when creating the
request, and set it to NULL when FOP is completed, and avoid free
a NULL pointer in final request handler.

Signed-off-by: default avatarMin Si <msi@il.is.s.u-tokyo.ac.jp>
      72a1e6f8
    • Igor Ivanov's avatar
      netmod/mxm: Avoid calling mxm send req handling from mxm send completion callback · 5f78f0fa
      Igor Ivanov authored 
      

Signed-off-by: default avatarDevendar Bureddy <devendar@mellanox.com>
Signed-off-by: default avatarIgor Ivanov <Igor.Ivanov@itseez.com>
      5f78f0fa
    • Xin Zhao's avatar
      Bug-fix: always waiting for remote completion in Win_unlock. · c76aa786
      Xin Zhao authored and Pavan Balaji's avatar Pavan Balaji committed 
      

The original implementation includes an optimization which
allows Win_unlock for exclusive lock to return without
waiting for remote completion. This relys on the
assumption that window memory on target process will not
be accessed by a third party until that target process
finishes all RMA operations and grants the lock to other
processes. However, this assumption is not correct if user
uses assert MPI_MODE_NOCHECK. Consider the following code:

          P0                              P1           P2
    MPI_Win_lock(P1, NULL, exclusive);
    MPI_Put(X);
    MPI_Win_unlock(P1, exclusive);
    MPI_Send (P2);                                MPI_Recv(P0);
                                                  MPI_Win_lock(P1, MODE_NOCHECK, exclusive);
                                                  MPI_Get(X);
                                                  MPI_Win_unlock(P1, exclusive);

Both P0 and P2 issue exclusive lock to P1, and P2 uses assert
MPI_MODE_NOCHECK because the lock should be granted to P2 after
synchronization between P2 and P0. However, in the original
implementation, GET operation on P2 might not get the updated
value since Win_unlock on P0 return without waiting for remote
completion.

In this patch we delete this optimization. In Win_free, since every
Win_unlock guarantees the remote completion, target process no
longer needs to do additional counting works to detect target-side
completion, but only needs to do a global barrier.

Signed-off-by: Pavan Balaji's avatarPavan Balaji <balaji@anl.gov>
      c76aa786
  5. 31 Oct, 2014 6 commits
  7. 30 Oct, 2014 4 commits
  9. 29 Oct, 2014 5 commits
  11. 28 Oct, 2014 3 commits
    • Xin Zhao's avatar
      Revert "netmod/mxm: Avoid calling mxm send req handling from mxm send completion callback" · e2db1e48
      Xin Zhao authored 
      This reverts commit 20f1f116.
      e2db1e48
    • Paul Coffman's avatar
      Assign large blocks first in ADIOI_GPFS_Calc_file_domains · c16466e3
      Paul Coffman authored and Rob Latham's avatar Rob Latham committed 
      

For files that are less than the size of a gpfs block there seems to be
an issue if successive MPI_File_write_at_all are called with proceeding
offsets.  Given the simple case of 2 aggs, the 2nd agg/fd will be utilized,
however the initial offset into the 2nd agg is distorted on the 2nd call
to MPI_File_write_at_all because of the negative size of the 1st agg/fd
because the offset info the 2nd agg/fd is influenced by the size of the
first.  Simple solution is to reverse the default large block assignment so
in the case where only 1 agg/fd will be used it will be the first.  By chance
in the 2 agg situation this is what the GPFSMPIO_BALANCECONTIG
optimization does and it does not have this problem.

Signed-off-by: Rob Latham's avatarRob Latham <robl@mcs.anl.gov>
      c16466e3
    • Paul Coffman's avatar
      MP_IOTASKLIST error checking · 976272a7
      Paul Coffman authored and Rob Latham's avatar Rob Latham committed 
      

PE users may manually specify the MP_IOTASKLIST for explicit aggregator
selection.  Code needed to be added to verify that the user
specification of aggregators were all valid.

Do our best to maintain the old PE behavior of using as much of the
correctly specified MP_IOTASKLIST as possible and issuing what it
labeled error messages but were really warnings about the incorrect
portions and functionally just ignoring it, unless none of it was usable
in which case it fell back on the default.

Signed-off-by: Rob Latham's avatarRob Latham <robl@mcs.anl.gov>
      976272a7
  13. 27 Oct, 2014 1 commit
  15. 26 Oct, 2014 1 commit
  17. 25 Oct, 2014 2 commits
  19. 24 Oct, 2014 2 commits
  21. 23 Oct, 2014 5 commits