1. 14 Jan, 2015 2 commits
    • Rob Latham's avatar
      use PATH_MAX instead of magic number · a30a4721
      Rob Latham authored
      
      
      User on OpenMPI list wanted to create a 259 character file.  shared file
      pointer name construction used the magic '256' value to construct a full
      path to the hidden shared file pointer file.  PATH_MAX already exists
      for this purpose, so use it.
      
      While there, found a few spots checking/setting PATH_MAX, so do that in
      one place
      
      Closes #2212
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      a30a4721
    • Rob Latham's avatar
      make ADIOI_Shfp_fname report errors · ed39c901
      Rob Latham authored
      
      
      Right now there's only one error condition: file name too long.  This
      change checks return codes of ADIOI_Strncpy and informs caller.
      Otherwise, really long names result in buffer overruns.
      
      See #2212
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      ed39c901
  2. 13 Nov, 2014 1 commit
  3. 01 Oct, 2014 1 commit
  4. 16 Sep, 2014 1 commit
    • Rob Latham's avatar
      Remove comm_split in deferred open case · 6b9e0dc0
      Rob Latham authored
      comm_split might scale poorly on some systems, and we don't even use the
      resulting communicator.  it was used as a marker, but we have enough
      other information.
      6b9e0dc0
  5. 22 Aug, 2014 1 commit
  6. 11 Aug, 2014 2 commits
  7. 18 Jul, 2014 3 commits
  8. 26 Mar, 2014 7 commits
    • Rob Latham's avatar
      clean up P2Pcontig warnings · 3e37d5b4
      Rob Latham authored
      P2Pcontig needed a prototype and clang complaiend about several shadowed
      declarations.
      3e37d5b4
    • Paul Coffman's avatar
      ad_bg to ad_gpfs major reorganization · d4b3106d
      Paul Coffman authored and Rob Latham's avatar Rob Latham committed
      reconfiguration changes from bg to gpfs with platformspec; removal of
      lockless
      d4b3106d
    • Rob Latham's avatar
      Promote blocksize to ADIOI_FileD struct · fdc4cb6f
      Rob Latham authored
      "file system blocksize" seems like one of those generic-enough values we
      should keep track of in the ADIOI_FileD structure.  This promotion will
      make some deferred-open fixes easier, too.
      fdc4cb6f
    • Rob Latham's avatar
      option to read/write to /dev/null · 87102f40
      Rob Latham authored
      Useful for situations like evaluating various collective I/O approaches.
      Reading/writing /dev/null eliminates file system variablity.
      87102f40
    • Paul Coffman's avatar
      balancecontig: topology-aware aggregator seleciton · 35d0c5b4
      Paul Coffman authored and Rob Latham's avatar Rob Latham committed
      Two features in this change:
      - selection of file domains can result in some i/o nodes with more work
        than others (or some with no work at all), so distribute file domains
        with some awareness of i/o nodes
      
      - since we have some awareness of I/O nodes, select processes that are
        closes to those i/o nodes.
      35d0c5b4
    • Rob Latham's avatar
      Two-phase I/O with threaded write · 0a437100
      Rob Latham authored
      Experimental async-with-pthread I/O approach to hiding some of the I/O
      latency/variability from the two-phase collectives.
      
      heavily modified from Paul Coffman's (pkcoffman@us.ibm.com) original work
      0a437100
    • Rob Latham's avatar
      Allocate two-phase buffer outside write path · 5e34974e
      Rob Latham authored
      There are many memory allocations in the write path.  Allocating the
      two-phase intermediate buffer outside of the write path might on some
      systems make a small difference, especially if there are many collective
      I/O calls, or if the system (like Blue Gene) has a small amount of
      memory.  Modified from Paul Coffman <pkcoff@us.ibm.com>'s original idea.
      5e34974e
  9. 15 Mar, 2014 1 commit
  10. 05 Jan, 2014 1 commit
  11. 03 Jan, 2014 1 commit
    • Rob Latham's avatar
      bring back include file needed for MPI_AINT_CAST_TO_VOID_PTR · 3146e104
      Rob Latham authored
      In romio-standalone fixes, I zapped the inclusion of mpitypedefs.h, but
      the "ensure this large value fits into pointer without overflowing"
      check relied on some MPICH-internal macros/routines.  Only Blue Gene
      driver uses those routines, so nightly tests didn't flag it.
      
      No reviewer.
      3146e104
  12. 17 Dec, 2013 1 commit
    • Rob Latham's avatar
      Introduce and use ADIO_TWO_PHASE feature-check · f571b0e5
      Rob Latham authored
      
      
      the old deferred open code explicitly checked for the presence of
      ADIOI_GEN_WriteStrided and ADIOI_GEN_ReadStrided functions in the file
      system specific struct.  This is needlessly specific: lustre and
      bluegene, for example re-implemented two phase but as a different (and
      differently named) function
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      f571b0e5
  13. 14 Nov, 2013 1 commit
  14. 31 Oct, 2013 5 commits
  15. 04 Oct, 2013 1 commit
    • Rob Latham's avatar
      reduce duplcated code in hint processing · 270d5115
      Rob Latham authored
      for years we've added hints by cutting and pasting.  Turn all this
      dupilcated code into common hint processing funcitons.   Still need to
      do this for all drivers, too
      270d5115
  16. 15 May, 2013 2 commits
  17. 14 May, 2013 1 commit
    • Rob Latham's avatar
      avoid hang if subset of procs have invalid INFO · 470667cb
      Rob Latham authored
      In response to IBM's integration ticket 1822 (but reworked), turn
      MPIO_CHECK_INFO into a collective macro; exchange result of info
      inspection with all procs.  Now a bogus info on one proc won't cause a
      process hang.
      470667cb
  18. 12 Apr, 2013 2 commits
    • Michael Blocksome's avatar
      BG ROMIO changes that remained unresolved after the merge. · 21db6f2e
      Michael Blocksome authored
      I think these are "really old" baseline changes that didn't get pushed
      into the top-level mpich master branch during previous (?) code
      contributions.
      
      These changes are needed at this point because the following commits,
      that were essentially cherry-picked from the ibm master branch, depend
      on some of these romio changes in this commit.
      21db6f2e
    • Michael Blocksome's avatar
      BG ROMIO changes that remained unresolved after the merge. · 8a5655f6
      Michael Blocksome authored
      I think these are "really old" baseline changes that didn't get pushed
      into the top-level mpich master branch during previous (?) code
      contributions.
      
      These changes are needed at this point because the following commits,
      that were essentially cherry-picked from the ibm master branch, depend
      on some of these romio changes in this commit.
      8a5655f6
  19. 05 Feb, 2013 1 commit
    • Dave Goodell's avatar
      tt#1754: fix warnings in ROMIO external32 code · d8eec549
      Dave Goodell authored
      This doesn't fix any of the serious bugs or inefficiencies present in
      the current external32 implementation.  But it at least fixes some very
      valid warnings related to const-ness and passing incorrect pointer
      types.
      
      References ticket #1754
      
      Reviewed-by: robl
      d8eec549
  20. 20 Dec, 2012 2 commits
    • David Goodell's avatar
      [svn-r10801] ROMIO: error checking for MPI_Comm and MPI_Info objects · 47754bc5
      David Goodell authored
      1). There was error checking on the comm object in
          MPI_Comm_test_inter(comm, &flag); So if the return value of
          MPI_Comm_test_inter is not MPI_SUCCESS, then the comm is either an
          invalid MPI_Comm handle or intercommunicator handle.
      2). A new macro MPIO_CHECK_INFO is added into adioi_error.h. It will
          call MPI_Info_dup, unless there is no more memory space left , as
          long as the info object is valid, this function will return
          MPI_SUCCESS; or it will return an error code. So by checking the
          return value of MPI_Info_dup, we could achieve the purpose of
          checking MPI_Info handles.
      
      Based on patch 0006 from the second round of IBM's error checking
      patches.  Replaces 0009 from the first round and augments r10637.
      47754bc5
    • David Goodell's avatar
      [svn-r10799] ROMIO: check whether datatypes are committed · 011f107a
      David Goodell authored
      This only works when ROMIO is built with MPICH.
      
      Based on patch 0001 from the second round of IBM's error checking
      patches.  Replaces 0008 from the first round.
      011f107a
  21. 26 Nov, 2012 1 commit
  22. 20 Nov, 2012 2 commits