GitLab

Xin Zhao authored Nov 10, 2014 and Rob Latham committed Nov 11, 2014

We already moved all functions from src/mpid/ch3/src/ch3u_rma_acc_ops.c
to src/mpid/ch3/src/ch3u_rma_ops.c and deleted the previous one from
Makefile.mk, here we just delete this file.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Xin Zhao authored Nov 10, 2014 and Rob Latham committed Nov 11, 2014

We already use window states to specify the current
state in RMA epoch, therfore the epoch states are
no longer used. Here we delete those states.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Xin Zhao authored Nov 10, 2014 and Rob Latham committed Nov 11, 2014

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Xin Zhao authored Nov 10, 2014 and Rob Latham committed Nov 11, 2014

For lock type, we only need one internal value
to specify cases when currently there is no passive
lock issued from origin side or there is no passive
lock imposed on target side. If there are passive
locks, we directly use MPI_LOCK_SHARED and
MPI_LOCK_EXCLUSIVE to indicate the lock type. This
patch deletes redundant enum for lock types and just
defines MPID_LOCK_NONE.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Xin Zhao authored Nov 10, 2014 and Rob Latham committed Nov 11, 2014

It is helpful for us to find variables that are not initialized
or wrongly initialized.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Xin Zhao authored Nov 10, 2014 and Rob Latham committed Nov 11, 2014

MPIDI_RMA_NONE is the initial value of window state
and should not be used with sync flag. The initial
value of sync flag should be set to MPIDI_RMA_SYNC_NONE.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Norio Yamaguchi authored Oct 07, 2014 and Pavan Balaji committed Nov 11, 2014

Instead of overriding malloc functions, set some hook functions only
when using netmod-IB.

Corresponding to the implementations of RMA in the upper layer.

We mistakenly deleted CVAR category 'CH3' when deleting
unnecessary CVARs in RMA, here we add it back.
Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

Without it, the code is broken in Intel's MPI build
Signed-off-by: Antonio J. Pena <apenya@mcs.anl.gov>

No reviewer

Junchao Zhang authored Nov 07, 2014 and Pavan Balaji committed Nov 08, 2014

Signed-off-by: Pavan Balaji <balaji@anl.gov>

Junchao Zhang authored Nov 07, 2014 and Pavan Balaji committed Nov 08, 2014

If --enable_strictmpi is passed to configure, we need to skip non-MPI-standard tests.
Here is how you can do that. Suppose you have an MPIX test foobar, you need

1) In Makefile.am, to skip building foobar, add

    if BUILD_MPIX_TESTS
    noinst_PROGRAMS += foobar
    endif

  Note: There is no tab indentions before noinst_PROGRAMS

2) In testlist.in (please convert testlist to testlist.in if necessary), to skip
   running foobar, add

    @mpix@ foobar 2
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Junchao Zhang authored Nov 07, 2014 and Kenneth Raffenetti committed Nov 07, 2014

The expressions are wrong, e.g., [test "X$f77dir" = "f77"] should be [test "$f77dir" = "f77"].
Also, these vars are not used. So we just remove them.
Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Signed-off-by: Min Si <msi@il.is.s.u-tokyo.ac.jp>

num_active_issued_win and num_passive_win are counters of
windows in active ISSUED mode and in passive mode.
It is modified in CH3 and is used in progress engine of
nemesis / sock to skip windows that do not need to make
progress on. Here we define them in mpidi_ch3_pre.h in
nemesis / sock so that they can be exposed to upper layers.
Signed-off-by: Min Si <msi@il.is.s.u-tokyo.ac.jp>

Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Some of the code to do the matching for requests in the posted queue was
missing. This caused local collectives to hang if the communicator had
been revoked.

See #1945
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Set the counter for processes to be revoked before calling sending out
the revoke notifications.

Clean up some unused code.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

When the parameter of 'env' is parsed the first time, it adds an extra
space in the front. When the script kicks off each test, this extra
space is not a correct form the script want to interpret and it
complains in the output: "not in a=b form".
Signed-off-by: Wesley Bland <wbland@anl.gov>

MPIR_CVAR_ENABLE_FT is added to enable/disable fault tolerance related
code. For performance consideration, FT is disabled by default.

Changes FT related LMT RTS code to use this CVAR.
Signed-off-by: Wesley Bland <wbland@anl.gov>

For fault tolerance use, a RTS queue is added in [81b3911a

] to track shm
LMT RTS messages. However, the queue is global and static, which may not
be scalable.

This patch moves the RTS queue to struct MPIDI_CH3I_VC, to be VC
specific as the lmt_queue is.  Also it improves the queue to use
GENERIC_Q and the 'dev.next' field so it does not need to malloc
additional space.
Signed-off-by: Wesley Bland <wbland@anl.gov>

A recent testsuite update unveiled an issue when unpacking a large
noncontiguous message. We need to ignore any previous segment
manipulation when unpacking the beginning of the message.
Signed-off-by: Antonio J. Pena <apenya@mcs.anl.gov>

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

ircpi.c is an interactive test, which is never triggered
in RMA test suite. It is better to put it under examples.
Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

This test should be fixed by the latest commits.

See #1945
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Improves the anysource test by doing more error checking to provide
better output.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

We will now return a request handle from MPI_IRECV even if there is a
failure. The reason for this is because the ULFM spec says that even if
the function returns MPIX_ERR_PROC_FAILED_PENDING, it still should
provide a valid request that can be completed later.

This doesn't cause a problem for other situations because the value of
the request is undefined in that scenario so it's fine for it to be
garbage.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Before calling the progress engine, make sure none of the operations
should return an error for MPIX_ERR_PROC_FAILED_PENDING. They would
cause the progress engine to hang (potentially) so we can't enter it.
Instead, mark the appropriate error codes and return immediately.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Anysource requests involving a communicator that isn't collectively
active should be appended to the posted queue the error class should be
marked as MPIX_ERR_PROC_FAILED_PENDING. The operation can still be
completed later.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

This function will check to see if a request can be completed if it
involves MPI_ANY_SOURCE. An any source request cannot be completed if
the communicator is not collectively active.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

There is a complete overhaul of this file on the way, but in the meantime
we raise these limits to prevent deadlock in MPI_Finalize with process
count >= 12.

No reviewer.

The F77/90 test is marked as xfail for a bug at
https://trac.mpich.org/projects/mpich/ticket/1877

Signed-off-by: Wesley Bland <wbland@anl.gov>

Signed-off-by: Pavan Balaji <balaji@anl.gov>

Signed-off-by: Pavan Balaji <balaji@anl.gov>

These two functions will be included in MPI-3.1 and hence are implemented as MPIX.
See more about this MPI-Forum ticket at https://svn.mpi-forum.org/trac/mpi-forum-web/ticket/349



Fixes #2134, #2136
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Signed-off-by: Wesley Bland <wbland@anl.gov>

Some mpi tests such as bcast2 and bcast3 take 20mins to run all the
datatypes on tcp. Therefore, we also define a minimum version of the
datatype generator which only generates vector and indexed tests so that
such heavy tests can use the min version to shorten time.

We enable the full version by default, tests can turn to min version by
calling the corresponding init func before datatype loop.

In coll/bcast2, coll/bcast3 and pt2pt/pingpong tests, we change to min
version from the second datatype loop.
Signed-off-by: Wesley Bland <wbland@anl.gov>

0 count is not allowed in subarray. Please revert this change if it has
special reason to set count-1 in the datatype while loop.
Signed-off-by: Wesley Bland <wbland@anl.gov>