GitLab

RTS messages (the first part of the LMT sequence) had no way of being
cancelled if an error occurred. This adds a small queue that keeps track
of these messages. If a failure is detected, the message is removed from
the queue and the associated request is cancelled to get out of the
progress engine.

See #1945
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Added another send call to this test to take out the race condition. Now, the
test should fail under any circumstances if the send request isn't being
cleaned up correctly.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

The default --enable-error-checking (used when no additional value is
included) value ended up getting set to "yes" instead of "default". This
ended up preventing configure from passing under certain conditions.
This changes the default to "all" and fixes the check for "yes".
Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

No reviewer.

If the testsuite is configured with --disable-rma, ensure that rma
tests in the threads directory do not still run.
Signed-off-by: Wesley Bland <wbland@anl.gov>

There are two request handlers used when receiving data:
(1) OnDataAvail, which is triggered when data is arrived;
(2) OnFinal, which is triggered when receiving data is finished;

When receiving large derived datatype, the receiving iov can be divided
into multiple iovs. The OnDataAvail handler is set to iov load function
when still waiting for remaining data. However, such handler should be
set to OnFinal when starting receiving the last iov.

The original code does not set OnDataAvail handler to OnFinal at end.
This patch fixes this bug.

Note that this bug only appears in RMA calls, because only the RMA
packet handers need to specify OnFinal.

Resolve #2189.
Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

This patch is a workaround for an issue with older HPC-X machines.
Once we are comfortable upgrading to the latest HPC-X version, the
default value of the CVAR should be changed to true.
Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

No review since F08 binding is experimental now.

No review since F08 binding is experimental now.

This is needed since we pass these arguments by value

No review since F08 binding is experimental now.

Set reasonable limits for maximum unexpected headers and EQs at init
time. We accomplish this with a pre-init stage where we fill in a limits
struct with the system defaults, increase certain values (if they are not
set already in the environment), then do the real init.

If the "desired" limits structure had a way to allow default values for
limits we don't care about, the pre-init stage could go away.
Signed-off-by: Antonio J. Pena <apenya@mcs.anl.gov>

Out previous increase consumed too much memory. 8MB should be enough given
the maximum put size and number of headers.
Signed-off-by: Antonio J. Pena <apenya@mcs.anl.gov>

This reverts commit 20f1f116.

Paul Coffman authored Oct 27, 2014 and Rob Latham committed Oct 28, 2014

For files that are less than the size of a gpfs block there seems to be
an issue if successive MPI_File_write_at_all are called with proceeding
offsets.  Given the simple case of 2 aggs, the 2nd agg/fd will be utilized,
however the initial offset into the 2nd agg is distorted on the 2nd call
to MPI_File_write_at_all because of the negative size of the 1st agg/fd
because the offset info the 2nd agg/fd is influenced by the size of the
first.  Simple solution is to reverse the default large block assignment so
in the case where only 1 agg/fd will be used it will be the first.  By chance
in the 2 agg situation this is what the GPFSMPIO_BALANCECONTIG
optimization does and it does not have this problem.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Paul Coffman authored Oct 27, 2014 and Rob Latham committed Oct 28, 2014

PE users may manually specify the MP_IOTASKLIST for explicit aggregator
selection.  Code needed to be added to verify that the user
specification of aggregators were all valid.

Do our best to maintain the old PE behavior of using as much of the
correctly specified MP_IOTASKLIST as possible and issuing what it
labeled error messages but were really warnings about the incorrect
portions and functionally just ignoring it, unless none of it was usable
in which case it fell back on the default.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

This code did not account for the fact that the first part of the message
is already sent in a PtlPut.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

The defaults used by MXM might not be fully appropriate for mpich.  So
we automatically initialize it to our preferred defaults unless the
user is trying to override it.
Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

This reverts commit 4ce4103a.

Devendar Bureddy authored Oct 25, 2014 and Pavan Balaji committed Oct 25, 2014

Do not block in mxm for blocking sends. Instead , set req pointer let
MPICH mpi layer to block on it. This will allow progress go to through
MPIDI_CH3I_Progress(), which can release the global mutex in thread
multiple case.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

"native", "internal", and "external32" are the only valid values for
datarep, but if a user passes null
(http://stackoverflow.com/questions/26548398/segmentation-fault-while-using-mpi-file-read-at/

)
then strcmp will segfault.
Signed-off-by: Wesley Bland <wbland@anl.gov>

The defaults used by MXM might not be fully appropriate for mpich.  So
we automatically initialize it to our preferred defaults unless the
user is trying to override it.
Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

Set the unpexected message header limit to 2 million and allocate
512MB of buffer space.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Unmark sendalive, isendalive, multi_isendalive, recvdead, irecvdead, gather

Back in the 3.1 series, we made the FT versions of all of the MPIC functions
default. However, we never changed the names of all of the states. This
removes the extra state names.

No reviewer.

Igor Ivanov authored Oct 20, 2014 and Pavan Balaji committed Oct 23, 2014

Signed-off-by: Devendar Bureddy <devendar@mellanox.com>
Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>

These tests pass even with debugging output on.

See #1945

No reviewer.

Pavan Balaji authored Oct 21, 2014 and Kenneth Raffenetti committed Oct 22, 2014

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

In the macro MPID_nem_lmt_send_RTS, the request for the send was being freed
on an error even if it didn't exist. This caused a segfault if calling a bcast
after a process previously failed.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

The macro that called the bcast function left out an underscore in the
mpi_errno return value. This caused the test to always return MPI_ERR_OTHER
instead of the value being returned by the underlying bcast function.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

The previous commit only adjusted the tag checking proceedure for MPIC_Recv,
but it should be the same for MPIC_Sendrecv and MPIC_Sendrecv_replace.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Signed-off-by: Wesley Bland <wbland@anl.gov>

Signed-off-by: Wesley Bland <wbland@anl.gov>

Paul Coffman authored Oct 19, 2014 and Rob Latham committed Oct 20, 2014

ADIOI_GPFS_WriteStridedColl and ADIOI_GPFS_ReadStridedColl need to call
MPIR_Status_set_bytes when GPFSMPIO_P2PCONTIG=1.

When the GPFSMPIO_P2PCONTIG optimization is set, the code path for
ADIOI_GPFS_WriteStridedColl and ADIOI_GPFS_ReadStridedColl returns
before MPIR_Status_set_bytes is called.  Duplicate the call to
MPIR_Status_set_bytes in the GPFSMPIO_P2PCONTIG code path.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Update a debug-only print string to accomodate recent updates to the
type of the length parameter.

No reviewer

Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Tags were sometimes being tested when the communication call had already
failed, leading to bad asserts later due to uninitialized values. Sometimes,
these results would have ended up with an error anyway, but sometimes not.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

The calls in MPID_Comm_get_all_failed_procs and MPID_Comm_agree  were the
wrong macros for entering and exiting an MPID function. This corrects it.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Revoke will call MPIDI_CH3U_Clean_recvq to dequeue all requests with
revoked communicators. There is one missing case: when there's hierarchy
communicators that use a different context id. This patch adds a case to
check the hierarchy communicators.
Signed-off-by: Wesley Bland <wbland@anl.gov>

Simplifies the test to only use 2 processes and not make as many MPI calls.

Modifications by Wesley Bland.
Signed-off-by: Wesley Bland <wbland@anl.gov>