1. 19 Jan, 2014 4 commits
  2. 18 Jan, 2014 4 commits
    • Pavan Balaji's avatar
      Time iterations and break out if we are too slow. · 29c8529f
      Pavan Balaji authored
      
      
      On some machines the iterations take unusually long.  If they are
      getting to be larger than a predefined amount, break out of that loop.
      
      Fixes #1669.
      
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      29c8529f
    • Pavan Balaji's avatar
      White space cleanup. · 57dc1401
      Pavan Balaji authored
      The code was unparseable to make any changes.
      57dc1401
    • Kenneth Raffenetti's avatar
      compile wrapper cleanup · eb42f624
      Kenneth Raffenetti authored and Pavan Balaji's avatar Pavan Balaji committed
      
      
      Simplify logic in compile wrapper scripts. Use configure substitutions
      where possible to better match pkg-config style.
      
      Signed-off-by: Pavan Balaji's avatarPavan Balaji <balaji@mcs.anl.gov>
      
      Includes the following modifications by Pavan Balaji:
      
      Remove the PAC_COMPILER_SHLIB_FLAGS usage, instead of modifying the
      macro in confdb.
      
      The ordering of flags in mpicc and friends does not match that of
      pkg-config.  This is because of two reasons.
      
      1. pkg-config reorders flags when it outputs them.  This requires us
      to manually adjust the flags in mpicc to match up, and is error prone.
      
      2. mpicc and friends provide LDFLAGS before the user-specified flags,
      followed by the include and library directories.  This is to make sure
      that the LDFLAGS are listed before the application source file.
      Reordering them to match pkg-config loses this flexibility.
      
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      eb42f624
    • Kenneth Raffenetti's avatar
      Improve pkg-config support · be278b7c
      Kenneth Raffenetti authored and Pavan Balaji's avatar Pavan Balaji committed
      
      
      Add rpath flags to pkg-config to match compiler wrappers. Fixes #1044
      
      Signed-off-by: Pavan Balaji's avatarPavan Balaji <balaji@mcs.anl.gov>
      be278b7c
  3. 16 Jan, 2014 3 commits
    • Rob Latham's avatar
      a partial round of datatype optimizations · 38ef5818
      Rob Latham authored
      
      
      Some datatype performance tests in the MPICH test suite fail:
      (perf/twovec,  perf/nestvec, perf/nestvec2, perf/indexperf,
      perf/transp-datatype).
      
      This changeset introduces a few optimizations that operate on the
      dataloop representation to make it more performant.  perf/indexperf
      should still fail under these changes.
      
      Original-author: Bill Gropp <wgropp@illinois.edu>
      
      See #1788, for which this resolves some but not all performance issues.
      
      Signed-off-by: Rob Latham's avatarRob Latham <robl@mcs.anl.gov>
      38ef5818
    • William Gropp's avatar
      Fix bogus datatype perf test · 4e1b470d
      William Gropp authored
      The test in test/mpi/perf/twovec made invalid assumptions about the
      performance of two MPI datatype creation routines.  This is a hard test to
      get right, but this version is more likely to avoid falsely signalling
      an error.
      4e1b470d
    • Pavan Balaji's avatar
      Comment out nb_test, since it's not entirely correct. · cf551af4
      Pavan Balaji authored
      
      
      This was meant to test out the case when MPI_Test is not nonblocking.
      However, we ended up assuming that MPI_Win_lock will be nonblocking.
      That is not specified by the standard and might not be true.
      Commenting this out till be find a better way to test the original
      problem with MPI_Test.
      
      Fixes #1910.
      
      Signed-off-by: Rajeev Thakur's avatarRajeev Thakur <thakur@mcs.anl.gov>
      cf551af4
  4. 15 Jan, 2014 5 commits
  5. 13 Jan, 2014 2 commits
  6. 11 Jan, 2014 1 commit
  7. 10 Jan, 2014 6 commits
  8. 09 Jan, 2014 2 commits
  9. 08 Jan, 2014 7 commits
    • Sameer Kumar's avatar
      Bug fix for strided datatypes. · 4b07ac8a
      Sameer Kumar authored and Pavan Balaji's avatar Pavan Balaji committed
      
      
      Full fix
      
      Fix for get accumulate that sends contig ack back and then scatters result buffer on the src node.
      
      Remove unused params.
      
      Signed-off-by: default avatarMichael Blocksome <blocksom@us.ibm.com>
      4b07ac8a
    • Su Huang's avatar
      PAMID: fix memory leak problem · c03e766f
      Su Huang authored and Pavan Balaji's avatar Pavan Balaji committed
      
      
      Signed-off-by: default avatarMichael Blocksome <blocksom@us.ibm.com>
      c03e766f
    • Su Huang's avatar
      Fix multiple FCNAME declarations error. · 039c2290
      Su Huang authored and Pavan Balaji's avatar Pavan Balaji committed
      
      
      Also clean up warnings.
      
        src/mpid/pamid/src/dyntask/mpidi_port.c:53: warning: useless storage class
        specifier in empty declaration
      
      Signed-off-by: default avatarMichael Blocksome <blocksom@us.ibm.com>
      039c2290
    • Su Huang's avatar
      PAMID: segfault occurred in MPIDI_Win_DoneCB · e25dc31f
      Su Huang authored and Pavan Balaji's avatar Pavan Balaji committed
      
      
      The segfault occurred while trying to free an already freed request
      handle in MPIDI_Win_DoneCB. To fix the problem, the second MPIU_Free(req)
      is removed from the routine.
      
      Signed-off-by: default avatarMichael Blocksome <blocksom@us.ibm.com>
      e25dc31f
    • Su Huang's avatar
      PAMID: fixes for MPI_Win_* · 31ac6f01
      Su Huang authored and Pavan Balaji's avatar Pavan Balaji committed
      
      
      PAMID: fixes for RMA shared related, lock_all and unlock_all functions
      
      The following has been updated:
      - MPID_Win_allocated_shared
      - MPID_Win_shared_query
      - several functions in mpid_win_lock_all.c, mpid_win_lock.c, mpid_win_free.c and
        structures in mpidi_onesided.h, mpidi_datatypes.h have been modified for
        scalability support for MPID_Win_lock_all() and MPID_Win_unlock_all()
      
      PAMID: fix MPID_Win_allocate_shared, MPID_Win_lock_all/unlock_all and MPID_Win_shared_query
      
      Add changes based on code review feedback from the team:
      1) update getPageSize to ensure that the pagesize is obtained from the range of
         passed in address.
      2) don't call dispatcher if lockQ[index].done == 1
         if (!lockQ[index].done)
           MPID_PROGRESS_WAIT_WHILE(lockQ[index].done == 0);
      3) in mpid_win_shared_query()
         replace
           MPID_assert(win->create_flavor == MPI_WIN_FLAVOR_SHARED);
         by
           MPIU_ERR_CHKANDSTMT((win->create_flavor != MPI_WIN_FLAVOR_SHARED), mpi_errno,
                               MPI_ERR_RMA_FLAVOR, return mpi_errno, "**rmaflavor");
      3) some minor fixes.
      
      PAMID: modify MPI_Win_flush_local, MPI_Win_lock etc for better performance
      
      The current implementation for the subject mentioned function is to allocate
      two counters for each rank in the window group. The design could cause a scaling
      issue.  The fix is to update MPI_Win_flush_local etc with two counters per
      window approach.
      
      The changes also include the follwoing:
      - provides mutex_lock/mutex_unlock for atomic operations in shared window
      - fixes some bugs in handling shared window.
      - removes the shared segment with IPC_RMID in MPI_Win_free.
      
      PAMID: fixed base address for each rank in a window group
      
      For shared window, the base address for each rank should not be
      exchanged among ranks in a window group. Without the fix, the job
      will be terminated with segfault.
      
      (ibm) F189033
      (ibm) D194640
      
      Signed-off-by: default avatarMichael Blocksome <blocksom@us.ibm.com>
      31ac6f01
    • Su Huang's avatar
      PAMID: MPID_Win_allocate_shared and MPID_Win_shared_query support · c6d910c7
      Su Huang authored and Pavan Balaji's avatar Pavan Balaji committed
      
      
      added MPID_Win_allocate_shared and MPID_Win_shared_query support and
      fixes on passing incorrect rank to MPIDI_WinCtrlSend in MPIDI_WinPost_post
      and MPIDI_WinComplete_post
      
      minor fixes for 'win allocate shared'
      
      - compiles for bgq
      - UNRESOLVED: undefined shm key on bgq, or any other time the required
        environment variables are not set
      - UNRESOLVED: multiple calls to 'win allocate shared' will use the same
        shm key
      
      (ibm) F189033
      
      Signed-off-by: default avatarMichael Blocksome <blocksom@us.ibm.com>
      c6d910c7
    • Pavan Balaji's avatar
      pamid is capable of supporting WIN_UNIFIED. · 399e5463
      Pavan Balaji authored
      
      
      Renamed WIN_SEPARATE to WIN_UNIFIED.  pamid's WIN_SYNC already does a
      full memory barrier, so we should be all set for UNIFIED support.
      
      Signed-off-by: default avatarMichael Blocksome <blocksom@us.ibm.com>
      399e5463
  10. 07 Jan, 2014 4 commits
  11. 06 Jan, 2014 2 commits