GitLab

There was an accidental ADI breakage earlier when MPI level codes would
query into the dev part of the MPID request object. This commit removes
that breakage by adding a new macro into the mpiimpl.h file to portably
check whether a request is anysource. For now, in pamid, this macro
always evaluates to 0. This can easily be fixed by overwriting it in the
pamid code, but since pamid doesn't support FT, it won't have any
functional change either.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

This macro was used inside CH3 to determine if the communicator could be
used for anysource communication. With the rewrite of the anysource
fault tolerance logic, it is now necessary to use it at the MPI level.
Because it is a macro and not a function, the macro is defined in
mpiimple.h as (1) and then overwritten in the ch3 device. Future devices
can also overwrite it if desired.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

If a blocking recv function (MPI_Recv and MPI_Sendrecv) includes an
MPI_ANY_SOURCE and there is a failure, handle it by cleaning up the
request and returning MPIX_ERR_PROC_FAILED.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Adds a parameter to MPID_Comm_valid_ptr to take a second parameter that will
either cause the macro to ignore the revoke flag or not.
Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

Antonio J. Pena authored Jul 03, 2014 and Kenneth Raffenetti committed Jul 07, 2014

Moved the weak,alias attribute declarations from header files to the
implementation. Complies with the requirement that alias targets are
defined in the same compilation unit.

Fixes #2002
Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

By setting "indent-tabs-mode:nil" we should hopefully begin to slowly
squeeze out hard tabs from the source without a disruptive (to
downstream projects) whitespace-fixing change.

No reviewer.

In several places, after checking for a parameter (e.g., comm) we were
directly using it assuming that the parameter is valid.  Since the
previous ERRTEST macros did not jump to fn_fail on an error, this
could result in undefined behavior if the parameter was invalid.  Now,
since we jump on errors within the macros themselves, once the check
is done, we know that the parameter values are valid.

Reviewed by buntinas.

When compiled for fine-grained threading, the completion counter serves
as a form of lockfree signalling.  As such, atomic access and memory
barriers must be used to ensure correctness.

In per-object mode, this code also contains valgrind client request annotations
to inform Helgrind/DRD/TSan about the lockfree signalling pattern.

No reviewer.

This is done as a separate commit to de-clutter the change with actual
logic changes in it.

No reviewer.

[svn-r5355] Added (or moved) MPIU_THREADPRIV_DECL so that the thread-private area is acquired only once within a routine, since the data (pointer to the thread-private area) is fixed during the execution.  This reduces the overhead of the nest increment/decrement, for example

[svn-r3177] Switch to the new macro for the global thread critical section (most of this is an automated change, tested against the MPICH2 test suite)