1. 31 Oct, 2013 1 commit
  2. 29 Oct, 2013 1 commit
  3. 17 Dec, 2012 1 commit
  4. 10 Oct, 2012 1 commit
  5. 10 Jul, 2012 1 commit
  6. 15 Apr, 2012 1 commit
    • David Goodell's avatar
      [svn-r9716] tt#1599: eliminate MPIDI_CH3_PktGeneric_t · f868be22
      David Goodell authored
      Without this change we are vulnerable to a nasty bit of compiler
      behavior.  MPIDI_CH3_PktGeneric_t sometimes included padding between the
      "kind" and "pktptrs" fields.  Then whole-structure assignments using the
      generic packet (e.g., ch3_istartmsg.c:96) of buffers that are actually
      MPIDI_CH3_Pkt_t unions under the hood will can fail to copy key parts of
      the MPIDI_CH3_Pkt_t.
      
      This specifically manifested itself for #1599 by transmitting garbage
      "source_win_handle" values in a LOCK_GRANTED packet, which in turn
      caused segfaults.
      
      Removing this second type and directly using the actual packet union
      eliminates this source of bugs.  The minor downside is that the
      mpidpkt.h header becomes more tightly integrated into the rest of the
      device.
      
      Reviewed by buntinas@.
      f868be22
  7. 09 Mar, 2012 1 commit
  8. 09 Dec, 2011 1 commit
  9. 08 Dec, 2011 1 commit
  10. 07 Dec, 2011 1 commit
  11. 10 Nov, 2011 2 commits
  12. 23 Mar, 2011 1 commit
  13. 10 Mar, 2011 1 commit
  14. 17 Feb, 2011 2 commits
  15. 09 Aug, 2010 1 commit
  16. 01 Apr, 2010 1 commit
  17. 15 Mar, 2010 1 commit
  18. 08 Mar, 2010 1 commit
  19. 05 Mar, 2010 1 commit
  20. 01 Dec, 2009 1 commit
  21. 27 Oct, 2009 1 commit
  22. 11 May, 2009 1 commit
  23. 06 May, 2009 2 commits
  24. 30 Mar, 2009 1 commit
  25. 26 Mar, 2009 1 commit
  26. 05 Mar, 2009 1 commit