- 15 Nov, 2013 17 commits
-
-
Antonio J. Pena authored
Fixes the following warning: PGC-W-0155-Pointer value created from a nonlong integral type (tools/ckpoint/ckpoint.c: 86) Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
They were causing compiler warnings Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
src/mpi/init/init.c: In function 'PMPI_Init': src/mpi/init/init.c:78:9: warning: variable 'rc' set but not used [-Wunused-but-set-variable] src/mpi/init/initthread.c: In function 'PMPI_Init_thread': src/mpi/init/initthread.c:554:9: warning: variable 'rc' set but not used [-Wunused-but-set-variable] Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes warnings in mpid_type_debug.c about unused variables in MPIDI_Datatype_printf. Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes the following warning in ch3u_handle_connection.c whith --enable-strict: src/mpid/ch3/src/ch3u_handle_connection.c:317:194: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes the following warnings when compiling pmip_cb.c with --enable-strict: pm/pmiserv/pmip_cb.c:803:9: warning: null argument where non-null required (argument 1) [-Wnonnull] pm/pmiserv/pmip_cb.c:803:9: warning: null argument where non-null required (argument 2) [-Wnonnull] Related to ticket #1966 Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes the following warning when compiling tcp_init.c with --enable-strict: src/mpid/ch3/channels/nemesis/netmod/tcp/tcp_init.c: In function 'GetSockInterfaceAddr': src/mpid/ch3/channels/nemesis/netmod/tcp/tcp_init.c:248:9: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] Reported in ticket #1966 Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes compiler warnings related to the possible use of uninitialized memory in mpiu_chkpmem_stk_[0] and mpir_sched_chkpmem_stk_[0]. A couple of examples: src/mpid/ch3/src/ch3u_rma_sync.c: In function 'MPIDI_CH3I_Recv_rma_msg': src/mpid/ch3/src/ch3u_rma_sync.c:1265:5: warning: 'mpiu_chkpmem_stk_[0]' may be used uninitialized in this function [-Wmaybe-uninitialized] src/mpi/coll/iallgather.c: In function 'MPIR_Iallgather_bruck': src/mpi/coll/iallgather.c:329:5: warning: 'mpir_sched_chkpmem_stk_[0]' may be used uninitialized in this function [-Wmaybe-uninitialized] While the code seems correct, this patch avoids the warning. See ticket #1966 Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes the following warnings (with --enable-strict): src/mpi/coll/opminloc.c: In function 'MPIR_MINLOC': src/mpi/coll/opminloc.c:85:24: warning: variable 'flen' set but not used [-Wunused-but-set-variable] src/mpi/coll/opmaxloc.c: In function 'MPIR_MAXLOC': src/mpi/coll/opmaxloc.c:86:24: warning: variable 'flen' set but not used [-Wunused-but-set-variable] See ticket #1966 Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes the following warning (with --enable-strict): src/mpltrmem.c: In function 'MPL_trdump': src/mpltrmem.c:584:14: warning: variable 'old_head' set but not used [-Wunused-but-set-variable] See ticket #1966 Modifications by: Wesley Bland <wbland@mcs.anl.gov> Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
Added support for Ibsend and persistent sends, and fixed all other cases by clearing out the dgb-next field of send requests. Closes #1932. Signed-off-by:
Ken Raffenetti <raffenet@mcs.anl.gov>
-
Xin Zhao authored
Add tests of using derived datatype in MPI_ACCUMULATE to test handling of zero-byte transfer, because packet handler of MPI_ACCUMULATE is differernt for predefined datatype and derived datatype. Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Xin Zhao authored
Delete code for zero-size data transfer in packet handlers of Put/Accumulate/Accumulate_Immed/Get_AccumulateResp/GetResp/ LockPutUnlock/LockAccumUnlock, because they are redundant. (Note that packet handlers of LockPutUnlock and LockAccumUnlock are for single operation optimization in passive RMA) Zero-size data transfer has already been handled when issuing RMA operations (L146, L258, L369 in src/mpid/ch3/src/ch3u_rma_ops.c and L50 in src/mpid/ch3/src/ch3u_rma_acc_ops.c). RMA operation routines will directly exit if data size is zero. Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
This reverts commit 676c29f9.
-
Antonio J. Pena authored
Addresses #1932. Includes: - MPI_Bsend/MPI_Ibsend - Several collectives - Some RMA operations - MPI_Dist_graph_create Signed-off-by:
Ken Raffenetti <raffenet@mcs.anl.gov>
-
Xin Zhao authored
MPIU_Assert at L2311 checks if rma_ops_list is empty before exiting MPIDI_Win_flush. It causes /test/mpi/threads/rma/multirma to fail because while one thread is executing the loop of poking progress engine at L2293 ~ L2302, another thread may enqueue new RMA operations to rma_ops_list. rma_ops_list has already been checked for empty before exiting MPIDI_CH3I_Do_passive_target_rma (L2724) to ensure that all enqueued operations are issued out, therefore it does not need to be checked again here. Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes #1976 Signed-off-by:
Ken Raffenetti <raffenet@mcs.anl.gov>
-
- 14 Nov, 2013 5 commits
-
-
Junchao Zhang authored
Fixes #1969 Signed-off-by:
Antonio J. Pena <apenya@mcs.anl.gov>
-
Junchao Zhang authored
-
IBM Issue 9705: instead of checking "file system A or file system B", use the file-system feature. also closes #1724 Signed-off-by:
Rob Latham <robl@mcs.anl.gov>
-
per http://stackoverflow.com/questions/2132273/what-does-malloc0-return , malloc(0) may or may not return NULL. it is implementation defined in C99. therefore, it is incorrect to throw an OoM error on !new when size=0. closes #1947 Signed-off-by:
Rob Latham <robl@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes #1781 Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
- 13 Nov, 2013 4 commits
-
-
Kenneth Raffenetti authored
This should give our OSX build slaves enough time to pass. Signed-off-by:
Rob Latham <robl@mcs.anl.gov>
-
Huiwei Lu authored
fix testlist Signed-off-by:
Junchao Zhang <jczhang@mcs.anl.gov>
-
Huiwei Lu authored
First, this ticket is caused in the user code of ibsend.c where multiple pthreads are created using the same pthread variable. This leads to unexpected behaviors where detached threads screw up with MPI_Comm_free when both of them calls ALLFUNC lock in unexpected order, thus leads to the assertion failure in initthread.c:213. Second, BSEND lock in the proposed patch in trac is unnecessary. Basically the patch is to create a new lock, BSEND, to lock the function of MPIR_Bsend_isend for thread safety; however, MPIR_Bsend_isend is already called inside a ALLFUNC lock both in MPI_Bsend and MPI_Ibsend. See attached test/mpi/threads/pt2pt/ibsend.c for correct use of pthread_create and pthread_join
-
Huiwei Lu authored
Adds a test case for ibsend/bsend/isend/send in threading execution.
-
- 12 Nov, 2013 1 commit
-
-
Fixes #1954 Signed-off-by:
Ken Raffenetti <raffenet@mcs.anl.gov>
-
- 11 Nov, 2013 3 commits
-
-
Antonio J. Pena authored
Added support to handle --program-suffix and --program-prefix options. Fixes #1967. Signed-off-by:
Ken Raffenetti <raffenet@mcs.anl.gov>
-
Kenneth Raffenetti authored
Test collectives where all processes do not contribute to the result. These tests use the MPI_Comm_group_create function to create a new communicator excluding the failed process in order to do error collection. Closes #1901 Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes #1965 Signed-off-by:
Michael Blocksome <blocksom@us.ibm.com>
-
- 08 Nov, 2013 2 commits
-
-
Rob Latham authored
instead of assigning and then checking for overflow, check if the overflow will happen, and then assign. Signed-off-by:
Antonio J. Pena <apenya@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes #1971 Signed-off-by:
Xin Zhao <xinzhao3@illinois.edu>
-
- 07 Nov, 2013 6 commits
-
-
Kenneth Raffenetti authored
No reviewer
-
Huiwei Lu authored
Changes singe long line function definitions to multiple lines Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Huiwei Lu authored
Adds man pages for nonblocking collectives Signed-off-by:
Wesley Bland <wbland@mcs.anl.gov>
-
Junchao Zhang authored
Also added comments to make it less misleading. Signed-off-by:
Antonio J. Pena <apenya@mcs.anl.gov>
-
Antonio J. Pena authored
Fixes #884. Signed-off-by:
Junchao Zhang <jczhang@mcs.anl.gov>
-
Antonio J. Pena authored
The full path of the test is test/mpi/f90/datatype/get_elem_d.f90 Signed-off-by:
Junchao Zhang <jczhang@mcs.anl.gov>
-
- 06 Nov, 2013 1 commit
-
-
Junchao Zhang authored
Fixed a set of compiler warnings related to MPI_T code when compiled with -Wall, including "assignment discards 'const' qualifier from pointer target type", "unused variable", "shadows a global declaration" etc. Signed-off-by:
Antonio J. Pena <apenya@mcs.anl.gov>
-
- 05 Nov, 2013 1 commit
-
-
Antonio J. Pena authored
-