GitLab

Rob Latham authored Feb 16, 2015 and Kenneth Raffenetti committed Feb 25, 2015

lustre, or specifically the header files lustre brings in (quota.h) show
a problem with caddr_t not being defined if XOPEN_SOURCE is set.  We
provided this define so we could make use of pread/pwrite, but instead
we will use our replacement pread/pwrite if one does not exist.

See #1973
Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

A previous commit [33d82829

] increased the feature level in files
using pread/pwrite functions to strictly adhere to the C99 standard.
The fix inadvertantly caused failed builds when C99 was not enabled
on Solaris. Now we conditionally raise the feature level depending
on the strictness of the build.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

/usr/include/sys/feature_tests.h on Solaris says this about feature
levels and C99:

   It is invalid to compile an XPG3, XPG4, XPG4v2, or XPG5 application
   using c99.  The same is true for POSIX.1-1990, POSIX.2-1992, POSIX.1b,
   and POSIX.1c applications. Likewise, it is invalid to compile an XPG6
   or a POSIX.1-2001 application with anything other than a c99 or later
   compiler.  Therefore, we force an error in both cases.

ROMIO builds would fail with --enable-strict because _XOPEN_SOURCE=500
was defined to expose pread/pwrite. Increasing the feature level to 600
makes usage strictly compatible with C99.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

By setting "indent-tabs-mode:nil" we should hopefully begin to slowly
squeeze out hard tabs from the source without a disruptive (to
downstream projects) whitespace-fixing change.

No reviewer.

driver to match the ROMIO changes over the last copule years.