GitLab

Xin Zhao authored Feb 24, 2015 and Pavan Balaji committed Mar 04, 2015

The implementations of sendNoncontig for intra-node communication in
Nemesis and inter-node communication in network modules (except for
TCP and SCIF) assume that req->dev.segment_first is zero and
req->dev.segment_size is the size of data, which is not always true.
If we stream an RMA operation and issue partial of derived data,
req->dev.segment_first specifies the current starting location of the data
and req->dev.segment_size specifies the current ending location of the data.
Also, the data size should be (req->dev.segment_size - req->dev.segment_first).
This patch corrects this issue in Nemesis and network modules.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

By setting "indent-tabs-mode:nil" we should hopefully begin to slowly
squeeze out hard tabs from the source without a disruptive (to
downstream projects) whitespace-fixing change.

No reviewer.

Without this change we are vulnerable to a nasty bit of compiler
behavior.  MPIDI_CH3_PktGeneric_t sometimes included padding between the
"kind" and "pktptrs" fields.  Then whole-structure assignments using the
generic packet (e.g., ch3_istartmsg.c:96) of buffers that are actually
MPIDI_CH3_Pkt_t unions under the hood will can fail to copy key parts of
the MPIDI_CH3_Pkt_t.

This specifically manifested itself for #1599 by transmitting garbage
"source_win_handle" values in a LOCK_GRANTED packet, which in turn
caused segfaults.

Removing this second type and directly using the actual packet union
eliminates this source of bugs.  The minor downside is that the
mpidpkt.h header becomes more tightly integrated into the rest of the
device.

Reviewed by buntinas@.

[svn-r9301] VC now check for pensing send messages - fix for memory leak with iov - unexpected callback issue fixed

[svn-r4062] 1) Modifying the datatype code to find the number of contig blocks in an instance of an MPI derived datatype - Since finding the real number of contig blocks is not easy we find a reasonable upper bound instead. This also fixes the case where the number of contig blocks was uninitialized for contiguous datatypes. Refer ticket #428 for details (2) Adding a test case, test1_dt.c, to test the fix - Review @ rross, thakur

[svn-r3945] Merging mx netmod branch into trunk.  This adds override functions to the vc for overriding mpid_ send functions, as well as hooks for posting receives.