1. 23 Apr, 2014 13 commits
  2. 22 Apr, 2014 1 commit
  3. 21 Apr, 2014 2 commits
  4. 18 Apr, 2014 1 commit
    • Wesley Bland's avatar
      Makes sure that the status object is always defined · cdd8e0b7
      Wesley Bland authored
      
      
      In the MPIC_Sendrecv functions, the status object should always be defined
      since we use it internally. This won't have any impact on performance since
      the default is always to have FT collectives turned on anyway, but it will
      prevent a crash when someone overwrites that default.
      
      Fixes #2026
      
      Signed-off-by: Sangmin Seo's avatarSangmin Seo <sseo@anl.gov>
      cdd8e0b7
  5. 15 Apr, 2014 3 commits
    • Pavan Balaji's avatar
      Create a dummy function that calls all ROMIO public symbols. · ffcc4904
      Pavan Balaji authored and Kenneth Raffenetti's avatar Kenneth Raffenetti committed
      
      
      All ROMIO public symbols are being added into the libromio convenience
      library, which is LIBADD'ed into libmpi.  The correct behavior would
      be for libtool to add -Wl,--whole-archive to the link line, thus
      forcing all symbols in libromio to end up in libmpi.  However, in some
      cases, this is not working out correctly.  For example, with the
      Absoft compiler, the linker flags were being reordered thus causing
      the -Wl,--whole-archive flag to not correspond to libromio.
      Consequently, only symbols that were used from within the other
      functions of libmpi were being included.
      
      For example, Absoft's linker reordering is below:
      
      ----8<----
      % af77 -v -shared -fPIC src/mpi/attr/.libs/lib_libmpi_la-attrutil.o src/mpi_t/.libs/lib_libmpi_la-pvar_write.o \
        -Wl,--whole-archive src/mpi/romio/.libs/libromio.a -Wl,--no-whole-archive  \
        -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/mpl/.libs \
        -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/openpa/src/.libs \
        -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/install/lib \
        -L/sandbox/balaji/build-absoft/src/mpl -L/sandbox/balaji/build-absoft/src/openpa/src \
        /sandbox/balaji/build-absoft/src/mpl/.libs/libmpl.so /sandbox/balaji/build-absoft/src/openpa/src/.libs/libopa.so \
        -lrt -lpthread  -O0   -Wl,-soname -Wl,libmpi.so.12 -o lib/.libs/libmpi.so.12.0.0
      
      gcc src/mpi/attr/.libs/lib_libmpi_la-attrutil.o src/mpi_t/.libs/lib_libmpi_la-pvar_write.o \
          /sandbox/balaji/build-absoft/src/mpl/.libs/libmpl.so /sandbox/balaji/build-absoft/src/openpa/src/.libs/libopa.so \
          -L/soft/com/packages/absoft11.0/shlib64 -Wl,--whole-archive -Wl,--no-whole-archive \
          -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/mpl/.libs \
          -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/openpa/src/.libs \
          -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/install/lib \
          -L/sandbox/balaji/build-absoft/src/mpl -L/sandbox/balaji/build-absoft/src/openpa/src \
          -Wl,-soname -Wl,libmpi.so.12 -shared -o lib/.libs/libmpi.so.12.0.0 src/mpi/romio/.libs/libromio.a \
          -lrt -lpthread -laf90math -lafio -lamisc -laf77math -lm -lmv
      ----8<----
      
      In the past, we got lucky in two ways:
      
      1. We were including all the Fortran 77 symbols into libmpi.  Since
      the Fortran symbols were calling the C ROMIO symbols, those ROMIO
      symbols were pulled in even without -Wl,--whole-archive.
      
      2. The problem only showed up with absoft and nag, both of which are
      Fortran-only compilers.  If a C compiler has this issue, it should
      have shown up when Fortran support is disabled.
      
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      ffcc4904
    • Pavan Balaji's avatar
      Cleanup the symbol management to go into the right library. · 2957c845
      Pavan Balaji authored and Kenneth Raffenetti's avatar Kenneth Raffenetti committed
      
      
      We were adding both the ROMIO MPI_ and PMPI_ symbols into the
      external_libs variable, which end up in the same library.  This patch
      separates them out.  It also cleans up the variables to which other
      libtool libraries (such as the debug library) are added.
      
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      2957c845
    • Pavan Balaji's avatar
      Add an explicit application dependency on the profiling library. · 5661cf2b
      Pavan Balaji authored and Kenneth Raffenetti's avatar Kenneth Raffenetti committed
      
      
      We were not explicitly linking the application binaries to libpmpi
      earlier.  This works fine when the application uses the MPI_ symbols,
      but not when the application uses the PMPI_ symbols.  On mac, where a
      separate profiling library is built, we were using -flat_namespace to
      supress this issue.  But on other platforms, without this flag, the
      issue showed up when passing --disable-weak-symbols.
      
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      5661cf2b
  6. 14 Apr, 2014 4 commits
  7. 11 Apr, 2014 7 commits
  8. 10 Apr, 2014 3 commits
  9. 07 Apr, 2014 2 commits
  10. 03 Apr, 2014 1 commit
  11. 02 Apr, 2014 3 commits