Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

The user can now enable/disable fortran using the --enable-fortran
option, instead of separate --enable-f77 and --enable-fc.  Expert
users can control specific Fortran standards to use with
--enable-fortran=f77,f90 (and f08 in the future).

Also allow the user to specify only "FC".  If "F77" is not specified,
we use the same compiler as FC.

We now use mpifort as the primary Fortran wrapper, with mpif90 as a
symlink to it for backward compatibility.  If the user specifies a
different F77 compiler than the FC compiler, or if FFLAGS and FCFLAGS
are different, then a separate mpif77 is generated.  Otherwise, mpif77
is a symlink to mpifort.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Also squash bad white space changes in the move and replace f90
references with fc.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

This was added when we were playing with inter-library dependencies.
Since we don't use it anymore, we can remove this code.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

When we are using the embedded version of libmpl/opa, we can merge it
into libmpi or libpmpi.  It doesn't need to be maintained as a
separate library.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Now that we have decided on consistent library names, we don't need to
do any special setting for ABI compatibility.  Just set the
LD_LIBRARY_PATH and run.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Don't provide a default prefix path since that's updated at make
install time anyway, for example, if the user specifies a new prefix.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

These were gratuitous variables that didn't serve any real purpose.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 16, 2014 and Pavan Balaji committed Apr 23, 2014

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

The rerun of buildiface for rebuilding mpicxx.h wasn't use the
appropriate init file that reorders the virtual functions.  Also
remove an empty unused variable.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 22, 2014 and Pavan Balaji committed Apr 23, 2014

The paths used in the extractcvars script were not VPATH build safe
earlier.  Since this is mostly called from autogen.sh, it didn't
matter earlier.  But in cases where the make logic tries to run it
again, it was failing.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Lisandro Dalcin authored Apr 22, 2014 and Rob Latham committed Apr 22, 2014

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

Paul Coffman authored Apr 21, 2014 and Rob Latham committed Apr 21, 2014

a bug with the balancecontig optimization could result in the ions
having non-contiguous file offset ranges. this was hurting overall
performance of the optimization plus the gpfs access range hints.

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

In the MPIC_Sendrecv functions, the status object should always be defined
since we use it internally. This won't have any impact on performance since
the default is always to have FT collectives turned on anyway, but it will
prevent a crash when someone overwrites that default.

Fixes #2026

Signed-off-by: Sangmin Seo <sseo@anl.gov>

Pavan Balaji authored Apr 12, 2014 and Kenneth Raffenetti committed Apr 15, 2014

All ROMIO public symbols are being added into the libromio convenience
library, which is LIBADD'ed into libmpi.  The correct behavior would
be for libtool to add -Wl,--whole-archive to the link line, thus
forcing all symbols in libromio to end up in libmpi.  However, in some
cases, this is not working out correctly.  For example, with the
Absoft compiler, the linker flags were being reordered thus causing
the -Wl,--whole-archive flag to not correspond to libromio.
Consequently, only symbols that were used from within the other
functions of libmpi were being included.

For example, Absoft's linker reordering is below:

----8<----
% af77 -v -shared -fPIC src/mpi/attr/.libs/lib_libmpi_la-attrutil.o src/mpi_t/.libs/lib_libmpi_la-pvar_write.o \
  -Wl,--whole-archive src/mpi/romio/.libs/libromio.a -Wl,--no-whole-archive  \
  -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/mpl/.libs \
  -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/openpa/src/.libs \
  -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/install/lib \
  -L/sandbox/balaji/build-absoft/src/mpl -L/sandbox/balaji/build-absoft/src/openpa/src \
  /sandbox/balaji/build-absoft/src/mpl/.libs/libmpl.so /sandbox/balaji/build-absoft/src/openpa/src/.libs/libopa.so \
  -lrt -lpthread  -O0   -Wl,-soname -Wl,libmpi.so.12 -o lib/.libs/libmpi.so.12.0.0

gcc src/mpi/attr/.libs/lib_libmpi_la-attrutil.o src/mpi_t/.libs/lib_libmpi_la-pvar_write.o \
    /sandbox/balaji/build-absoft/src/mpl/.libs/libmpl.so /sandbox/balaji/build-absoft/src/openpa/src/.libs/libopa.so \
    -L/soft/com/packages/absoft11.0/shlib64 -Wl,--whole-archive -Wl,--no-whole-archive \
    -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/mpl/.libs \
    -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/src/openpa/src/.libs \
    -Wl,-rpath -Wl,/sandbox/balaji/build-absoft/install/lib \
    -L/sandbox/balaji/build-absoft/src/mpl -L/sandbox/balaji/build-absoft/src/openpa/src \
    -Wl,-soname -Wl,libmpi.so.12 -shared -o lib/.libs/libmpi.so.12.0.0 src/mpi/romio/.libs/libromio.a \
    -lrt -lpthread -laf90math -lafio -lamisc -laf77math -lm -lmv
----8<----

In the past, we got lucky in two ways:

1. We were including all the Fortran 77 symbols into libmpi.  Since
the Fortran symbols were calling the C ROMIO symbols, those ROMIO
symbols were pulled in even without -Wl,--whole-archive.

2. The problem only showed up with absoft and nag, both of which are
Fortran-only compilers.  If a C compiler has this issue, it should
have shown up when Fortran support is disabled.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 15, 2014 and Kenneth Raffenetti committed Apr 15, 2014

We were adding both the ROMIO MPI_ and PMPI_ symbols into the
external_libs variable, which end up in the same library.  This patch
separates them out.  It also cleans up the variables to which other
libtool libraries (such as the debug library) are added.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Apr 15, 2014 and Kenneth Raffenetti committed Apr 15, 2014

We were not explicitly linking the application binaries to libpmpi
earlier.  This works fine when the application uses the MPI_ symbols,
but not when the application uses the PMPI_ symbols.  On mac, where a
separate profiling library is built, we were using -flat_namespace to
supress this issue.  But on other platforms, without this flag, the
issue showed up when passing --disable-weak-symbols.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

MPIR_ERRTEST_ARGNULL is incorrect for validating an MPI_Info
handle, since MPI_INFO_NULL is not defined as 0. This updates the
test in MPI_Comm_set_info to match the one in MPI_Win_set_info.

Patch originally from thakur@mcs.anl.gov

if GPFS enabled, we were declaring all file systems GPFS.  This holdover
from the old BlueGene-specific days does not belong here.

Signed-off-by: Paul Coffman <pkcoff@us.ibm.com>

20 years of portability workarounds make for quite a tangle.  Only one
of the four methods is ever used in practice now.  Provide comments
about the older approaches and indicate which one we expect to be the
common case.

Signed-off-by: Paul Coffman <pkcoff@us.ibm.com>

only ad_fstype.c uses GPFS_SUPER_MAGIC now.  Also, GPFS_SUPER_MAGIC is
properly provided by gpfs.h, but we can fall back to old way of
declaring it ourselves if gpfs.h is not around.

Signed-off-by: Paul Coffman <pkcoff@us.ibm.com>

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Fixes compiler warnings in ch3u_rma_ops.c and ch3u_rma_acc_ops.c. Complains
were about "orig_vc" and "target_vc" of potentially being unused. This is a
false positive, as the conditional statements were correct. Warning fixed by just
initializing the pointers to NULL. gcc 4.6.3 complained in stomp, whereas gcc
4.7.4 did not on my laptop.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Those were related to pragma weak alias without previous external definitions.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Fixes complain by icc

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Complained by icc

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

The variable is declared as external in pmip.h, but defined in three
different files. The linker warns that it's actually merging them. If we
want to use an only variable declared as 'extern', it should be only
defined in one place. This commit removes two out of the three
declarations. See #1966.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Fixes the following warning when --enable-fast is enabled:

src/mpi/coll/bcast.c:1012:23: warning: suggest braces around empty body
in an 'if' statement [-Wempty-body]

See #1966.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

This adds the same checks as the previous commit to the fortran tests. For the
most part, the F77 tests are copied over to the F90 tests so little was added
to the F90 directory.

Fixes #1699

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

The test suite assumes that it is running on a system where
MPI_COMM_SPAWN(_MULTIPLE) is possible. This isn't true on all systems and thus
prevents the test suite from being useful everywhere.

This check (contributed by Jeff H. - jhammond@alcf.anl.gov) looks to see if
the MPI_COMM_WORLD attribute MPI_UNIVERSE_SIZE is available and actually
greater than the size of MPI_COMM_WORLD.

If the spawn tests will fail because spawning is not possible on the system
(whether because the universe size is too small or spawning is not supported),
the tests will return success (unless there was some error in the detection
process).

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Signed-off-by: Wesley Bland <wbland@anl.gov>

Add a test to check for correct behavior of MPI_Accumulate operations
with the MPI_MINLOC and MPI_MAXLOC operations.

Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

libmpi depends on libpmpi.  We need to build them in that order to
make sure the dependencies are satisfied.  libtool should do this
automatically, but it does not.  More description of the error is
available here: https://bugzilla.redhat.com/show_bug.cgi?id=91110



Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

if a file system supports scalable resize, we can continue to defer
open.  I had the logic backwards and conduced the deferred open when we
did not need to (and did not when we did).  Thanks, Paul Coffman.

Signed-off-by: Paul Coffman <pkcoff@us.ibm.com>

Paul Coffman authored Apr 01, 2014 and Rob Latham committed Apr 02, 2014

in the final sort on the bridgelist,  was starting an index at -1
instead of 0, resulting in typically bizzare (occaional) memory errors.

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

No need for this Makefile.mk to add BGL_OPTIM flags to CFLAGS: nothing
in the code uses them.

Signed-off-by: Paul Coffman <pkcoff@us.ibm.com>

The default optimization flags (-O2) are set for C and F77, but not for
C++ and Fortran 90.

In commit [b4ce3c99

], the behaviour of PAC_C_CHECK_COMPILER_OPTION and
PAC_F77_CHECK_COMPILER_OPTION were changed in configure.ac, while
PAC_CXX_CHECK_COMPILER_OPTION and PAC_FC_CHECK_COMPILER_OPTION
remained the same.

Fixes #2033

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>