Commits · 4b516e886aa3aa51379e0c3806c911c9333c2cc3 · Rob Latham / MPICH-BlueGene

29 Oct, 2013 13 commits

Pavan Balaji authored Sep 22, 2013



Based on an Intel contributed patch.  The idea is to use the bits from
the cancelled field to extend the count, rather than increasing the
count datatype itself.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Fixes to the bit manipulation based on feedback from Artem Yalozo @
Intel.

Fixes to the naming convention based on feedback from Bill Gropp.

Signed-off-by: William Gropp <wgropp@illinois.edu>

4b516e88

Revert "Fix for #1804 - Alignment issues in Fortran with MPI_Status" · a214d500
Pavan Balaji authored Oct 19, 2013
```
This reverts commit 81ad170b

.

Signed-off-by: William Gropp <wgropp@illinois.edu>
```
a214d500

Force ordering of functions in C++ binding · fc20de53

William Gropp authored Oct 23, 2013 and

Pavan Balaji committed Oct 29, 2013

This selects the buildiface option that specifies a specific ordering
of the routines in mpicxx.h(.in) in order to provide ABI consistency.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

fc20de53

Eliminate test for C++ Distgraphcomm routines · db07b81b

William Gropp authored Oct 23, 2013 and

Pavan Balaji committed Oct 29, 2013



For MPICH builds, eliminate the C++ distgraphcomm test.  In other cases
test for presense of MPI::Distgraphcomm and only include the test if
available.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

db07b81b

Remove support for MPI::Distgraphcomm · 09884411

William Gropp authored Oct 23, 2013 and

Pavan Balaji committed Oct 29, 2013



Enhanced cxx/buildiface to output support for Distgraphcomm only if
requested through the feature interface.  Distgraphcomm was added
only in MPI 2.2 and for historical reasons is not part of the
MPICH ABI.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

09884411

Detect unknown feature request · 5f8c172b

William Gropp authored Oct 21, 2013 and

Pavan Balaji committed Oct 29, 2013



Improve buildiface for C++ to detect an unknown feature request with
the -feature= option and abort.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

5f8c172b

Add option to remove distgraph support in C++ · 756f1cd6

William Gropp authored Oct 21, 2013 and

Pavan Balaji committed Oct 29, 2013

In support of the standard ABI, this change allows us to provide the
Distgraphcomm support defined in MPI 2.2, as well as support the ABI,
which only supports MPI 2.1. This change is not complete in itself;
another commit is needed to select the ABI level in configure.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

756f1cd6

Change buildiface for C++ to control output order · da9e5e5a

William Gropp authored Oct 08, 2013 and

Pavan Balaji committed Oct 29, 2013

Add a way to output the order of function output in mpicxx.h.in file
and a way to read in a file specifying the order. This is used to
meet ABI needs. Also fixed some old MPI_xxx vs MPI::xxx cases, and
the almost duplicated Create_struct call. All in a single commit
because the test was against the proposed ABI mpicxx.h.in file

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

da9e5e5a

Use the standard #ifndef/#include in mpitimpl.h · 88580cc2
Junchao Zhang authored Oct 29, 2013 and Pavan Balaji committed Oct 29, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
88580cc2

Include mpitimpl.h in mpich_cvars.h · db4b0786

Junchao Zhang authored Oct 28, 2013 and

Pavan Balaji committed Oct 29, 2013



Since in mpich_cvars.h, we used a type MPIR_T_cvar_range_value_t,
which is defined in mpitimpl.h.

Fix #1953

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

db4b0786

Use the new MPI_T cvar name prefix MPIR_CVAR_ · d29a600e
Junchao Zhang authored Oct 28, 2013 and Pavan Balaji committed Oct 29, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
d29a600e

Swap the priority between MPICH_* and MPIR_PARAM_* · 4b06870d

Junchao Zhang authored Oct 28, 2013



The new init. priority order of MPICH cvars is
MPICH_* < MPIR_PARAM_* < MPIR_CVAR_*

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

4b06870d

Fix a problem in passing thread id to a function · 7288ffe0

Junchao Zhang authored Oct 29, 2013 and

Kenneth Raffenetti committed Oct 29, 2013



The old code used (void*)(intptr_t)i to pass the thread id i.
However intptr_t is C99, so I changed it to (void*)(long)i.

Direct usage of (void*)i will issue a compilation warning
saying it is dangerous to convert integer to pointer.

Fixes #1956

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

7288ffe0

27 Oct, 2013 3 commits
- Correct output format in the new impls/ test. · 4bb837e8
  Pavan Balaji authored Oct 27, 2013
```
Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
```
  4bb837e8
- Update version string. · 17878cdf
  Pavan Balaji authored Oct 27, 2013
```
We are calling the next release 3.1rc1.  The ABI string has already
been updated.

No reviewer.
```
  17878cdf
- Added information about MPI_T to the documentation. · 1aaea604
  Pavan Balaji authored Oct 27, 2013
```
No reviewer.
```
  1aaea604
26 Oct, 2013 21 commits
- Bug fix for the mpit_vars test. · e53c0f3a
  Pavan Balaji authored Oct 26, 2013
```
Some content was being printed even when not in verbose mode causing
the test to incorrectly fail.

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>
```
  e53c0f3a
- Rename mpich_params.{c,h} to mpich_cvars.{c,h} · e858a6cb
  Junchao Zhang authored Oct 25, 2013 and Pavan Balaji committed Oct 26, 2013
```
Also change src/util/param/params.yml to src/util/cvar/cvars.yml,
maint/genparams to maint/gencvars

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  e858a6cb
- Rename parameters MPIR_PARAM_* to MPIR_CVAR_* · e072e5ca
  Junchao Zhang authored Oct 25, 2013 and Pavan Balaji committed Oct 26, 2013
```
To adapt to naming for control variables in MPI_T.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  e072e5ca
- Add a test case to test multithreading MPI_T · fb570792
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
The case is adapted from test/mpi/mpi_t/mpit_vars.c

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  fb570792
- Delete xfail=ticket1898 of mpi_t_str · de70f872
  Junchao Zhang authored Oct 17, 2013 and Pavan Balaji committed Oct 26, 2013
```
This bug was fixed with the new MPI_T implementation.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  de70f872
- Revise two tests under test/mpi/manual/mpi_t/ · 9fcd5712
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  9fcd5712
- Revise the test case mpit_vars.c · d5ca1acd
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
Now we can control printing using env var MPITEST_VERBOSE.
The old code used a local variable 'verbose'. It shades the global
variable 'verbose'. So we renamed the local one to 'verb' instead.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  d5ca1acd
- Rename mpit_init_thread.c to mpit_initthread.c · 83f6c94a
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
Since initthread.c is used for MPI_Init_thread(), we'd better use
mpit_initthread.c for MPI_T_init_thread().

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  83f6c94a
- Rename cat_get_pv.c to cat_get_pvars.c · 601ac99d
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
The old name doesn't confrom to naming convention of other files under mpi_t

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  601ac99d
- Rename mpich_param_vals.h, param_vals.c · fc51e3ad
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
These two files are renamed to mpich_params.{c, h} since the old
ones are not uniform.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  fc51e3ad
- Revise genparams to gen files needed by new MPI_T · 255d0fb7
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  255d0fb7
- Add missing info of parameters (cvars) · 127ee1d2
  Junchao Zhang authored Oct 24, 2013 and Pavan Balaji committed Oct 26, 2013
```
This makes parameters (cvars) conform to MPI_T standard.
However, probably the info is too conservative.
Need further tuning the info.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  127ee1d2
- Capitalize parameter category names · 4c5f24c8
  Junchao Zhang authored Oct 24, 2013 and Pavan Balaji committed Oct 26, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  4c5f24c8
- Adapt old ch3 pvars to new MPI_T impl · e39e4d2e
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  e39e4d2e
- Adapt old nemesis pvars to new MPI_T impl · 068ac9cd
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  068ac9cd
- Change wording for option --enable-mpit-pvars · b351a97e
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  b351a97e
- Change var names in enable_pvar_* style · 15357039
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  15357039
- Delete the old interfaces on pvars · bfca1382
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
New code should use interfaces provided by new MPI_T impl.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  bfca1382
- In MPI init/finalize, use updated MPI_T routines · 21d84da9
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  21d84da9
- Replace mpi_t_util.c with mpit.c · 72bf15fb
  Junchao Zhang authored Oct 18, 2013 and Pavan Balaji committed Oct 26, 2013
```
mpit.c also includes non-util routines

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  72bf15fb
- Primary implementation of MPI_T specified in MPI3 · 39e5fa15
  Junchao Zhang authored Sep 03, 2013 and Pavan Balaji committed Oct 26, 2013
```
Implemented the framework for MPI_T enums, categories, performance variables.
and control variables specified in MPI3. Fix #1898, #1930.

The code should make MPICH MPI_T compliant, though not all MPICH pvars/cvars
are currently exposed through MPI_T.

The code supports multithreading up to MPI_THREAD_MULTIPLE.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  39e5fa15
24 Oct, 2013 3 commits

another big type test · 7ff6a970

Rob Latham authored Oct 24, 2013

Jeff Hammond's test to send/recieve a message described by a large datatype.

7ff6a970

Fix for uncommitted datatypes · 10073a33

Lisandro Dalcin authored Oct 23, 2013 and

Kenneth Raffenetti committed Oct 24, 2013



MPI_Type_get_extent_x and MPI_Type_get_true_extent_x were throwing
errors when passed an uncommitted user-defined datatype. This was
incorrect. Closes #1774

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

10073a33

Allow MPI_ERR_IO as error class in test · a5d05b36

William Gropp authored Oct 24, 2013 and

Rob Latham committed Oct 24, 2013



The test was too prescriptive about the allowed error classes.
ERR_NO_SUCH_FILE is a better choice, but ERR_IO is valid.

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

a5d05b36