GitLab

The MPI collectives get and set the errflag used by the collective
helper functions (MPIC_*). The possible values of the errflag changed,
so the collective functions need to appropriately set this value using
either MPIR_ERR_NONE (MPI_SUCCESS), MPIR_ERR_PROC_FAILED
(MPIX_ERR_PROC_FAILED), or MPIR_ERR_OTHER (MPI_ERR_OTHER).

This should allow collectives to correctly report process failures when
they occur now, fixing the FT tests that use collectives (see #1945).
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

The errflag value being used in the MPIC helper functions only
propagated whether or not an error occurred. It did not contain any
information about what kind of error occurred, which made returning the
correct error code after a process failure impossible.

This patch converts the binary value to an enum with three options:
MPIR_ERR_NONE
MPIR_ERR_PROC_FAILED
MPIR_ERR_OTHER

The original use of TRUE and false maps to MPIR_ERR_NONE and
MPIR_ERR_OTHER.

MPIR_ERR_PROC_FAILED indicates that the error occurred
because of a process failure. It uses the new bit set aside from the tag
space to track such information between processes.

This change required modifying lots of function signatures and type
declarations to use the new enum type, but these are actually not very
intrusive changes and shouldn't be a problem going forward.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

We need to take another bit from the tag space to specify the difference
between a generic failure and a process failure. This patch modifies the
macros to handle this situation.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Back in the 3.1 series, we made the FT versions of all of the MPIC functions
default. However, we never changed the names of all of the states. This
removes the extra state names.

No reviewer.

The previous commit only adjusted the tag checking proceedure for MPIC_Recv,
but it should be the same for MPIC_Sendrecv and MPIC_Sendrecv_replace.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Tags were sometimes being tested when the communication call had already
failed, leading to bad asserts later due to uninitialized values. Sometimes,
these results would have ended up with an error anyway, but sometimes not.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

This CVAR was deprecated in MPICH 3.1 and will now be removed for MPICH 3.2.
Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

In the MPIC_Sendrecv functions, the status object should always be defined
since we use it internally. This won't have any impact on performance since
the default is always to have FT collectives turned on anyway, but it will
prevent a crash when someone overwrites that default.

Fixes #2026
Signed-off-by: Sangmin Seo <sseo@anl.gov>

Junchao Zhang authored Nov 11, 2013 and Pavan Balaji committed Dec 19, 2013

Fixes #1963
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Rob Latham authored Oct 18, 2013 and Pavan Balaji committed Oct 31, 2013

MPI_Pack, MPI_Unpack, and MPI_Pack_size use integers to describe counts
of bytes and posistions in a bytestream.  In a world of 2 GiB+
datatypes, this is not correct.  It will take an army to change the
standard, but we can at least do the right thing internally.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Junchao Zhang authored Oct 25, 2013 and Pavan Balaji committed Oct 26, 2013

To adapt to naming for control variables in MPI_T.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Some builtin kinds (e.g., MPI_DOUBLE_INT), can have extra padding when
a vector of them is copied.  So we need to use the extent for such
types, not just the size.  In this commit, we just simplify the
optimization to only work on BUILTIN types, which do not have this
issue.
Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

In this case, we don't need to find the lower-bound.  It's a simple
copy.
Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

No reviewer necessary.

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.Rename MPIC_Send_ft to MPIC_Send
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.Rename MPIC_Send_ft to MPIC_Send
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jul 01, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 28, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 28, 2013 and Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 28, 2013 and Pavan Balaji committed Jul 25, 2013

Merge the two functions into one function and remove the non-ft version.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 28, 2013 and Pavan Balaji committed Jul 25, 2013

Merge the two functions into one function and remove the non-ft version.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 27, 2013 and Pavan Balaji committed Jul 25, 2013

Merge the two functions into one function and remove the non-ft version.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 27, 2013 and Pavan Balaji committed Jul 25, 2013

Merge the two functions into one function and remove the non-ft version.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 27, 2013 and Pavan Balaji committed Jul 25, 2013

Merge the two functions into one function and remove the non-ft version.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 27, 2013 and Pavan Balaji committed Jul 25, 2013

Merge the two functions into one function and remove the non-ft version.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 27, 2013 and Pavan Balaji committed Jul 25, 2013

Merge the two function into one function and remove the non-ft version.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 26, 2013 and Pavan Balaji committed Jul 25, 2013

All usages of the non-ft versions have moved over to use the ft versions
to avoid the need to maintain both and to ensure that we provide some
ability to provide ft everywhere. There are times where this isn't
necessary or useful and in those cases, the value of *errflag can be
ignored and just the return value can be checked to see if the function
was successful or not.

The MPIC_* functions that have an ft mirror
(e.g. MPIC_Send -> MPIC_Send_ft) are no longer accessible outside of
helper_fns.c. Now the MPIC_*_ft functions should be called directly.
Note that this is not going to be a long lived policy. Instead, the
MPIC_*_ft functions will be merged with the standard MPIC_* functions
and will replace them.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Wesley Bland authored Jun 21, 2013 and Pavan Balaji committed Jul 25, 2013

All of the *_ft functions now set/check for the error bit in the tag
instead of using a completely separate tag to send error notifications.
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

These were not spotted earlier because our `--enable-strict`
functionality was broken, especially under clang.

Reviewed-by: balaji

Otherwise they could be used uninitialized in the `MPIU_ERR_` macros.
Followup to [3fdf0887].

No reviewer.

Created by squashing two mpich-ibm.git commits together (533f660f and
acb6d143).  Original subject was:

"pami coredump at _lapi_shm_amsend"

merged IBM breadcrumbs:
(ibm) D180594
(ibm) fe8f99116561f407c0e5e39e2f7b3354537e9279
(ibm) 88f19b240b90983f8c6f99b273df996839dfecf4
(ibm) 170b04ee98ad1706da2723d7cbf538711945f402

No reviewer.

When no less than 4 tasks in the same group call MPI_Scatter with
recvcount less than sendcount, non-root tasks will pass a negative count
to MPIC_Send_ft, which won't always be caught by the device.  This adds
a bit of extra error checking to help catch this case.

Based on a patch written by Qi QC Zhang <keirazhang@cn.ibm.com>,
augmented by Dave Goodell <goodell@mcs.anl.gov>.

By setting "indent-tabs-mode:nil" we should hopefully begin to slowly
squeeze out hard tabs from the source without a disruptive (to
downstream projects) whitespace-fixing change.

No reviewer.

disabled for the public interfaces, but all internal functions use
const.

No reviewer.