1. 12 Nov, 2014 3 commits
    • Wesley Bland's avatar
      Correctly handle errflag in MPI collectives · 47f62b0c
      Wesley Bland authored
      
      
      The MPI collectives get and set the errflag used by the collective
      helper functions (MPIC_*). The possible values of the errflag changed,
      so the collective functions need to appropriately set this value using
      either MPIR_ERR_NONE (MPI_SUCCESS), MPIR_ERR_PROC_FAILED
      (MPIX_ERR_PROC_FAILED), or MPIR_ERR_OTHER (MPI_ERR_OTHER).
      
      This should allow collectives to correctly report process failures when
      they occur now, fixing the FT tests that use collectives (see #1945).
      Signed-off-by: default avatarHuiwei Lu <huiweilu@mcs.anl.gov>
      47f62b0c
    • Wesley Bland's avatar
      Change errflag to be an enum · 3850e6bf
      Wesley Bland authored
      
      
      The errflag value being used in the MPIC helper functions only
      propagated whether or not an error occurred. It did not contain any
      information about what kind of error occurred, which made returning the
      correct error code after a process failure impossible.
      
      This patch converts the binary value to an enum with three options:
      MPIR_ERR_NONE
      MPIR_ERR_PROC_FAILED
      MPIR_ERR_OTHER
      
      The original use of TRUE and false maps to MPIR_ERR_NONE and
      MPIR_ERR_OTHER.
      
      MPIR_ERR_PROC_FAILED indicates that the error occurred
      because of a process failure. It uses the new bit set aside from the tag
      space to track such information between processes.
      
      This change required modifying lots of function signatures and type
      declarations to use the new enum type, but these are actually not very
      intrusive changes and shouldn't be a problem going forward.
      Signed-off-by: default avatarHuiwei Lu <huiweilu@mcs.anl.gov>
      3850e6bf
    • Wesley Bland's avatar
      Take a bit in the tag space for proc failure · 46f59276
      Wesley Bland authored
      
      
      We need to take another bit from the tag space to specify the difference
      between a generic failure and a process failure. This patch modifies the
      macros to handle this situation.
      Signed-off-by: default avatarHuiwei Lu <huiweilu@mcs.anl.gov>
      46f59276
  2. 23 Oct, 2014 2 commits
    • Wesley Bland's avatar
      Fix typo in 72513b14 · 4b20f2d2
      Wesley Bland authored
      4b20f2d2
    • Wesley Bland's avatar
      Remove _FT from state names · 72513b14
      Wesley Bland authored
      Back in the 3.1 series, we made the FT versions of all of the MPIC functions
      default. However, we never changed the names of all of the states. This
      removes the extra state names.
      
      No reviewer.
      72513b14
  3. 21 Oct, 2014 1 commit
  4. 20 Oct, 2014 1 commit
  5. 14 Oct, 2014 1 commit
  6. 31 Jul, 2014 1 commit
  7. 18 Apr, 2014 1 commit
    • Wesley Bland's avatar
      Makes sure that the status object is always defined · cdd8e0b7
      Wesley Bland authored
      
      
      In the MPIC_Sendrecv functions, the status object should always be defined
      since we use it internally. This won't have any impact on performance since
      the default is always to have FT collectives turned on anyway, but it will
      prevent a crash when someone overwrites that default.
      
      Fixes #2026
      Signed-off-by: Sangmin Seo's avatarSangmin Seo <sseo@anl.gov>
      cdd8e0b7
  8. 19 Dec, 2013 1 commit
  9. 31 Oct, 2013 1 commit
  10. 26 Oct, 2013 1 commit
  11. 28 Sep, 2013 1 commit
  12. 26 Sep, 2013 1 commit
  13. 29 Jul, 2013 1 commit
  14. 25 Jul, 2013 17 commits
  15. 22 Apr, 2013 1 commit
  16. 12 Apr, 2013 2 commits
    • Dave Goodell's avatar
      initialize mpi_errno in `MPIC_` routines · 973957e7
      Dave Goodell authored
      Otherwise they could be used uninitialized in the `MPIU_ERR_` macros.
      Followup to [3fdf0887].
      
      No reviewer.
      973957e7
    • Qi QC Zhang's avatar
      fix uninitialized `mpi_errno` · 3fdf0887
      Qi QC Zhang authored
      Created by squashing two mpich-ibm.git commits together (533f660f and
      acb6d143).  Original subject was:
      
      "pami coredump at _lapi_shm_amsend"
      
      merged IBM breadcrumbs:
      (ibm) D180594
      (ibm) fe8f99116561f407c0e5e39e2f7b3354537e9279
      (ibm) 88f19b240b90983f8c6f99b273df996839dfecf4
      (ibm) 170b04ee98ad1706da2723d7cbf538711945f402
      
      No reviewer.
      3fdf0887
  17. 15 Jan, 2013 1 commit
    • Qi QC Zhang's avatar
      ensure non-negative counts in MPIC_ funcs · 927d7864
      Qi QC Zhang authored
      When no less than 4 tasks in the same group call MPI_Scatter with
      recvcount less than sendcount, non-root tasks will pass a negative count
      to MPIC_Send_ft, which won't always be caught by the device.  This adds
      a bit of extra error checking to help catch this case.
      
      Based on a patch written by Qi QC Zhang <keirazhang@cn.ibm.com>,
      augmented by Dave Goodell <goodell@mcs.anl.gov>.
      927d7864
  18. 10 Oct, 2012 1 commit
  19. 03 Jul, 2012 1 commit
  20. 24 Apr, 2012 1 commit