Commits · 447c1d5585135a41fd6341dcb9760ba945261f11 · Rob Latham / MPICH-BlueGene

28 Jul, 2013 9 commits

Delete decrementing ref count in SHM RMA operations, but add conditions in... · 447c1d55

Xin Zhao authored Jul 26, 2013 and

Pavan Balaji committed Jul 28, 2013

Delete decrementing ref count in SHM RMA operations, but add conditions in operaiton issue routines.

In RMA operation issue routines, judge if shm_allocate == 1 and target vc
is local, if so, do not add reference count on datatypes, because they will not
be referenced by the progress engine, but will be completed directly by origin.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

447c1d55

In SHM RMA operations, add condition for "alloc_shm". · 34dd7c1a

Xin Zhao authored Jul 26, 2013 and

Pavan Balaji committed Jul 28, 2013



If shared memory is allocated for window, and target vc is local,
do SHM RMA operations.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

34dd7c1a

Call DO_SHM_RMA_OP in fence/unlock/complete. · 55cb0f4c

Xin Zhao authored Jul 26, 2013 and

Pavan Balaji committed Jul 28, 2013



decrement datatype reference counts in SHM RMA operations.
because they will not be referenced by the progress engine, but be
completed directly by origin.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

55cb0f4c

add "alloc_shm" info to MPIDI_Win_get_info. · b668bc1e
Xin Zhao authored Jul 22, 2013 and Pavan Balaji committed Jul 28, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
b668bc1e

Add "alloc_shm" info to MPI_Win_allocate. · 384d96b7

Xin Zhao authored Jul 22, 2013 and

Pavan Balaji committed Jul 28, 2013



Add "alloc_shm" to window's info arguments and initialize it to FALSE.
In MPID_Win_allocate, if "alloc_shm" is set to true, call ALLOCATE_SHARED,
otherwise call ALLOCATE.

Free window memory only when SHM region is not allocated, therwise it is
already freed in MPIDI_CH3I_SHM_Win_free.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

384d96b7

Refactoring the code of SHM RMA operations from operation routines to inline functions. · 44d9c98d

Xin Zhao authored Jul 22, 2013 and

Pavan Balaji committed Jul 28, 2013

The code in inline functions is moved from operation routines in
ch3u_rma_ops.c and ch3u_rma_acc_ops.c. By moving them in inline
functions, both operation routines and synchronization routines can call them.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

44d9c98d

modify SHM_Win_allocate_shared and SHM_Win_free to accomodate global comm. · 382bdfb2

Xin Zhao authored Jul 22, 2013 and

Pavan Balaji committed Jul 28, 2013

MPIDI_CH3I_Win_allocate_shared can be called by both MPI_Win_allocate_shared
and MPI_Win_allocate. If it is called by MPI_Win_allocate, we need node_comm,
node_sizes and node_shm_base_addrs to allocate shm segment region, hence we need
to copy from win_ptr->sizes to node_sizes at beginning and copy from node_shm_base_addrs
to win_ptr->shm_base_addrs at last. If it is called by MPI_Win_allocate_shared,
these copies can be eliminated.

If there is only one process on this node, node_comm is NULL, we use comm_self instead.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

382bdfb2

Waiting for passive RMA operations to finish in MPIDI_CH3_SHM_Win_free. · e3971480

Xin Zhao authored Jul 26, 2013 and

Pavan Balaji committed Jul 28, 2013



This is for the optimization of allocating shared memory region in
MPI_Win_allocate. In this case MPIDI_CH3_SHM_Win_free must first wait
for passive RMA operations to finish before free the shared memory region.

Note that because MPIDI_CH3_SHM_Win_free calls MPIDI_Win_free at last,
and MPIDI_Win_free will also call inline function of waiting for passive
RMA operation to finish, in this case the inline function will be called
twice.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

e3971480

Refactoring code of waiting passive RMA operations. · 5c6b971a

Xin Zhao authored Jul 26, 2013 and

Pavan Balaji committed Jul 28, 2013



Moving code of waiting finish of passive RMA operations from MPIDI_Win_free
to an inline function in mpidrma.h.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

5c6b971a

26 Jul, 2013 6 commits
- Mention the Intel SCIF contribution in the CHANGES file. · d698823c
  Pavan Balaji authored Jul 26, 2013
  
  d698823c
- Amended write_ckpoint test. · 55b86f37
  Kenneth Raffenetti authored Jul 26, 2013
```
Added checking to see if ckpoint context files exist
and are non-empty.
```
  55b86f37
- Patch libtool.m4 after every autoreconf and fix timestamp. · fab816f0
  Antonio J. Pena authored Jul 24, 2013 and Pavan Balaji committed Jul 26, 2013
```
Fixes ticket #1870.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  fab816f0
- Adds framework for testing checkpointing. · a7ea4b9b
  Kenneth Raffenetti authored Jul 23, 2013
```
Checkpointing tests only run if --enable-checkpointing is
configured. First test is to see if mpiexec can successfully
checkpoint a job using blcr.

Signed-off-by: Wesley Bland <wbland@mcs.anl.gov>
```
  a7ea4b9b
- White-space cleanup to Intel-contributed patches. · d9226405
  Pavan Balaji authored Jul 26, 2013
  
  d9226405
- Added Intel-contributed patches for SCIF. · bb3456d9
  Pavan Balaji authored Jul 26, 2013
  
  bb3456d9
25 Jul, 2013 24 commits

Deprecate ENABLE_COLL_FT_RET · 0ff12df5

Wesley Bland authored Jul 25, 2013 and

Pavan Balaji committed Jul 25, 2013



This environment variable is no longer necessary now that FT and NBC will play
well together. We'll keep this one around for one more version, then delete it
in MPICH-3.2.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

0ff12df5

Update CHANGES with FT/NBC work. · 7d747526
Wesley Bland authored Jul 23, 2013 and Pavan Balaji committed Jul 25, 2013
```
Add a description for the FT and NBC work to the CHANGES file.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
7d747526

Rename MPIC_Waitall_ft to MPIC_Waitall · ede63de4

Wesley Bland authored Jul 01, 2013 and

Pavan Balaji committed Jul 25, 2013



The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

ede63de4

Rename MPIC_Irecv_ft to MPIC_Irecv · 2e9ad71a

Wesley Bland authored Jul 01, 2013 and

Pavan Balaji committed Jul 25, 2013



The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

2e9ad71a

Rename MPIC_Isend_ft to MPIC_Isend · d3a85756

Wesley Bland authored Jul 01, 2013 and

Pavan Balaji committed Jul 25, 2013



The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

d3a85756

Rename MPIC_Sendrecv_replace_ft to MPIC_Sendrecv_replace · 4e783c9d

Wesley Bland authored Jul 01, 2013 and

Pavan Balaji committed Jul 25, 2013

The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.Rename MPIC_Send_ft to MPIC_Send

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

4e783c9d

Rename MPIC_Sendrecv_ft to MPIC_Sendrecv · e98feb06

Wesley Bland authored Jul 01, 2013 and

Pavan Balaji committed Jul 25, 2013

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

e98feb06

Rename MPIC_Ssend_ft to MPIC_Ssend · ddeb54a4

Wesley Bland authored Jul 01, 2013 and

Pavan Balaji committed Jul 25, 2013



The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

ddeb54a4

Rename MPIC_Send_ft to MPIC_Send · 3e3adf97

Wesley Bland authored Jun 28, 2013 and

Pavan Balaji committed Jul 25, 2013



The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

3e3adf97

Rename MPIC_Recv_ft to MPIC_Recv · b8e7cbd1

Wesley Bland authored Jun 28, 2013 and

Pavan Balaji committed Jul 25, 2013



The FT functions are now the default (only) way to call the collective
helper functions. This is one of a few patches to migrate all uses to no
longer use the MPIC_*_ft naming scheme.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

b8e7cbd1

Combine MPIC_Isend and MPIC_Isend_ft · 2204a718

Wesley Bland authored Jun 28, 2013 and

Pavan Balaji committed Jul 25, 2013



Merge the two functions into one function and remove the non-ft version.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

2204a718

Combine MPIC_Irecv and MPIC_Irecv_ft · b7cfbe35

Wesley Bland authored Jun 28, 2013 and

Pavan Balaji committed Jul 25, 2013



Merge the two functions into one function and remove the non-ft version.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

b7cfbe35

Combine MPIC_Sendrecv_replace and MPIC_Sendrecv_replace_ft · 3eec02b3
Wesley Bland authored Jun 27, 2013 and Pavan Balaji committed Jul 25, 2013
```
Merge the two functions into one function and remove the non-ft version.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
3eec02b3

Combine MPI_Sendrecv and MPI_Sendrecv_ft. · 0747e46f

Wesley Bland authored Jun 27, 2013 and

Pavan Balaji committed Jul 25, 2013



Merge the two functions into one function and remove the non-ft version.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

0747e46f

Combine MPIC_Ssend and MPIC_Ssend_ft. · 25e5cde0

Wesley Bland authored Jun 27, 2013 and

Pavan Balaji committed Jul 25, 2013



Merge the two functions into one function and remove the non-ft version.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

25e5cde0

Combine MPIC_Recv and MPIC_Recv_ft. · af63831e

Wesley Bland authored Jun 27, 2013 and

Pavan Balaji committed Jul 25, 2013



Merge the two functions into one function and remove the non-ft version.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

af63831e

Combine MPIC_Send and MPIC_Send_ft. Remove MPIC_Send. · 3083d8e7
Wesley Bland authored Jun 27, 2013 and Pavan Balaji committed Jul 25, 2013
```
Merge the two function into one function and remove the non-ft version.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
3083d8e7

Move MPIC_* usage over to MPIC_*_ft functions. · 34d594d4

Wesley Bland authored Jun 26, 2013 and

Pavan Balaji committed Jul 25, 2013



All usages of the non-ft versions have moved over to use the ft versions
to avoid the need to maintain both and to ensure that we provide some
ability to provide ft everywhere. There are times where this isn't
necessary or useful and in those cases, the value of *errflag can be
ignored and just the return value can be checked to see if the function
was successful or not.

The MPIC_* functions that have an ft mirror
(e.g. MPIC_Send -> MPIC_Send_ft) are no longer accessible outside of
helper_fns.c. Now the MPIC_*_ft functions should be called directly.
Note that this is not going to be a long lived policy. Instead, the
MPIC_*_ft functions will be merged with the standard MPIC_* functions
and will replace them.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

34d594d4

No longer need MPIR_ERROR_TAG. · 9a048941

Wesley Bland authored Jun 24, 2013 and

Pavan Balaji committed Jul 25, 2013



The functionality has been replaced by reserving a bit from the tag
space to accomplish the same thing without messing up tag matching.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

9a048941

Make ENABLE_COLL_FT_RET default now that it doesn't break NBC. · e46124ee
Wesley Bland authored Jun 24, 2013 and Pavan Balaji committed Jul 25, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
e46124ee

Modify collective functions to propagate error bit. · 432391e0

Wesley Bland authored Jun 21, 2013 and

Pavan Balaji committed Jul 25, 2013

All of the *_ft functions now set/check for the error bit in the tag
instead of using a completely separate tag to send error notifications.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

432391e0

Mask away the error bit in tag space when matching. · fc2433ed

Wesley Bland authored Jun 14, 2013 and

Pavan Balaji committed Jul 25, 2013



When appropriate, the error bit should not be part of the tag space when
matching. This isn't always necessary. For pt2pt messages, the error bit will
never be set so the masking isn't necessary. This change has minimal measured
effect on matching times.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

fc2433ed

Add macros to manipulate error bits in tag space. · 5838c8df

Wesley Bland authored Jun 06, 2013 and

Pavan Balaji committed Jul 25, 2013



These macros are used to manipulate the error bit that has been added
to the tag space to propagate error notification on top of other
communication.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

5838c8df

Block off the highest bit of tag space. · 230060cd

Wesley Bland authored May 31, 2013 and

Pavan Balaji committed Jul 25, 2013



The highest bit of tag space will now be reserved for failure
notification. We are far above the required 32767, so this shouldn't be
a problem.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

230060cd

24 Jul, 2013 1 commit
- fix bug: return info=false in MPIDI_Win_get_info if that info is not set by user. · 05fd0e1b
  Xin Zhao authored Jul 24, 2013 and Pavan Balaji committed Jul 24, 2013
```
Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>
```
  05fd0e1b