1. 15 Feb, 2013 1 commit
  2. 08 Feb, 2013 1 commit
  3. 07 Feb, 2013 2 commits
  4. 06 Feb, 2013 8 commits
    • Dave Goodell's avatar
      clmake: use `\W` instead of `\b` · 5ffbf154
      Dave Goodell authored
      Patterns that end in non-word chars (such as `:`) will not match a `\b`
      atom when followed by a non-word like ` ` or `\n`.
      
      No reviewer.
      5ffbf154
    • Dave Goodell's avatar
      ROMIO: fix buffer/datatype mismatch in Isend/Irecv · eed00728
      Dave Goodell authored
      Caught by the cool new type checking annotations in our `mpi.h` header
      that work with modern clang versions.
      
      No reviewer.
      eed00728
    • Dave Goodell's avatar
      hydra: squash loop warning from modern clang · 748c0ae2
      Dave Goodell authored
      `-Wempty-body` will cause this, and is enabled by default in modern
      clang when configuring MPICH with `--enable-strict`.
      
      No reviewer.
      748c0ae2
    • Dave Goodell's avatar
      fix Fortran MPI_WEIGHTS_EMPTY initialization · e12f4293
      Dave Goodell authored
      We were not communicating the MPI_WEIGHTS_EMPTY common block value to C
      via the `mpirinitc_` routine.  Also fix a minor warning about the C struct
      static initializer when `HAVE_C_MULTI_ATTR_ALIAS` is defined, as it
      usually is on Linux.
      
      The existing `dgraph_unwgtf` test does not catch this case.  AFAICS,
      there is no black-box way to test this behavior using only the MPI
      interface provided that the MPI library correctly implements
      `MPI_UNWEIGHTED` handling, since the MPI implementation is forbidden to
      inspect the pointer value other than to check whether it is
      `MPI_UNWEIGHTED`.  The best idea I've come up with so far is to create a
      sanity check routine that we can call from Fortran that ensures all
      Fortran-C interoperability constants are correctly recognized, but even
      that's a pretty weak test, since it must also be updated whenever a new
      Fortran common block is added.  This will have to do for now...
      
      Follow-up to [d6ceef97].
      
      Reviewed-by: dinan
      e12f4293
    • Dave Goodell's avatar
      clmake: more patterns and a regex fix · 9aa1c31b
      Dave Goodell authored
      Handle the case where GNU coreutils are installed in some odd `bin`
      directory, such as `gnubin`.
      
      Also fix a bad regex pattern (`[^\w]` means match a single character
      that is not `\` and is not `w`, rather than the opposite of `\w`, which
      is `\W`) by using the `\b` "boundary" atom.
      
      No reviewer.
      9aa1c31b
    • James Dinan's avatar
      PERF: Overlap req/wait for lock-all on shr men win · 3593b5c0
      James Dinan authored
      Send out all lock requests before waiting for lock acquisition.  This
      should improve the performance of lock-all operations on shared memory
      windows.
      
      Reviewer: goodell
      3593b5c0
    • James Dinan's avatar
      PERF: Flush should ignore inactive targets · 460cf5ca
      James Dinan authored
      This fix enables flush to ignore non-local targets that have not been targeted
      by an RMA operation.  Prior to this fix, a call to flush-all would result in
      acquiring the lock at all targets, which is extremely inefficient.
      
      Reviewer: goodell
      460cf5ca
    • James Dinan's avatar
      Eliminate enqueueing of lock op in RMA ops list · fbd95593
      James Dinan authored
      Prior to this patch, a lock entry was enqueued in the RMA ops list when
      Win_lock was called.  This patch adds a new state tracking mechanism, which we
      use to record the synchronization state with respect to each RMA target.  This
      new mechanism absorbs tracking of lock operation and the lock state at the
      target.  It significantly simplifies the RMA synchronization and ops list
      processing.
      
      Reviewer: goodell
      fbd95593
  5. 05 Feb, 2013 3 commits
    • Dave Goodell's avatar
      explain external32 limitations in RELEASE_NOTES · 2bdb181f
      Dave Goodell authored
      references ticket #1754.
      
      No reviewer.
      2bdb181f
    • Dave Goodell's avatar
      tt#1754: fix warnings in ROMIO external32 code · d8eec549
      Dave Goodell authored
      This doesn't fix any of the serious bugs or inefficiencies present in
      the current external32 implementation.  But it at least fixes some very
      valid warnings related to const-ness and passing incorrect pointer
      types.
      
      References ticket #1754
      
      Reviewed-by: robl
      d8eec549
    • James Dinan's avatar
      BUGFIX: Unlock piggybacking for Get_accumulate · 0b364068
      James Dinan authored
      GACC operations were both piggybacking the unlock message to the origin, and
      sending back a PT done packet.  This was causing the origin to be unlocked
      twice.  When another lock operation was performed between the GACC and PT done
      unlock operations, there was a synchronization race.
      0b364068
  6. 04 Feb, 2013 2 commits
    • Rob Latham's avatar
      feature-encode NTFS quirk · f71dd6e4
      Rob Latham authored
      NTFS does not have the POSIX "file exists until everyone closes it"
      property, so introduce the feature mechanism to NTFS and let ADIO know
      NTFS cannot rely on that property.
      f71dd6e4
    • James Dinan's avatar
      Fix type incompat. for size_t in BSend degug msgs · 34249593
      James Dinan authored
      This patch updates BSend debugging messages to be compatible with new size_t
      arguments added in [7fa7e2cf].  Format strings are updated and size_t args are
      cast to unsigned long long.  Upconverting to the largest unsinged integer type
      is the only safe way to deal with this in pre-C99.  If we were coding to C99,
      we could have avoided the type cast and used '%z' directly in the format
      strings.  This closes ticket #1786.
      
      Reviewer: goodell
      34249593
  7. 31 Jan, 2013 1 commit
  8. 30 Jan, 2013 3 commits
  9. 29 Jan, 2013 2 commits
  10. 28 Jan, 2013 2 commits
  11. 25 Jan, 2013 13 commits
    • Dave Goodell's avatar
      Merge branch 'nemesis-mpit' · d3e1b754
      Dave Goodell authored
      Adds Ralf's changes to nemesis that add MPI_T performance variables.  I left
      his commits mostly alone and added several cleanup commits on top of them.
      d3e1b754
    • Dave Goodell's avatar
      always define stat vars · 412672db
      Dave Goodell authored
      This makes the stats code more robust to persnickety compilers that
      might not appreciate references to extern variables that don't really
      exist.
      
      Reviewed-by: rgunter
      412672db
    • Dave Goodell's avatar
      fixups for new MPI_T tests · 44d08f8a
      Dave Goodell authored
      Add the copyright header, limit printing to rank 0, and print a
      "finished" message to make it clearer that the test completed and didn't
      just crash.
      
      Reviewed-by: rgunter
      44d08f8a
    • Dave Goodell's avatar
      move new MPI_T tests to manual/mpi_t dir · e56307ab
      Dave Goodell authored
      Reviewed-by: rgunter
      e56307ab
    • Dave Goodell's avatar
      fixup for new pvar build system code · 7f528a33
      Dave Goodell authored
      Reviewed-by: rgunter
      7f528a33
    • Ralf Gunter's avatar
      Add configure args to selectively enable MPIT pvars. · a4d103b7
      Ralf Gunter authored
      Users can now pass --enable-mpit-pvars to configure to statically
      enable/disable MPIT performance variables so as to limit performance
      impacts only to those variables they need.
      
      Current valid arguments are as follows:
          none     - No performance info recorded
          recvq    - All message queue-related variables
          nem      - All nemesis-related variables
          all      - All variables above
      
      A macro framework is added to facilitate the addition of new variables
      (see MPIR_T_GATE on mpid_common_statistics.h).
      
      Also add a check to the MPIT nemesis test to ensure that the variables
      being tested have been registered with the runtime.
      a4d103b7
    • Ralf Gunter's avatar
      Add MPIT variables and corresponding tests. · 46eacfc7
      Ralf Gunter authored
      The following MPIT performance variables are added:
      
       - nem_fbox_fall_back_to_queue_count;
       - time_failed_matching_postedq;
       - time_matching_unexpectedq;
       - unexpected_recvq_buffer_size.
      
      Some common MPIT-related routines, handle creation functions and
      enable/disable switches are gathered in a common file.
      
      Two test cases are furnished, but not yet integrated with 'make check'.
      46eacfc7
    • Ralf Gunter's avatar
    • Dave Goodell's avatar
      move MPI_T tests to their own subdir in "manual" · d6b69b46
      Dave Goodell authored
      Reviewed-by: rgunter
      d6b69b46
    • Dave Goodell's avatar
      add `xfail=ticketXYZ` annotations to failing tests · 6a954d01
      Dave Goodell authored
      These five tests are currently failing on a regular basis with MPICH.
      All need to be dealt with at some point, but we cannot fix them right
      now and they make it hard to spot new failures in the tests.
      
      references #1767, #1788
      
      Reviewed-by: dinan
      6a954d01
    • Dave Goodell's avatar
      TAP: add "xfail" support · 4aba817f
      Dave Goodell authored
      This is used to indicate tests that are correct, but functionality that
      is expected to fail in the current version of the MPI implementation.
      This is expressed in `testlist` files with an argument string like
      `xfail=ticketXYZ` or `xfail=REASON` after the program name.
      Unfortunately, spaces, quotes, and `#` characters are not permitted in
      the format at this time, due to the primitive nature of the testfile
      parser code.
      
      If strict MPI testing is requested (by configuring the test suite with
      `--enable-strictmpi`) then the `xfail=BLAH` arguments are ignored under
      the assumption that they are only accurate for the current version of
      the MPICH implementation.
      
      No xfail support has been added to the XML output at this time.
      
      Reviewed-by: dinan
      4aba817f
    • Dave Goodell's avatar
      runtests: permit arbitrary capitalization in args · b187ee20
      Dave Goodell authored
      At Jim's request...
      
      Reviewed-by: dinan
      b187ee20
    • Dave Goodell's avatar
      TAP: add "# SKIP" directive support · 237d91bf
      Dave Goodell authored
      This way tests that were skipped because of strictness or version
      constraints will show up in the summary.tap output file.
      
      Reviewed-by: dinan
      237d91bf
  12. 24 Jan, 2013 2 commits