GitLab

Code review cleanups that couldn't be merged into earlier patches because of
later changes.

Reviewer: goodell

Temporarily reduced the communication volume in manyrma2.  For right now, it's
valuable to get correctness testing from this test.  We are still tracking the
performance issue under #1669 and will tackle that for the next release.

Reviewer: goodell

Reviewer: goodell

Updated get_accumulate implementation to properly handle NO_OP operations;
currently, we dispatch these as get operations.  As a part of this change, the
op issue code was also gathered into a macro to reduce copy-paste across all
of the synchronization functions.

Reviewer: goodell

Removed scattered initializations of the RMA op dataloop field that are
redundant, since the dataloop field is now initialized when the op is
allocated.

Reviewer: goodell

Fetch-and-op has been updated to ignore the origin data and perform no
operation when the given op is MPI_NO_OP.

Reviewer: goodell

Updated op error checking routines to check for correct usage of MPI_Op
argument in accumulate and reduce operations.  Also updated a handful of other
error checks in accumulate ops, and corrected some to ensure that origin
arguments are ignored in the GACC/FOP NO_OP case.

Reviewer: goodell

Reviewer: balaji

Reviewer: buntinas

Reviewer: buntinas

Reviewer: goodell

Removed calls to higher-level MPIU_RMA_CALL() macro.  This macro dispatches
either from the RMAFns table or directly to the MPID_ function; since CH3
always uses the RMAFns table, this macro shouldn't be used inside of CH3.

Reviewer: balaji

If flush is used as a part of polling for incoming data, we can deadlock, since
local RMA calls never poke the progress engine.  Extra progress was added to
local flushes to better fake passive progress.

Reviewer: balaji

Reviewer: buntinas

Updated RMA implementation to track the passive target status individually, for
each target.  Includes new implementation for lock/unlock_all.  Lock_all is
currently unoptimized, see #1734 for future plans.

Reviewer: buntinas

Remove ugly rank 0 hack and updated the active target code to maintain and
process a proper RMA ops list.

Reviewer: goodell

The use of a dense array is a temporary measure to support the reference
implementation.  This will be much improved by ticket #1735.

Reviewer: goodell

A couple of the RMA synchronization error checks were returning the wrong error
class.

reviewer: buntinas

The old "lockRank" error checking is no longer sufficient in MPI 3.0 and must
be removed to add support for locking multiple targets.

Reviewer: balaji

Removed the use of lockRank in the passive target RMA code.  This was a hack to
start with, since lockRank belonged to the the front-end error checking and
should not have been used below the ADI.

Reviewer: buntinas

This is a temporary measure for the reference implementation that should be
improved by ticket #1733.

Reviewer: buntinas

In this patch, I have refactored the RMA ops list again to use the MPL UTList
doubly-linked list and to treat the list as a proper object.  This should set
us up to work with multiple lists, as we will soon have one list per target.
Doubly-linking the list is a big help in terms of maintainability (no more
prevNext pointers) and flexibility (better implementation of request-based
ops and other optimizations).

Reviewer: goodell

[svn-r10506] More corrections for new mpi.h.in plus added missing special cases for old form where int* used instead of int[], in collective routines

Request refs at the target were incorrectly set to two.  Only one ref is held,
by the progress engine.

Reviewer: none

Reviewed by buntinas.

tickets 125 and 126.

Reviewed by buntinas.

Reviewed by buntinas.

[svn-r10495] More changes to adapt to limitations of early Fortran 90/95 compilers, for the new required (why?) MPI_Status derived type

[svn-r10493] Update C++ binding generation to correct handling of const and updates for MPI-3 prototype changes, including const and array notation

Reviewer: buntinas

Factored MPI_Set_info into separate external and internal interfaces, so we can
use it from within MPI_Win/Comm_set_info.

Reviewer: buntinas