1. 22 May, 2014 1 commit
    • Wesley Bland's avatar
      Make handling of request cleanup more uniform · 1e171ff6
      Wesley Bland authored
      
      
      There are quite a few places where the request cleanup is done via:
      
      MPIU_Object_set_ref(req, 0);
      MPIDI_CH3_Request_destroy(req);
      
      when it should be:
      
      MPID_Request_release(req);
      
      This makes the handling more uniform so requests are cleaned up by releasing
      references rather than hitting them with the destroy hammer.
      
      Fixes #1664
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      1e171ff6
  2. 01 Apr, 2014 1 commit
    • Pavan Balaji's avatar
      Move symbols to correct libraries. · 9c337914
      Pavan Balaji authored and Kenneth Raffenetti's avatar Kenneth Raffenetti committed
      
      
      Maintain a list of files that go into each library.  If a particular
      binding is not enabled, the list variable still exists, but will just
      be empty.  This simplifies the management of which files/symbols go
      into which library.
      
      Move all MPI_ symbols to the libmpi library and all other symbols to
      the libpmpi library.  All Fortran 77 symbols go into libmpif77.so,
      while C symbols go into libmpi.so.  There are some exceptions, such as
      status_f2c, which are handled by the Fortran code but used in C.  Our
      Fortran 90 build only creates a few symbols and uses the f77 symbols
      for everything else.  These few symbols go into libmpifort.so.
      
      Also update compiler wrappers to link to correct libraries.  mpif77
      should now link with libmpif77.  mpif90 links with both libmpifort and
      libmpif77, since our F90 build still keeps the core Fortran library
      symbols in libf77.
      
      We completely ignored the F77 library earlier.  This was OK because
      all of the Fortran symbols were ending up in libmpi.  Now that we have
      separated out the symbols to the right library, we now need to link to
      libmpif77 as well.
      
      Also added inter-library dependencies.
      
      libmpi has a dependency on several internal libraries: libmpl, libopa.
      libmpicxx did not have a dependency on libmpi, added.
      libmpif77 did not have a dependency on libmpi, added.
      libmpifort did not have a dependency on libmpi, added.
      
      This dependency model is sufficient for C and F77, but not for C++ and
      F90.  The C and F77 libraries contain all the symbols the application
      relies on, but the F90 and C++ libraries don't.  In the case of F90,
      symbols such as mpi_bcast are missing and are borrowed from the F77
      library.  In the case of C++, mpicxx.h contains calls directly to C
      functions (such as MPI_Reduce_local), which get embedded into the
      application.
      
      Fixes #2023.
      Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
      9c337914
  3. 26 Feb, 2014 1 commit
  4. 10 Feb, 2014 1 commit
  5. 09 Feb, 2014 1 commit
  6. 01 Feb, 2014 1 commit
  7. 19 Jan, 2014 2 commits
  8. 30 Dec, 2013 2 commits
    • Antonio J. Pena's avatar
      Fix compiler warnings about variables for assert · 8ea1dfec
      Antonio J. Pena authored
      
      
      Mark those variables exclusively being used for assertions as potentially
      unused to avoid compiler warnings when the assertion macro does nothing. These
      show up with --enable-fast.
      Signed-off-by: Pavan Balaji's avatarPavan Balaji <balaji@mcs.anl.gov>
      8ea1dfec
    • Antonio J. Pena's avatar
      Fix compiler warning in socksm.c · 2225f092
      Antonio J. Pena authored
      
      
      Fixes the following warnings when compiling socksm.c with --enable-strict:
      
      src/mpid/ch3/channels/nemesis/netmod/tcp/socksm.c: In function
      'alloc_sc_plfd_tbls':
      
      src/mpid/ch3/channels/nemesis/netmod/tcp/socksm.c:183:5: warning: the
      comparison will always evaluate as 'true' for the address of
      'MPID_nem_tcp_g_lstn_sc' will never be NULL [-Waddress]
      
      src/mpid/ch3/channels/nemesis/netmod/tcp/socksm.c:184:5: warning: the
      comparison will always evaluate as 'true' for the address of
      'MPID_nem_tcp_g_lstn_plfd' will never be NULL [-Waddress]
      
      Reported in ticket #1966
      Signed-off-by: Pavan Balaji's avatarPavan Balaji <balaji@mcs.anl.gov>
      2225f092
  9. 19 Dec, 2013 2 commits
  10. 18 Dec, 2013 12 commits
  11. 05 Dec, 2013 1 commit
  12. 03 Dec, 2013 8 commits
  13. 15 Nov, 2013 2 commits
  14. 31 Oct, 2013 2 commits
  15. 29 Oct, 2013 1 commit
  16. 26 Oct, 2013 1 commit
  17. 08 Aug, 2013 1 commit
    • Wesley Bland's avatar
      Fixes #1923 - Incorrect error message. · dc1ed4a2
      Wesley Bland authored
      
      
      The error message in MPID_nem_tcp_bind line 580 was incorrectly reporting the
      port that was being attempted due to incrementing the variable at the end of
      the for loop and not accounting for that in the error message. This patch
      subtracts one if the port was not succesfully bound when printing out the
      value for the error message.
      
      Thanks to Yauheni Zelenko for reporting this error.
      Signed-off-by: default avatarHuiwei Lu <huiweilu@mcs.anl.gov>
      dc1ed4a2