Commits · 1b5334ede0488abc04e981e53ea977780c9e28e6 · Rob Latham / MPICH-BlueGene

15 May, 2013 4 commits

deal with MPI_INFO_NULL reasonably · 1b5334ed
Rob Latham authored May 15, 2013
```
maddeningly we cannot dup MPI_INFO_NULL, so let's check for that case
```
1b5334ed
Remove C99-ism from IBM contributed code. · 49595414
Pavan Balaji authored May 14, 2013
```
Reviewed by Mike Blocksome @ IBM.
```
49595414

Naming updates to IBM's NBC patch. · 57f5b7b1

Pavan Balaji authored May 14, 2013

We now provide two types of function pointers: _sched and _req.  The
_sched functions just add instructions to the schedule, but no request
is created.  The _req functions return an MPID request.

Reviewed by Mike Blocksome @ IBM.

57f5b7b1

Add hooks for optimized MPIX_* non-blocking collectives. · 2eefd3a2

Michael Blocksome authored Nov 01, 2012 and

Pavan Balaji committed May 15, 2013



The following collectives are updated:

  MPIX_Ibcast
  MPIX_Iallgather
  MPIX_Iallgatherv
  MPIX_Iallreduce
  MPIX_Ialltoall
  MPIX_Ialltoallv
  MPIX_Ialltoallw
  MPIX_Iexscan
  MPIX_Igather
  MPIX_Igatherv
  MPIX_Ireduce_scatter_block
  MPIX_Ireduce_scatter
  MPIX_Ireduce
  MPIX_Iscan
  MPIX_Iscatter
  MPIX_Iscatterv

These collectives are updated similar to how the optimized MPIX_Ibarrier
is implemented:

| The previous MPIR_Ibarrier_impl() function forced all adi implementations
| to create a MPID_Sched_t opaque object which was then passed in to the
| specific ibarrier implementation via a function pointer table.
|
| The MPID_Sched_t object represents a completely new state machine that
| must be advanced whenever mpi progress is made.
|
| The required construction of the MPID_Sched_t object and the required
| advance of the schedule state machine would be extremely detrimental to
| pamid performance.

(ibm) 47b497e15cd87df666c6031a28f5f8a5ae53cece
(ibm) aee872eb91f4300066957349e5a3d8103da33f40

Signed-off-by: Charles Archer <archerc@us.ibm.com>

2eefd3a2

14 May, 2013 4 commits

Warning squash. · 635969e7
Pavan Balaji authored May 14, 2013
```
No reviewer.
```
635969e7

Disable -Wcast-align and -Wshorten-64-to-32. · c537d620

Pavan Balaji authored May 14, 2013

This is an important warning flag, but given the number of places we
are breaking this in mpich, it is causing us to miss other warnings.
This is meant to be a temporary disabling.

No reviewer.

c537d620

adio/common wrong checking of lseek return · 74639d55
Haizhu Liu authored May 01, 2013 and Rob Latham committed May 14, 2013
```
(ibm) D190161
(ibm) 55566af07e7d69df17005e50c783ff3ae26cc325

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>
```
74639d55

avoid hang if subset of procs have invalid INFO · 470667cb

Rob Latham authored May 14, 2013

In response to IBM's integration ticket 1822 (but reworked), turn
MPIO_CHECK_INFO into a collective macro; exchange result of info
inspection with all procs.  Now a bogus info on one proc won't cause a
process hang.

470667cb

13 May, 2013 4 commits
- multi_mpi coredump with RDMA on mpich · 49195779
  Su Huang authored Sep 21, 2012 and Pavan Balaji committed May 13, 2013
```
(ibm) D186334
(ibm) 7Z6
(ibm) 63716b02ccab7cd99116e927a210eca43b03d52e

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>
```
  49195779
- Add dropped change from 'code review fixes'. · b9232780
  Michael Blocksome authored May 13, 2013 and Pavan Balaji committed May 13, 2013
```
(ibm) D185675
(ibm) 7693f538360130f4cca71f0975c0bb345d2f6239
```
  b9232780
- MPIDI_TRACE tool enhancement - remaining updates · fbcf94a1
  Michael Blocksome authored May 13, 2013 and Pavan Balaji committed May 13, 2013
```
For some reason these changes from the original commit did not migrate
into the 'mpich/master' branch.

(ibm) D185675
(ibm) 3728f432f99fc499955a2c9d830a5026e5f87948
```
  fbcf94a1
- Fixed assert on int env vars passed in a string · ae6451d5
  Charles Archer authored Oct 04, 2012 and Pavan Balaji committed May 13, 2013
```
Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>
```
  ae6451d5
10 May, 2013 2 commits

Dynamic tasking MPI_Comm_disconnect HANG · 4325f459
Haizhu Liu authored Apr 25, 2013 and Pavan Balaji committed May 10, 2013
```
(ibm) D190081
(ibm) 25939d9ffd5267261f70e714aaec434d84e07093

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>
```
4325f459

MPI_Comm_disconnect hang · 788dca4a

Haizhu Liu authored Apr 22, 2013 and

Pavan Balaji committed May 10, 2013



Also remove MPIR_Comm_group_ext() function declaration and reference.

(ibm) D189966
(ibm) 5681895bcb45798680b249dbf993b9a634954b80

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

788dca4a

09 May, 2013 12 commits
- Make MPIR_Comm_create_group visible to other MPICH utilities. · a8118972
  Pavan Balaji authored May 09, 2013
```
No reviewer.
```
  a8118972
- Fix for tt#1832. · faff4d1d
  Pavan Balaji authored May 09, 2013
```
Typo in mpl's configure which was causing MPL headers to be installed,
which should not be needed.

No reviewer.
```
  faff4d1d
- use void* for sizeof detection instead of int · e9579e1c
  Charles Archer authored Apr 05, 2013 and Pavan Balaji committed May 09, 2013
```
(ibm) D189618
(ibm) f30c0544fcc37fc18cb0f9b27f414373d5d5308b

Signed-off-by: Bob Cernohous <bobc@us.ibm.com>
```
  e9579e1c
- detect 32 bit vs 64 bit via sizeof · 87e84a5e
  Charles Archer authored Apr 04, 2013 and Pavan Balaji committed May 09, 2013
```
(ibm) D189618
(ibm) 73870926a4a9598deacbc5c0b91fa6150ef8f7ed

Signed-off-by: Bob Cernohous <bobc@us.ibm.com>
```
  87e84a5e
- Fix alltoall handling of non-PAMI datatypes and non-continuous datatypes. · 5ef1a628
  Bob Cernohous authored Mar 26, 2013 and Pavan Balaji committed May 09, 2013
```
(ibm) 36f5ac777f738068690184193b557fab53b3472f

Signed-off-by: sssharka <sssharka@us.ibm.com>
```
  5ef1a628
- BGQ must create geometries with (existing) tasklists · c60642cc
  Bob Cernohous authored Mar 06, 2013 and Pavan Balaji committed May 09, 2013
```
(ibm) Issue 7967
(ibm) 6b7ba8eb718d8323c8dd638c27cca6a05baa202b

Signed-off-by: sssharka <sssharka@us.ibm.com>
```
  c60642cc
- Remove ticket #595 circumvention · f29783c2
  Bob Cernohous authored Mar 21, 2013 and Pavan Balaji committed May 09, 2013
```
(ibm) Trac #659
(ibm) 9d36aed8f988859eba1a284292f0a1a6fc75d01d

Signed-off-by: sssharka <sssharka@us.ibm.com>
```
  f29783c2
- Update scatter[v] protocol selection · ef90f1b9
  Bob Cernohous authored Mar 11, 2013 and Pavan Balaji committed May 09, 2013
```
Do not tie scatterv to scatter selection.

(ibm) Issue 9416
(ibm) 4901e679071e489e38ee1a6925da36eab9c3ffac

Signed-off-by: sssharka <sssharka@us.ibm.com>
```
  ef90f1b9
- Fix M2M protocol selection · 1daeae31
  Bob Cernohous authored Mar 11, 2013 and Pavan Balaji committed May 09, 2013
```
(ibm) Issue 9416
(ibm) 723fb4ce39b5e06ef63cc37231acdaeb6d1c08cf

Signed-off-by: sssharka <sssharka@us.ibm.com>
```
  1daeae31
- Need to read some environment variables before creating the client · a45954b5
  Bob Cernohous authored Mar 11, 2013 and Pavan Balaji committed May 09, 2013
```
(ibm) 26edfa903df4881e1ab0190bc1859f5dc30e868e

Signed-off-by: sssharka <sssharka@us.ibm.com>
```
  a45954b5
- Use MPIDO and not MPIR internally in PAMID · dcf62e91
  Bob Cernohous authored Mar 07, 2013 and Pavan Balaji committed May 09, 2013
```
(ibm) 88338876fc003a9fe936298097b42df1e54ead32

Signed-off-by: sssharka <sssharka@us.ibm.com>
```
  dcf62e91
- Specify PAMID_COLLECTIVES_MEMORY_OPTIMIZED levels · 77999d6f
  Bob Cernohous authored Mar 18, 2013 and Pavan Balaji committed May 09, 2013
```
(ibm) CPS 95PHUZ
(ibm) 1b4e2da6d5fb0990d530be6f896f539dc7571620

Signed-off-by: sssharka <sssharka@us.ibm.com>
```
  77999d6f
08 May, 2013 4 commits

Flag push/pop cleanup. · c478a4fe

Pavan Balaji authored May 02, 2013

PAC_VAR_PUSHFLAG and PAC_VAR_POPFLAG are duplicates of PAC_PUSH_FLAG
and PAC_POP_FLAG.  Also, unlike the PAC_VAR_ macro variants, the flag
is not updated by the PAC_PUSH/PAC_POP macros, so the older value is
retained.

Also cleaned up macros that do additional logic to replace empty
action-if-true/action-if-false statements with ":".  This is not
required.  The macros work fine without this replacement.

Reviewed by gropp.

c478a4fe

Get rid of PAC_EVAL_IFELSE which is a duplicate of PAC_COMMAND_IFELSE. · 50887ce1
Pavan Balaji authored May 02, 2013
```
Reviewed by gropp.
```
50887ce1

PAS_VAR_COPY cleanup. · 5d6aefa5

Pavan Balaji authored May 02, 2013

We no longer need PAS_VAR_COPY since AS_VAR_COPY is present in newer
autoconf versions.

Reviewed by gropp.

5d6aefa5

Fix seg fault in _mpi_world_exiting_handler, fix hang at MPI_Finalize,... · 5c4f5de7

Haizhu Liu authored Mar 22, 2013 and

Pavan Balaji committed May 08, 2013


Fix seg fault in _mpi_world_exiting_handler, fix hang at MPI_Finalize, removing calling PAMI_Context_advance in dispatch.

(ibm) D189340
(ibm) 7c57f7ed7a8aa1f0156ba5112664a7c2cd35f227

Signed-off-by: Bob Cernohous <bobc@us.ibm.com>

5c4f5de7

07 May, 2013 10 commits

Remove unnecessary myrank field in MPID_Win · 07de139f

James Dinan authored May 07, 2013

Myrank was caching win_ptr->comm_ptr->rank, so we now use that directly
rather than caching it in the MPID_Win object.

Reviewer: balaji

07de139f

Move CH3-specific MPID_Win members into CH3 · bd899327

James Dinan authored May 07, 2013

Several fields of MPID_Win were not used above the ADI.  These have been
moved to CH3 to reduce clutter.  Downstream devices should redefine
these fields in MPID_DEV_WIN_DECL if they are needed.

Reviewer: balaji

bd899327

Cleanup RMA comment in MPIDI_Reqest · 4450a0a2
James Dinan authored May 07, 2013

4450a0a2
Add casts to suppress false warnings about alignment issues. · 058286b1
William Gropp authored May 07, 2013

058286b1

Fixes for parsing command line parameters in CollSel · bbb5a3c4

sssharka authored Mar 29, 2013 and

Pavan Balaji committed May 07, 2013



(ibm) D189463
(ibm) e7be2d5b3ae75a32383c32eb203d864d1bbbc386

Signed-off-by: Bob Cernohous <bobc@us.ibm.com>
Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

bbb5a3c4

shmcc_gather_t2 coredump w/ setMP_COLLECTIVE_SELECTION_FILE · e50a1dd3

sssharka authored Mar 20, 2013 and

Pavan Balaji committed May 07, 2013



(ibm) D189345
(ibm) 7Z8
(ibm) 9e1fffe10532d58f09acdbbd81ee582b370bf804

Signed-off-by: Bob Cernohous <bobc@us.ibm.com>
Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

e50a1dd3

pami_tune core w/ -collective_selection=tune · dd85044b
Michael Blocksome authored May 06, 2013 and Pavan Balaji committed May 07, 2013
```
(ibm) D189342
(ibm) 7Z8
(ibm) c2e13cd5979dbba4019cb95c01688a629b7b0f9e

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>
```
dd85044b

shmcc_gather_t2 hang w/o MP_COLLECTIVE_SELECTION_FILE set · 313640c6

sssharka authored Feb 27, 2013 and

Pavan Balaji committed May 07, 2013



This commit includes a fix for all rooted collectives where type info is local.
The fix makes sure that non-contig data is converted and packed on all tasks
and then calling PAMI.

Another change in this commit is related to performance. MPICH2 queries the
collsel extension for best algorithm before attempting any conversions. If
algorithm is mpich, then it is called directly instead of going through the
collsel extension path in PAMI.

(ibm) D187892
(ibm) 7Z8
(ibm) dad6ba8f7883508cd7f83433232b8dadb6ccddcb

Signed-off-by: Bob Cernohous <bobc@us.ibm.com>
Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

313640c6

External algorithm registration for collective selection · f4f0de65
sssharka authored Jan 25, 2013 and Pavan Balaji committed May 07, 2013
```
(ibm) F183421
(ibm) 6463405fd65ec7a45b137334c7608d30f8c29055

Signed-off-by: Bob Cernohous <bobc@us.ibm.com>
```
f4f0de65
Initial drafts of MPID_Win_set/get_info in pamid. · 5673b82c
Pavan Balaji authored May 06, 2013
```
No reviewer.

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>
```
5673b82c