Disabling runtime check for thread-safety is not a correct option.
This would cause memory allocation and string manipulation routines to
be unusable before the thread-safety level is set.  Fixes #1900.

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

This patch has two related parts.

1. We initialize the isThreaded runtime check to FALSE before doing
the cvar checks.  This is because the cvar initialization uses memory
allocation and string duping, which internally use mutexes.  But the
mutexes are not initialized yet, so disabling isThreaded would make
sure we don't use them.

2. Updates to the pamid device to respect the isThreaded variable.

This is needed since we were initializing cvars before setting the
thread-level, so the thread-safety macros are not initialized at that
point.  See #1900.

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

This test still needs to be corrected, but for now it will be xfail. It is
being tracked with ticket #1996.

No reviewer

Wesley Bland authored Jan 09, 2014 and Pavan Balaji committed Jan 09, 2014

This test needs to be debugged, but it can wait for v3.1.1 since this is an
experimental failure.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Sameer Kumar authored Jan 07, 2014 and Pavan Balaji committed Jan 08, 2014

Full fix

Fix for get accumulate that sends contig ack back and then scatters result buffer on the src node.

Remove unused params.

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Su Huang authored Jan 06, 2014 and Pavan Balaji committed Jan 08, 2014

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Su Huang authored Jan 06, 2014 and Pavan Balaji committed Jan 08, 2014

Also clean up warnings.

  src/mpid/pamid/src/dyntask/mpidi_port.c:53: warning: useless storage class
  specifier in empty declaration

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Su Huang authored Dec 31, 2013 and Pavan Balaji committed Jan 08, 2014

The segfault occurred while trying to free an already freed request
handle in MPIDI_Win_DoneCB. To fix the problem, the second MPIU_Free(req)
is removed from the routine.

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Su Huang authored Oct 30, 2013 and Pavan Balaji committed Jan 08, 2014

PAMID: fixes for RMA shared related, lock_all and unlock_all functions

The following has been updated:
- MPID_Win_allocated_shared
- MPID_Win_shared_query
- several functions in mpid_win_lock_all.c, mpid_win_lock.c, mpid_win_free.c and
  structures in mpidi_onesided.h, mpidi_datatypes.h have been modified for
  scalability support for MPID_Win_lock_all() and MPID_Win_unlock_all()

PAMID: fix MPID_Win_allocate_shared, MPID_Win_lock_all/unlock_all and MPID_Win_shared_query

Add changes based on code review feedback from the team:
1) update getPageSize to ensure that the pagesize is obtained from the range of
   passed in address.
2) don't call dispatcher if lockQ[index].done == 1
   if (!lockQ[index].done)
     MPID_PROGRESS_WAIT_WHILE(lockQ[index].done == 0);
3) in mpid_win_shared_query()
   replace
     MPID_assert(win->create_flavor == MPI_WIN_FLAVOR_SHARED);
   by
     MPIU_ERR_CHKANDSTMT((win->create_flavor != MPI_WIN_FLAVOR_SHARED), mpi_errno,
                         MPI_ERR_RMA_FLAVOR, return mpi_errno, "**rmaflavor");
3) some minor fixes.

PAMID: modify MPI_Win_flush_local, MPI_Win_lock etc for better performance

The current implementation for the subject mentioned function is to allocate
two counters for each rank in the window group. The design could cause a scaling
issue.  The fix is to update MPI_Win_flush_local etc with two counters per
window approach.

The changes also include the follwoing:
- provides mutex_lock/mutex_unlock for atomic operations in shared window
- fixes some bugs in handling shared window.
- removes the shared segment with IPC_RMID in MPI_Win_free.

PAMID: fixed base address for each rank in a window group

For shared window, the base address for each rank should not be
exchanged among ranks in a window group. Without the fix, the job
will be terminated with segfault.

(ibm) F189033
(ibm) D194640

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Su Huang authored Oct 16, 2013 and Pavan Balaji committed Jan 08, 2014

added MPID_Win_allocate_shared and MPID_Win_shared_query support and
fixes on passing incorrect rank to MPIDI_WinCtrlSend in MPIDI_WinPost_post
and MPIDI_WinComplete_post

minor fixes for 'win allocate shared'

- compiles for bgq
- UNRESOLVED: undefined shm key on bgq, or any other time the required
  environment variables are not set
- UNRESOLVED: multiple calls to 'win allocate shared' will use the same
  shm key

(ibm) F189033

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Renamed WIN_SEPARATE to WIN_UNIFIED.  pamid's WIN_SYNC already does a
full memory barrier, so we should be all set for UNIFIED support.

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

the code in glue_romio replicates a bit of pointer-size assertion logic.
it's only used by ROMIO, though.  if mpitypedefs.h is not included (see
recent standalone-romio cleanups) we will get an undefined symbol at
link time (MPI_AINT_CAST_TO_VOID_PTR).  Use equivalent
ADIOI_AINT_CAST_TO_VOID_PTR instead for this ROMIO-related code.

Signed-off-by: Jed Brown <jedbrown@mcs.anl.gov>

The current implementation of SMP-awareness in MPI_Barrier was in
MPIR_Barrier_impl.  This makes the default implementation of barrier
SMP-aware.  However, if a device overrides barrier and then calls back
the default implementation through MPIR_Barrier, it can no longer take
advantage of SMP-awareness.  This patch moves the SMP-aware
implementation to MPIR_Barrier_intra, which is called by
MPIR_Barrier_impl through MPIR_Barrier, in the default implementation.
See #1957.

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Use MPIR_Bcast as an inline function, and let the compiler do its job,
instead of duplicating the code.

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

If the user directly provided the host list or if the user provided a
modifier to the list of hosts we obtained from the resource manager
(e.g., changed the number of processes per node, or sorted them), we
consider the host list as user-provided.  Fixes #1575.

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

This reverts commit 3146e104.

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

In romio-standalone fixes, I zapped the inclusion of mpitypedefs.h, but
the "ensure this large value fits into pointer without overflowing"
check relied on some MPICH-internal macros/routines.  Only Blue Gene
driver uses those routines, so nightly tests didn't flag it.

No reviewer.

Pavan Balaji authored Jan 03, 2014 and Kenneth Raffenetti committed Jan 03, 2014

This tests for the functionality of MPI_Dims_create when the number of
processes is very large (1 billion in this case).

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Pavan Balaji authored Jan 02, 2014 and Kenneth Raffenetti committed Jan 02, 2014

Fixes #1992.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

We were setting the default eager threshold inside nemesis, instead of
in ch3.  This was causing other ch3 channels, notably sock, to get a
garbage default value for the eager threshold.

Signed-off-by: Wesley Bland <wbland@mcs.anl.gov>

For non rank-0 processes, store the stdin socket in a dummy variable
instead of passing NULL.  Passing NULL will cause the create_process
function to close the STDIN socket, allowing the process to reuse that
socket.  However, if an application reopens stdin, it causes an
incorrect socket (which is not STDIN) to be closed.  This is
technically a user application bug, but this is a safe-guard to
workaround that.  Fixes #1622.

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Type checking for MPI_2INT is commented out because Clang 3.3 flags
struct {int i1; int i2;} as different from int[2]. But actually these
two types are of the same layout. Clang gives a type mismatch warning
for a definitely correct code like the following:
 int in[2], out[2];
 MPI_Reduce(in, out, 1, MPI_2INT, MPI_MAXLOC, 0, MPI_COMM_WORLD);

So, we disable type checking for MPI_2INT until Clang fixes this bug.

Fixes #1993

Signed off by Rajeev Thakur <thakur@mcs.anl.gov>

Haizhu Liu authored Dec 19, 2013 and Pavan Balaji committed Dec 31, 2013

(ibm) F189037

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Junchao Zhang authored Dec 29, 2013 and Pavan Balaji committed Dec 31, 2013

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Junchao Zhang authored Dec 29, 2013 and Pavan Balaji committed Dec 31, 2013

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Junchao Zhang authored Dec 29, 2013 and Pavan Balaji committed Dec 31, 2013

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Haizhu Liu authored Oct 27, 2013 and Pavan Balaji committed Dec 31, 2013

- add check epoch
- changes after intergrating Sameer's get_accumulate
- update to remove dependency on mpid data structure

(ibm) F189038

Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Minor modifications by Pavan to minimize the changes in
mpir_request.c, and to reduce duplication.  Collective requests and
RMA requests are handled the same way.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

A couple of unused variables when assert does nothing were causing compiler
warnings. Fixed by declaring them as potentially unused.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Mark those variables exclusively being used for assertions as potentially
unused to avoid compiler warnings when the assertion macro does nothing. These
show up with --enable-fast.

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

These only show up with --enable-fast

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Fixes the following warnings:

"src/binding/cxx/initcxx.cxx", line 444: warning: missing return statement at
end of non-void function "MPI::MPIR_Comm_delete_attr_cxx_proxy"

"src/binding/cxx/initcxx.cxx", line 496: warning: missing return statement at
end of non-void function "MPI::MPIR_Comm_copy_attr_cxx_proxy"

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Fixes the following warnings:

"src/binding/cxx/initcxx.cxx", line 721: warning: variable "err" was set but
never used

"src/binding/cxx/initcxx.cxx", line 745: warning: variable "err" was set but
never used

"src/binding/cxx/initcxx.cxx", line 770: warning: variable "err" was set but
never used

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Fixes the following warnings when compiling socksm.c with --enable-strict:

src/mpid/ch3/channels/nemesis/netmod/tcp/socksm.c: In function
'alloc_sc_plfd_tbls':

src/mpid/ch3/channels/nemesis/netmod/tcp/socksm.c:183:5: warning: the
comparison will always evaluate as 'true' for the address of
'MPID_nem_tcp_g_lstn_sc' will never be NULL [-Waddress]

src/mpid/ch3/channels/nemesis/netmod/tcp/socksm.c:184:5: warning: the
comparison will always evaluate as 'true' for the address of
'MPID_nem_tcp_g_lstn_plfd' will never be NULL [-Waddress]

Reported in ticket #1966

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>

Fixes the following warnings (with --enable-strict):

src/mpid/ch3/src/ch3u_rma_acc_ops.c: In function 'MPIDI_Get_accumulate':
src/mpid/ch3/src/ch3u_rma_acc_ops.c:31:5: warning: unused variable
'mpiu_chklmem_stk_sz_' [-Wunused-variable]

src/mpid/ch3/src/ch3u_rma_ops.c: In function 'MPIDI_Accumulate':
src/mpid/ch3/src/ch3u_rma_ops.c:350:5: warning: unused variable
'mpiu_chklmem_stk_sz_' [-Wunused-variable]

See ticket #1966

Signed-off-by: Pavan Balaji <balaji@mcs.anl.gov>