GitLab

The defaults used by MXM might not be fully appropriate for mpich.  So
we automatically initialize it to our preferred defaults unless the
user is trying to override it.
Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

This reverts commit 4ce4103a.

Devendar Bureddy authored Oct 25, 2014 and Pavan Balaji committed Oct 25, 2014

Do not block in mxm for blocking sends. Instead , set req pointer let
MPICH mpi layer to block on it. This will allow progress go to through
MPIDI_CH3I_Progress(), which can release the global mutex in thread
multiple case.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

"native", "internal", and "external32" are the only valid values for
datarep, but if a user passes null
(http://stackoverflow.com/questions/26548398/segmentation-fault-while-using-mpi-file-read-at/

)
then strcmp will segfault.
Signed-off-by: Wesley Bland <wbland@anl.gov>

The defaults used by MXM might not be fully appropriate for mpich.  So
we automatically initialize it to our preferred defaults unless the
user is trying to override it.
Signed-off-by: Xin Zhao <xinzhao3@illinois.edu>

Set the unpexected message header limit to 2 million and allocate
512MB of buffer space.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Unmark sendalive, isendalive, multi_isendalive, recvdead, irecvdead, gather

Back in the 3.1 series, we made the FT versions of all of the MPIC functions
default. However, we never changed the names of all of the states. This
removes the extra state names.

No reviewer.

Igor Ivanov authored Oct 20, 2014 and Pavan Balaji committed Oct 23, 2014

Signed-off-by: Devendar Bureddy <devendar@mellanox.com>
Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>

These tests pass even with debugging output on.

See #1945

No reviewer.

Pavan Balaji authored Oct 21, 2014 and Kenneth Raffenetti committed Oct 22, 2014

Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

In the macro MPID_nem_lmt_send_RTS, the request for the send was being freed
on an error even if it didn't exist. This caused a segfault if calling a bcast
after a process previously failed.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

The macro that called the bcast function left out an underscore in the
mpi_errno return value. This caused the test to always return MPI_ERR_OTHER
instead of the value being returned by the underlying bcast function.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

The previous commit only adjusted the tag checking proceedure for MPIC_Recv,
but it should be the same for MPIC_Sendrecv and MPIC_Sendrecv_replace.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Signed-off-by: Wesley Bland <wbland@anl.gov>

Signed-off-by: Wesley Bland <wbland@anl.gov>

Paul Coffman authored Oct 19, 2014 and Rob Latham committed Oct 20, 2014

ADIOI_GPFS_WriteStridedColl and ADIOI_GPFS_ReadStridedColl need to call
MPIR_Status_set_bytes when GPFSMPIO_P2PCONTIG=1.

When the GPFSMPIO_P2PCONTIG optimization is set, the code path for
ADIOI_GPFS_WriteStridedColl and ADIOI_GPFS_ReadStridedColl returns
before MPIR_Status_set_bytes is called.  Duplicate the call to
MPIR_Status_set_bytes in the GPFSMPIO_P2PCONTIG code path.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Update a debug-only print string to accomodate recent updates to the
type of the length parameter.

No reviewer

Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Tags were sometimes being tested when the communication call had already
failed, leading to bad asserts later due to uninitialized values. Sometimes,
these results would have ended up with an error anyway, but sometimes not.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

The calls in MPID_Comm_get_all_failed_procs and MPID_Comm_agree  were the
wrong macros for entering and exiting an MPID function. This corrects it.
Signed-off-by: Huiwei Lu <huiweilu@mcs.anl.gov>

Revoke will call MPIDI_CH3U_Clean_recvq to dequeue all requests with
revoked communicators. There is one missing case: when there's hierarchy
communicators that use a different context id. This patch adds a case to
check the hierarchy communicators.
Signed-off-by: Wesley Bland <wbland@anl.gov>

Simplifies the test to only use 2 processes and not make as many MPI calls.

Modifications by Wesley Bland.
Signed-off-by: Wesley Bland <wbland@anl.gov>

This makes sure that macros work the normal way (using a semicolon at
the end, etc.) It also removes a block of unused code from
mx_cancel.c.

Modified by Wesley to split from previous patch.
Signed-off-by: Wesley Bland <wbland@anl.gov>
Signed-off-by: Pavan Balaji <balaji@anl.gov>

We were not setting the function states correctly in a bunch of
functions.

Modifications by Wesley to split up big commit.
Signed-off-by: Wesley Bland <wbland@anl.gov>
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Kenneth Raffenetti authored Oct 16, 2014 and Rob Latham committed Oct 17, 2014

The default linker behavior on BGQ makes interlibrary dependencies
tricky to support correctly. Just disable them to make our lives easier.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Pavan Balaji authored Oct 14, 2014 and Rob Latham committed Oct 17, 2014

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Paul Coffman authored Oct 07, 2014 and Rob Latham committed Oct 17, 2014

There are no pami optimized collectives available for inTERcomms
so when MPIDI_Coll_comm_create is called it checks to see
if the comm is an inTRAcomm and if not just returns,
however it was doing the new malloc for comm->coll_fns
before the if-check which was unsetting the MPICH defaults.
The solution is to move the malloc after the inTRAcomm
if-check.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Paul Coffman authored Oct 07, 2014 and Rob Latham committed Oct 17, 2014

The optimized pami code currently within MPIDO_Ibarrier
is incorrect - for now do not run it, instead just
kick back to MPICH if mpir_nbc is set, otherwise
call the blocking MPIR_Barrier().
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Paul Coffman authored Oct 07, 2014 and Rob Latham committed Oct 17, 2014

At the end of MPIDI_PAMI_context_init the MPIDI_Init_collsel_extension
is called to enable the dynamic optimized collective advisor.  This
is not supported on BGQ so ifdef out the call.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Paul Coffman authored Oct 07, 2014 and Rob Latham committed Oct 17, 2014

Since Blue Gene/Q does not support dynamic tasking there was only 1
element in the MPID_VCR_t data structure so a shortcut was taken
to avoid a malloc and free of a new list of pami_task_t in a form
the pami geometry creation was expecting.  However it seems an
array of structures with 1 pami_task_t element in it is not exactly the same
in memory as an array of pami_task_t  themselves so the pami
geometry creation was failing.  The fix is to simply do what
all other platforms do and malloc a separate list of pami_task_t.
Signed-off-by: Rob Latham <robl@mcs.anl.gov>

If a message size is <= PTL_LARGE_THRESHOLD, use a single operation.
Previously, this would generate unnecessary 0-byte operations when
messages were exactly the size of the threshold.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Previously, the message pointer in an improbe call in the portals4
netmod layer was set to MPI_MESSAGE_NULL if there was no match. This
is incorrect because the ch3 layer eventually returns either a valid
pointer or NULL. As ch3 already starts the value at NULL, we can just
omit the update.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

This CVAR was deprecated in MPICH 3.1 and will now be removed for MPICH 3.2.
Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

They are known to be failing. Mark them as xfail so they will not send
false alarms to other patches.

No reviewer.

Pavan Balaji authored Oct 14, 2014 and Sangmin Seo committed Oct 14, 2014

We need to check both the build and src directories before installing
the man and www pages.  We were only checking the build directory for
man and the src directory for www.  Also, make sure to install both
the man pages and the www pages on install.
Signed-off-by: Sangmin Seo <sseo@anl.gov>

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

Remove incorrect event from send handler assertion. PTL_EVENT_PUT should
only be seen at the target.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

This reverts commit dd62e809.