GitLab

Previously, the message pointer in an improbe call in the portals4
netmod layer was set to MPI_MESSAGE_NULL if there was no match. This
is incorrect because the ch3 layer eventually returns either a valid
pointer or NULL. As ch3 already starts the value at NULL, we can just
omit the update.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

This CVAR was deprecated in MPICH 3.1 and will now be removed for MPICH 3.2.
Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

They are known to be failing. Mark them as xfail so they will not send
false alarms to other patches.

No reviewer.

Pavan Balaji authored Oct 14, 2014 and Sangmin Seo committed Oct 14, 2014

We need to check both the build and src directories before installing
the man and www pages.  We were only checking the build directory for
man and the src directory for www.  Also, make sure to install both
the man pages and the www pages on install.
Signed-off-by: Sangmin Seo <sseo@anl.gov>

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

Remove incorrect event from send handler assertion. PTL_EVENT_PUT should
only be seen at the target.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

This reverts commit dd62e809.

This doesn't pass with mpich yet.
Signed-off-by: Wesley Bland <wbland@anl.gov>

Igor Ivanov authored Oct 10, 2014 and Pavan Balaji committed Oct 10, 2014

Memory leak can appear in case netmod usage. Comm override functions
are responsible for creating its own request. So they  need to come
before the sreq is created.
Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Igor Ivanov authored Oct 10, 2014 and Pavan Balaji committed Oct 10, 2014

Fixed wrong parameter check condition for MPI_Iallgather and MPI_Iallgatherv
-1 is valid value for sendcount in case MPI_IN_PLACE
MPI spec says:
The in place option for intracommunicators is specified by passing the value
MPI_IN_PLACE to the argument sendbuf at all processes. In such a case, sendcount and
sendtype are ignored, and the input data of each process is assumed to be in the area where
that process would receive its own contribution to the receive buffer.
Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>

In some cases, we cannot let hcoll use whatever transport it needs.
For example, ch3:sock assumes that while blocking the next event will
come over the socket channel.  If HCOLL decides to use a different
transport (such as mxm) and the next event comes on that transport,
this can result in a deadlock.  In this patch, we let the channel
specify what transports it can accept.
Signed-off-by: Devendar Bureddy <devendar@mellanox.com>

Tell users that they can disable warnings if needed.
Signed-off-by: Devendar Bureddy <devendar@mellanox.com>

Joe Ratterman authored May 02, 2011 and Pavan Balaji committed Oct 08, 2014

  If the ref-count is 1, we *should* be the only thread holding a
  reference.  It is therefore legal to skip atomics.  If that is
  insufficient justificaion, consider that there are only three things
  a concurrent thread should be doing:

    1) Reading: Not a problem, since the store is atomic.
    2) Decrementing: Illegal; it would go negative using pure atomics.
    3) Incrementing: Illegal; we are about to destroy the object.

Add #ifdef guard for use of 'aggressive counter optimizations'

(ibm) 20a558c3802fb3e138eb6b3c786a434538efffdd
Signed-off-by: Joe Ratterman <jratt@us.ibm.com>
Signed-off-by: Michael Blocksome <blocksom@us.ibm.com>

Updated by Pavan Balaji to use an OPA atomic load instead of a simple
load operation.

Fixes #1835
Signed-off-by: Pavan Balaji <balaji@anl.gov>
Signed-off-by: William Gropp <wgropp@illinois.edu>

Sangmin Seo authored Oct 07, 2014 and Pavan Balaji committed Oct 07, 2014

Signed-off-by: Pavan Balaji <balaji@anl.gov>

Sangmin Seo authored Oct 07, 2014 and Pavan Balaji committed Oct 07, 2014

Signed-off-by: Pavan Balaji <balaji@anl.gov>

Sangmin Seo authored Oct 07, 2014 and Pavan Balaji committed Oct 07, 2014

Signed-off-by: Pavan Balaji <balaji@anl.gov>

Pavan Balaji authored Oct 07, 2014 and Rob Latham committed Oct 07, 2014

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

This variable is incremented correctly by the
MPIDI_CH3U_Recvq_FDP_or_AEU routine, but the MPIDI_CH3U_Recvq_DP fails
to do so, although it also goes through the posted recv queue. For
instance, the MXM Netmod calls this routine.
Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

The non-blocking neighborhood collectives were not set up correctly
in pamid.

ibm (D199919)
Signed-off-by: Su Huang <suhuang@us.ibm.com>

We were only exposing a part of the allocated buffer as public
memory, but attempting to use all of it remotely.

Thanks to Charles Archer @ Intel for reporting the error and
contributing the fix.
Signed-off-by: Min Si <msi@il.is.s.u-tokyo.ac.jp>

This reverts commit 32f3a924.

Invalidate the handle of an ME that has been matched and handled in
the portals4 netmod *before* dequeuing the request. The prevents
potential double unlinking failures.
Signed-off-by: Antonio J. Pena <apenya@mcs.anl.gov>

Igor Ivanov authored Sep 05, 2014 and Pavan Balaji committed Oct 03, 2014

Previous code is based on a trick to get true context id using
invalid communicator. There is a call of MPIR_Get_contextid()
for new communicator that is not completelly built (no comm_commit
and comm_hook calls).
netmod/mxm uses comm_hook and can not work with this trick.
This changes allow to avoid call of invalid communicator using
temporary (intermediate) communicator.
Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>
Signed-off-by: Pavan Balaji <balaji@anl.gov>

halim amer authored Sep 05, 2014 and Kenneth Raffenetti committed Oct 03, 2014

This example does not rely on getcpu() or sched_getcpu() which are not
available on old kernels/glibc.
Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>

Igor Ivanov authored Oct 03, 2014 and Pavan Balaji committed Oct 03, 2014

- Fix issue in anysource match;
- Improve debug output;
Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Wesley Bland authored Oct 03, 2014 and Rob Latham committed Oct 03, 2014

Signed-off-by: Rob Latham <robl@mcs.anl.gov>

Signed-off-by: Junchao Zhang <jczhang@mcs.anl.gov>

This test sometimes causes TIMEOUT in Jenkins TCP test.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Here we move the SHM barrier in MPI_Win_fence after the completion
of coming-in RMA operations, so that following coming-in RMA
operations on SHM in the next FENCE epoch will see the updated value.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

at_completion_counter is used to indicate if all Active Target
operations have completed on this target.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

For GET-like operations, We should increment the Active Target counter
when the process of sending back data is not completed immediately on
target and a response request is created. We should decrement the counter
when the process of sending back data is completed on target side.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

In the original implementation, for GACC/FOP/CAS, the function
MPIDI_CH3_Finish_rma_op_target (includes operations that should
be performed on target when that operation finishes on target)
is not called when that operation real finishes, but is called
after starting send back data.

Here we fix it to make the function called after sending process
on target is completed.
Signed-off-by: Pavan Balaji <balaji@anl.gov>

Initializing mpiu_chklmem_stk_sp_ to 0 should already have the effect to
initialize mpiu_chklmem_stk_[n_].
Signed-off-by: Antonio J. Pena <apenya@mcs.anl.gov>

// comments are erroneous with --enable-strict=c89
Signed-off-by: Antonio J. Pena <apenya@mcs.anl.gov>

The warning message is:
    warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

Fixes #2167
Signed-off-by: Antonio J. Pena <apenya@mcs.anl.gov>

Fixes issues introduced in [fdd179c1

] when doing noncontiguous sends
or recvs over portals4. Also make more consistent usage of MPID_Segment
manipulation functions.
Signed-off-by: Antonio J. Pena <apenya@mcs.anl.gov>

The logic used to periodically issue a barrier
for PAMI algorithms that request flow control
was erroneous. The root ended up issuing a barrier
before the non-root tasks.

(ibm) D199034
Signed-off-by: Sameh Sharkawi <sssharka@us.ibm.com>

In this test, during Active Target epoch, the origin process
issues a large GET operation followed by a small PUT operation
to the target process. Win_wait / Win_fence should guarantee
all operations are completed at target when they returns. So
after they return, we make the target process to update one
window location accessed by that GET before. The GET operation
should not get the updated value.
Signed-off-by: Pavan Balaji <balaji@anl.gov>