Skip to content

GitLab

Commit 952bf959 authored by James Dinan's avatar James Dinan
Browse files

[svn-r10516] Replaced pg_rank with proper target rank 

Reviewer: buntinas
parent 656b26f5
Show whitespace changes
Inline Side-by-side
src/mpid/ch3/include/mpidimpl.h
View file @ 952bf959
...@@ -1226,8 +1226,8 @@ int MPIDI_Free_mem(void *ptr); ...@@ -1226,8 +1226,8 @@ int MPIDI_Free_mem(void *ptr);
/* internal */ /* internal */
int MPIDI_CH3I_Release_lock(MPID_Win * win_ptr); int MPIDI_CH3I_Release_lock(MPID_Win * win_ptr);
int MPIDI_CH3I_Try_acquire_win_lock(MPID_Win * win_ptr, int requested_lock); int MPIDI_CH3I_Try_acquire_win_lock(MPID_Win * win_ptr, int requested_lock);
int MPIDI_CH3I_Send_lock_granted_pkt(MPIDI_VC_t * vc, int source_win_ptr); int MPIDI_CH3I_Send_lock_granted_pkt(MPIDI_VC_t * vc, MPID_Win *win_ptr, int source_win_hdl);
int MPIDI_CH3I_Send_pt_rma_done_pkt(MPIDI_VC_t * vc, int source_win_ptr); int MPIDI_CH3I_Send_pt_rma_done_pkt(MPIDI_VC_t * vc, MPID_Win *win_ptr, int source_win_hdl);
#define MPIDI_CH3I_DATATYPE_IS_PREDEFINED(type, predefined) \ #define MPIDI_CH3I_DATATYPE_IS_PREDEFINED(type, predefined) \
if ((HANDLE_GET_KIND(type) == HANDLE_KIND_BUILTIN) || \ if ((HANDLE_GET_KIND(type) == HANDLE_KIND_BUILTIN) || \
......
src/mpid/ch3/include/mpidpkt.h
View file @ 952bf959
...@@ -327,6 +327,8 @@ typedef struct MPIDI_CH3_Pkt_lock ...@@ -327,6 +327,8 @@ typedef struct MPIDI_CH3_Pkt_lock
int lock_type; int lock_type;
MPI_Win target_win_handle; MPI_Win target_win_handle;
MPI_Win source_win_handle; MPI_Win source_win_handle;
int target_rank; /* Used in unluck/flush response to look up the
target state at the origin. */
} }
MPIDI_CH3_Pkt_lock_t; MPIDI_CH3_Pkt_lock_t;
...@@ -334,6 +336,8 @@ typedef struct MPIDI_CH3_Pkt_lock_granted ...@@ -334,6 +336,8 @@ typedef struct MPIDI_CH3_Pkt_lock_granted
{ {
MPIDI_CH3_Pkt_type_t type; MPIDI_CH3_Pkt_type_t type;
MPI_Win source_win_handle; MPI_Win source_win_handle;
int target_rank; /* Used in pt_rma_done response to look up the
target state at the origin. */
} }
MPIDI_CH3_Pkt_lock_granted_t; MPIDI_CH3_Pkt_lock_granted_t;
......
src/mpid/ch3/src/ch3u_handle_recv_req.c
View file @ 952bf959
...@@ -172,7 +172,7 @@ int MPIDI_CH3_ReqHandler_PutAccumRespComplete( MPIDI_VC_t *vc, ...@@ -172,7 +172,7 @@ int MPIDI_CH3_ReqHandler_PutAccumRespComplete( MPIDI_VC_t *vc,
else { else {
if ((win_ptr->current_lock_type == MPI_LOCK_SHARED) || if ((win_ptr->current_lock_type == MPI_LOCK_SHARED) ||
(rreq->dev.single_op_opt == 1)) { (rreq->dev.single_op_opt == 1)) {
mpi_errno = MPIDI_CH3I_Send_pt_rma_done_pkt(vc, mpi_errno = MPIDI_CH3I_Send_pt_rma_done_pkt(vc, win_ptr,
rreq->dev.source_win_handle); rreq->dev.source_win_handle);
if (mpi_errno) { if (mpi_errno) {
MPIU_ERR_POP(mpi_errno); MPIU_ERR_POP(mpi_errno);
...@@ -466,7 +466,7 @@ int MPIDI_CH3_ReqHandler_SinglePutAccumComplete( MPIDI_VC_t *vc, ...@@ -466,7 +466,7 @@ int MPIDI_CH3_ReqHandler_SinglePutAccumComplete( MPIDI_VC_t *vc,
win_ptr->my_pt_rma_puts_accs++; win_ptr->my_pt_rma_puts_accs++;
/* send done packet */ /* send done packet */
mpi_errno = MPIDI_CH3I_Send_pt_rma_done_pkt(vc, mpi_errno = MPIDI_CH3I_Send_pt_rma_done_pkt(vc, win_ptr,
lock_queue_entry->source_win_handle); lock_queue_entry->source_win_handle);
if (mpi_errno) { if (mpi_errno) {
MPIU_ERR_POP(mpi_errno); MPIU_ERR_POP(mpi_errno);
...@@ -1023,7 +1023,7 @@ int MPIDI_CH3I_Release_lock(MPID_Win *win_ptr) ...@@ -1023,7 +1023,7 @@ int MPIDI_CH3I_Release_lock(MPID_Win *win_ptr)
win_ptr->my_pt_rma_puts_accs++; win_ptr->my_pt_rma_puts_accs++;
mpi_errno = mpi_errno =
MPIDI_CH3I_Send_pt_rma_done_pkt(lock_queue->vc, MPIDI_CH3I_Send_pt_rma_done_pkt(lock_queue->vc, win_ptr,
lock_queue->source_win_handle); lock_queue->source_win_handle);
if (mpi_errno != MPI_SUCCESS) goto fn_exit; if (mpi_errno != MPI_SUCCESS) goto fn_exit;
...@@ -1071,7 +1071,7 @@ int MPIDI_CH3I_Release_lock(MPID_Win *win_ptr) ...@@ -1071,7 +1071,7 @@ int MPIDI_CH3I_Release_lock(MPID_Win *win_ptr)
else { else {
/* send lock granted packet. */ /* send lock granted packet. */
mpi_errno = mpi_errno =
MPIDI_CH3I_Send_lock_granted_pkt(lock_queue->vc, MPIDI_CH3I_Send_lock_granted_pkt(lock_queue->vc, win_ptr,
lock_queue->source_win_handle); lock_queue->source_win_handle);
/* dequeue entry from lock queue */ /* dequeue entry from lock queue */
...@@ -1105,7 +1105,8 @@ int MPIDI_CH3I_Release_lock(MPID_Win *win_ptr) ...@@ -1105,7 +1105,8 @@ int MPIDI_CH3I_Release_lock(MPID_Win *win_ptr)
#define FUNCNAME MPIDI_CH3I_Send_pt_rma_done_pkt #define FUNCNAME MPIDI_CH3I_Send_pt_rma_done_pkt
#undef FCNAME #undef FCNAME
#define FCNAME MPIDI_QUOTE(FUNCNAME) #define FCNAME MPIDI_QUOTE(FUNCNAME)
int MPIDI_CH3I_Send_pt_rma_done_pkt(MPIDI_VC_t *vc, MPI_Win source_win_handle) int MPIDI_CH3I_Send_pt_rma_done_pkt(MPIDI_VC_t *vc, MPID_Win *win_ptr,
MPI_Win source_win_handle)
{ {
MPIDI_CH3_Pkt_t upkt; MPIDI_CH3_Pkt_t upkt;
MPIDI_CH3_Pkt_pt_rma_done_t *pt_rma_done_pkt = &upkt.pt_rma_done; MPIDI_CH3_Pkt_pt_rma_done_t *pt_rma_done_pkt = &upkt.pt_rma_done;
...@@ -1117,6 +1118,7 @@ int MPIDI_CH3I_Send_pt_rma_done_pkt(MPIDI_VC_t *vc, MPI_Win source_win_handle) ...@@ -1117,6 +1118,7 @@ int MPIDI_CH3I_Send_pt_rma_done_pkt(MPIDI_VC_t *vc, MPI_Win source_win_handle)
MPIDI_Pkt_init(pt_rma_done_pkt, MPIDI_CH3_PKT_PT_RMA_DONE); MPIDI_Pkt_init(pt_rma_done_pkt, MPIDI_CH3_PKT_PT_RMA_DONE);
pt_rma_done_pkt->source_win_handle = source_win_handle; pt_rma_done_pkt->source_win_handle = source_win_handle;
pt_rma_done_pkt->target_rank = win_ptr->comm_ptr->rank;
/* Because this is in a packet handler, it is already within a critical section */ /* Because this is in a packet handler, it is already within a critical section */
/* MPIU_THREAD_CS_ENTER(CH3COMM,vc); */ /* MPIU_THREAD_CS_ENTER(CH3COMM,vc); */
......
src/mpid/ch3/src/ch3u_rma_sync.c
View file @ 952bf959
...@@ -2951,7 +2951,8 @@ static int MPIDI_CH3I_Send_lock_get(MPID_Win *win_ptr, int target_rank) ...@@ -2951,7 +2951,8 @@ static int MPIDI_CH3I_Send_lock_get(MPID_Win *win_ptr, int target_rank)
#define FUNCNAME MPIDI_CH3I_Send_lock_granted_pkt #define FUNCNAME MPIDI_CH3I_Send_lock_granted_pkt
#undef FCNAME #undef FCNAME
#define FCNAME MPIDI_QUOTE(FUNCNAME) #define FCNAME MPIDI_QUOTE(FUNCNAME)
int MPIDI_CH3I_Send_lock_granted_pkt(MPIDI_VC_t *vc, MPI_Win source_win_handle) int MPIDI_CH3I_Send_lock_granted_pkt(MPIDI_VC_t *vc, MPID_Win *win_ptr,
MPI_Win source_win_handle)
{ {
MPIDI_CH3_Pkt_t upkt; MPIDI_CH3_Pkt_t upkt;
MPIDI_CH3_Pkt_lock_granted_t *lock_granted_pkt = &upkt.lock_granted; MPIDI_CH3_Pkt_lock_granted_t *lock_granted_pkt = &upkt.lock_granted;
...@@ -2964,6 +2965,7 @@ int MPIDI_CH3I_Send_lock_granted_pkt(MPIDI_VC_t *vc, MPI_Win source_win_handle) ...@@ -2964,6 +2965,7 @@ int MPIDI_CH3I_Send_lock_granted_pkt(MPIDI_VC_t *vc, MPI_Win source_win_handle)
/* send lock granted packet */ /* send lock granted packet */
MPIDI_Pkt_init(lock_granted_pkt, MPIDI_CH3_PKT_LOCK_GRANTED); MPIDI_Pkt_init(lock_granted_pkt, MPIDI_CH3_PKT_LOCK_GRANTED);
lock_granted_pkt->source_win_handle = source_win_handle; lock_granted_pkt->source_win_handle = source_win_handle;
lock_granted_pkt->target_rank = win_ptr->comm_ptr->rank;
MPIU_DBG_MSG_FMT(CH3_OTHER,VERBOSE, MPIU_DBG_MSG_FMT(CH3_OTHER,VERBOSE,
(MPIU_DBG_FDEST, "sending lock granted pkt on vc=%p, source_win_handle=%#08x", (MPIU_DBG_FDEST, "sending lock granted pkt on vc=%p, source_win_handle=%#08x",
...@@ -3533,7 +3535,7 @@ int MPIDI_CH3_PktHandler_Accumulate_Immed( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt, ...@@ -3533,7 +3535,7 @@ int MPIDI_CH3_PktHandler_Accumulate_Immed( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt,
else { else {
if ((win_ptr->current_lock_type == MPI_LOCK_SHARED) || if ((win_ptr->current_lock_type == MPI_LOCK_SHARED) ||
(/*rreq->dev.single_op_opt*/ 0 == 1)) { (/*rreq->dev.single_op_opt*/ 0 == 1)) {
mpi_errno = MPIDI_CH3I_Send_pt_rma_done_pkt(vc, mpi_errno = MPIDI_CH3I_Send_pt_rma_done_pkt(vc, win_ptr,
accum_pkt->source_win_handle); accum_pkt->source_win_handle);
if (mpi_errno) { if (mpi_errno) {
MPIU_ERR_POP(mpi_errno); MPIU_ERR_POP(mpi_errno);
...@@ -3916,7 +3918,7 @@ int MPIDI_CH3_PktHandler_Lock( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt, ...@@ -3916,7 +3918,7 @@ int MPIDI_CH3_PktHandler_Lock( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt,
lock_pkt->lock_type) == 1) lock_pkt->lock_type) == 1)
{ {
/* send lock granted packet. */ /* send lock granted packet. */
mpi_errno = MPIDI_CH3I_Send_lock_granted_pkt(vc, mpi_errno = MPIDI_CH3I_Send_lock_granted_pkt(vc, win_ptr,
lock_pkt->source_win_handle); lock_pkt->source_win_handle);
} }
...@@ -4432,8 +4434,7 @@ int MPIDI_CH3_PktHandler_LockGranted( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt, ...@@ -4432,8 +4434,7 @@ int MPIDI_CH3_PktHandler_LockGranted( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt,
MPID_Win_get_ptr(lock_granted_pkt->source_win_handle, win_ptr); MPID_Win_get_ptr(lock_granted_pkt->source_win_handle, win_ptr);
/* set the remote_lock_state flag in the window */ /* set the remote_lock_state flag in the window */
/* FIXME: pg_rank is only valid when win_ptr->comm_ptr == MPI_COMM_WORLD */ win_ptr->targets[lock_granted_pkt->target_rank].remote_lock_state = MPIDI_CH3_WIN_LOCK_GRANTED;
win_ptr->targets[vc->pg_rank].remote_lock_state = MPIDI_CH3_WIN_LOCK_GRANTED;
*rreqp = NULL; *rreqp = NULL;
MPIDI_CH3_Progress_signal_completion(); MPIDI_CH3_Progress_signal_completion();
...@@ -4461,11 +4462,10 @@ int MPIDI_CH3_PktHandler_PtRMADone( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt, ...@@ -4461,11 +4462,10 @@ int MPIDI_CH3_PktHandler_PtRMADone( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt,
MPID_Win_get_ptr(pt_rma_done_pkt->source_win_handle, win_ptr); MPID_Win_get_ptr(pt_rma_done_pkt->source_win_handle, win_ptr);
/* FIXME: pg_rank is only valid when win_ptr->comm_ptr == MPI_COMM_WORLD */ if (win_ptr->targets[pt_rma_done_pkt->target_rank].remote_lock_state == MPIDI_CH3_WIN_LOCK_FLUSH)
if (win_ptr->targets[vc->pg_rank].remote_lock_state == MPIDI_CH3_WIN_LOCK_FLUSH) win_ptr->targets[pt_rma_done_pkt->target_rank].remote_lock_state = MPIDI_CH3_WIN_LOCK_GRANTED;
win_ptr->targets[vc->pg_rank].remote_lock_state = MPIDI_CH3_WIN_LOCK_GRANTED;
else else
win_ptr->targets[vc->pg_rank].remote_lock_state = MPIDI_CH3_WIN_LOCK_NONE; win_ptr->targets[pt_rma_done_pkt->target_rank].remote_lock_state = MPIDI_CH3_WIN_LOCK_NONE;
*rreqp = NULL; *rreqp = NULL;
MPIDI_CH3_Progress_signal_completion(); MPIDI_CH3_Progress_signal_completion();
...@@ -4532,7 +4532,10 @@ int MPIDI_CH3_PktHandler_Flush( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt, ...@@ -4532,7 +4532,10 @@ int MPIDI_CH3_PktHandler_Flush( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt,
if (flush_pkt->target_win_handle != MPI_WIN_NULL) { if (flush_pkt->target_win_handle != MPI_WIN_NULL) {
MPID_Request *req=NULL; MPID_Request *req=NULL;
MPID_Win_get_ptr(flush_pkt->target_win_handle, win_ptr);
flush_pkt->target_win_handle = MPI_WIN_NULL; flush_pkt->target_win_handle = MPI_WIN_NULL;
flush_pkt->target_rank = win_ptr->comm_ptr->rank;
MPIU_THREAD_CS_ENTER(CH3COMM,vc); MPIU_THREAD_CS_ENTER(CH3COMM,vc);
mpi_errno = MPIDI_CH3_iStartMsg(vc, flush_pkt, sizeof(*flush_pkt), &req); mpi_errno = MPIDI_CH3_iStartMsg(vc, flush_pkt, sizeof(*flush_pkt), &req);
...@@ -4548,8 +4551,7 @@ int MPIDI_CH3_PktHandler_Flush( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt, ...@@ -4548,8 +4551,7 @@ int MPIDI_CH3_PktHandler_Flush( MPIDI_VC_t *vc, MPIDI_CH3_Pkt_t *pkt,
/* This is a flush response packet */ /* This is a flush response packet */
else { else {
MPID_Win_get_ptr(flush_pkt->source_win_handle, win_ptr); MPID_Win_get_ptr(flush_pkt->source_win_handle, win_ptr);
/* FIXME: pg_rank is only valid when win_ptr->comm_ptr == MPI_COMM_WORLD */ win_ptr->targets[flush_pkt->target_rank].remote_lock_state = MPIDI_CH3_WIN_LOCK_GRANTED;
win_ptr->targets[vc->pg_rank].remote_lock_state = MPIDI_CH3_WIN_LOCK_GRANTED;
MPIDI_CH3_Progress_signal_completion(); MPIDI_CH3_Progress_signal_completion();
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment