Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Rob Latham
MPICH-BlueGene
Commits
6f304b2c
Commit
6f304b2c
authored
Oct 25, 2010
by
David Goodell
Browse files
[svn-r7373] add TODOs for BG optimization opportunities
No reviewer.
parent
b148a64b
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/include/mpihandlemem.h
View file @
6f304b2c
...
...
@@ -313,6 +313,8 @@ typedef OPA_int_t MPIU_Handle_ref_count;
* It is also assumed that any object being reference counted via these macros
* will have a valid value in the handle field, even if it is
* HANDLE_SET_KIND(0, HANDLE_KIND_INVALID) */
/* TODO profile and examine the assembly that is generated for this if() on Blue
* Gene (and elsewhere). We may need to mark it unlikely(). */
#define MPIU_Object_add_ref(objptr_) \
do { \
int handle_kind_ = HANDLE_GET_KIND((objptr_)->handle); \
...
...
src/include/mpiimpl.h
View file @
6f304b2c
...
...
@@ -369,6 +369,9 @@ void *MPIU_Handle_indirect_init( void *(**)[], int *, int, int, int, int );
int MPIU_Handle_free( void *((*)[]), int );
*/
/* Convert Handles to objects for MPI types that have predefined objects */
/* TODO examine generated assembly for this construct, it's probably suboptimal
* on Blue Gene. An if/else if/else might help the compiler out. It also lets
* us hint that one case is likely(), usually the BUILTIN case. */
#define MPID_Getb_ptr(kind,a,bmsk,ptr) \
{ \
switch (HANDLE_GET_KIND(a)) { \
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment