tsuite: explicitly add -lpthread when used in tests

For tests that call pthread routines, add an explicit dependency.
This was not an issue previously, because either the compile wrappers
always added -lpthread, or the linker discovered the pthread symbols
via an interlibrary dependency on libmpi. However on FreeBSD 10, the
interlibrary dependency resolution appears more strict. Applications
must specify any libraries directly used, thus this fix.
Signed-off-by: Halim Amer <aamer@anl.gov>

test/mpi/configure.ac

@@ -695,6 +695,7 @@ if test "$spawndir" = "spawn" ; then
     AC_SUBST(nslib)
 fi
 
+threadlib=""
 # Headers needed for threads tests
 if test "$threadsdir" = "threads" ; then
     # Check for needed threads headers and needed and optional routines
@@ -703,7 +704,7 @@ if test "$threadsdir" = "threads" ; then
     # we shouldn't actually need to do this, but we are dodging the chicken/egg
     # problem b/c we don't have a working mpicc yet and we temporarily discarded
     # the MPICH-set LIBS (probably the wrong thing to do)
-    AC_SEARCH_LIBS([pthread_create],[pthread])
+    AC_SEARCH_LIBS([pthread_create],[pthread],[threadlib="-lpthread"])
     AC_SEARCH_LIBS([pthread_barrier_init],[pthread])
 
     AC_CHECK_FUNCS(pthread_create pthread_yield pthread_barrier_init pthread_barrier_wait)
@@ -711,6 +712,7 @@ if test "$threadsdir" = "threads" ; then
         AC_CHECK_FUNCS(MPI_Init_thread)
     fi    
 fi
+AC_SUBST(threadlib)
 
 # Check for h_addr or h_addr_list.  This is needed for the singjoin test
 # in manual/singjoin.c

test/mpi/manual/Makefile.am

@@ -16,7 +16,7 @@ noinst_PROGRAMS = singjoin testconnect testconnectserial dimsbalanced \
 # directory of the MPI library.  This definition is not required.
 noinst_HEADERS = connectstuff.h
 testconnectserial_SOURCES = testconnectserial.c tchandlers.c tcutil.c 
-testconnectserial_LDADD   = $(LDADD) -lm
+testconnectserial_LDADD   = $(LDADD) -lm -lpthread
 
 singjoin_LDADD = $(LDADD) @socklib@ @nslib@
 

test/mpi/threads/Makefile_threads.mtest

@@ -13,7 +13,7 @@
 include $(top_srcdir)/Makefile.mtest
 
 ## then add rules/vars for mtestthread.o
-LDADD += $(top_builddir)/threads/util/mtestthread.$(OBJEXT)
+LDADD += $(top_builddir)/threads/util/mtestthread.$(OBJEXT) @threadlib@
 
 $(top_builddir)/threads/util/mtestthread.$(OBJEXT): $(top_srcdir)/threads/util/mtestthread.c
 	(cd $(top_builddir)/threads/util && $(MAKE) mtestthread.$(OBJEXT))