Commit 4d93cefa authored by Pavan Balaji's avatar Pavan Balaji
Browse files

Remove MPICHLIB_LDFLAGS/LIBS



It does not make sense for the user to specify LDFLAGS/LIBS that would
only be used to build the MPICH library, but not the user application.
Doing do will create a false dependency of the MPICH library on these
external libraries resulting in weird interactions with the user
application in cases where interlibrary dependencies are not
supported.  We were anyway silently modifying the WRAPPER LDFLAGS/LIBS
to include these anyway, so the flags themselves were weirdly screwed
up.

This patch simply removes them instead of pretending to allow them,
but not really allowing them.
Signed-off-by: Kenneth Raffenetti's avatarKen Raffenetti <raffenet@mcs.anl.gov>
parent 9fee068c
...@@ -286,10 +286,10 @@ MPICH library being compiled/linked with these flags and the flags ...@@ -286,10 +286,10 @@ MPICH library being compiled/linked with these flags and the flags
internally being used in mpicc and friends. internally being used in mpicc and friends.
(b) MPICHLIB_CFLAGS, MPICHLIB_CPPFLAGS, MPICHLIB_CXXFLAGS, (b) MPICHLIB_CFLAGS, MPICHLIB_CPPFLAGS, MPICHLIB_CXXFLAGS,
MPICHLIB_FFLAGS, MPICHLIB_FCFLAGS, MPICHLIB_LDFLAGS and MPICHLIB_FFLAGS, and MPICHLIB_FCFLAGS (abbreviated as
MPICHLIB_LIBS (abbreviated as MPICHLIB_xFLAGS): Setting these flags MPICHLIB_xFLAGS): Setting these flags would result in the MPICH
would result in the MPICH library being compiled/linked with these library being compiled with these flags. However, these flags will
flags. However, these flags will *not* be used by mpicc and friends. *not* be used by mpicc and friends.
(c) MPICH_MAKE_CFLAGS: Setting these flags would result in MPICH's (c) MPICH_MAKE_CFLAGS: Setting these flags would result in MPICH's
configure tests to not use these flags, but the makefile's to use configure tests to not use these flags, but the makefile's to use
......
...@@ -296,17 +296,11 @@ AC_ARG_VAR(MPICHLIB_FFLAGS, ...@@ -296,17 +296,11 @@ AC_ARG_VAR(MPICHLIB_FFLAGS,
[extra FFLAGS used in building MPICH libraries]) [extra FFLAGS used in building MPICH libraries])
AC_ARG_VAR(MPICHLIB_FCFLAGS, AC_ARG_VAR(MPICHLIB_FCFLAGS,
[extra FCFLAGS used in building MPICH libraries]) [extra FCFLAGS used in building MPICH libraries])
AC_ARG_VAR(MPICHLIB_LDFLAGS,
[extra LDFLAGS used in building MPICH libraries])
AC_ARG_VAR(MPICHLIB_LIBS,
[extra LIBS used in building MPICH libraries])
CFLAGS="$CFLAGS $MPICHLIB_CFLAGS" CFLAGS="$CFLAGS $MPICHLIB_CFLAGS"
CPPFLAGS="$CPPFLAGS $MPICHLIB_CPPFLAGS" CPPFLAGS="$CPPFLAGS $MPICHLIB_CPPFLAGS"
CXXFLAGS="$CXXFLAGS $MPICHLIB_CXXFLAGS" CXXFLAGS="$CXXFLAGS $MPICHLIB_CXXFLAGS"
FFLAGS="$FFLAGS $MPICHLIB_FFLAGS" FFLAGS="$FFLAGS $MPICHLIB_FFLAGS"
FCFLAGS="$FCFLAGS $MPICHLIB_FCFLAGS" FCFLAGS="$FCFLAGS $MPICHLIB_FCFLAGS"
LDFLAGS="$LDFLAGS $MPICHLIB_LDFLAGS"
LIBS="$LIBS $MPICHLIB_LIBS"
dnl include all subsystem m4 fragments now that the core autoconf functionality dnl include all subsystem m4 fragments now that the core autoconf functionality
dnl has been setup. No fragment should do anything except define dnl has been setup. No fragment should do anything except define
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment