Commit 35a05b3c authored by Xin Zhao's avatar Xin Zhao Committed by Pavan Balaji
Browse files

Remove unused have_remote_incomplete_ops.



have_remote_incomplete_ops is not actually used
in the code, we remove it here.
Signed-off-by: Pavan Balaji's avatarPavan Balaji <balaji@anl.gov>
parent 98c791a6
......@@ -126,9 +126,7 @@ static inline MPIDI_RMA_Target_t *MPIDI_CH3I_Win_target_alloc(MPID_Win * win_ptr
e->sync.sync_flag = MPIDI_RMA_SYNC_NONE;
e->sync.outstanding_acks = 0;
e->sync.have_remote_incomplete_ops = 1; /* When I create a new target, there must be
* incomplete ops until a FLUSH/UNLOCK packet
* is sent. */
return e;
}
......@@ -459,8 +457,7 @@ static inline int MPIDI_CH3I_RMA_Cleanup_ops_target(MPID_Win * win_ptr, MPIDI_RM
/* for the conditions that need to be satisfied before we free the
* target, see the MPIDI_RMA_Target definition in
* mpid_rma_types.h */
if (target->sync.sync_flag == MPIDI_RMA_SYNC_NONE &&
target->sync.outstanding_acks == 0 && target->sync.have_remote_incomplete_ops == 0) {
if (target->sync.sync_flag == MPIDI_RMA_SYNC_NONE && target->sync.outstanding_acks == 0) {
(*remote_completed) = 1;
}
}
......
......@@ -100,7 +100,6 @@ typedef struct MPIDI_RMA_Target {
* following conditions hold true:
* - No operations are queued up (op_list == NULL)
* - There are no outstanding acks (outstanding_acks == 0)
* - There are no incomplete ops (have_remote_incomplete_ops == 0)
* - There are no sync messages to be sent (sync_flag == NONE)
*/
struct {
......@@ -110,12 +109,6 @@ typedef struct MPIDI_RMA_Target {
/* packets sent out that we are expecting an ack for */
int outstanding_acks;
/* if we sent out any operations, but have not waited for
* their remote completion, this flag is set. When the next
* FLUSH or UNLOCK sync flag is set, we will clear this
* variable. */
int have_remote_incomplete_ops; /* have ops that have not completed remotely */
} sync;
MPIDI_RMA_Pool_type_t pool_type;
......
......@@ -715,7 +715,6 @@ int MPIDI_CH3I_RMA_Cleanup_target_aggressive(MPID_Win * win_ptr, MPIDI_RMA_Targe
curr_target = win_ptr->slots[i].target_list;
if (curr_target->sync.sync_flag < MPIDI_RMA_SYNC_FLUSH) {
curr_target->sync.sync_flag = MPIDI_RMA_SYNC_FLUSH;
curr_target->sync.have_remote_incomplete_ops = 0;
curr_target->sync.outstanding_acks++;
}
......
......@@ -374,7 +374,6 @@ int MPIDI_Win_fence(int assert, MPID_Win * win_ptr)
/* set sync_flag in sync struct */
if (curr_target->sync.sync_flag < MPIDI_RMA_SYNC_FLUSH) {
curr_target->sync.sync_flag = MPIDI_RMA_SYNC_FLUSH;
curr_target->sync.have_remote_incomplete_ops = 0;
curr_target->sync.outstanding_acks++;
}
curr_target = curr_target->next;
......@@ -754,7 +753,6 @@ int MPIDI_Win_complete(MPID_Win * win_ptr)
/* set sync_flag in sync struct */
if (curr_target->sync.sync_flag < MPIDI_RMA_SYNC_FLUSH) {
curr_target->sync.sync_flag = MPIDI_RMA_SYNC_FLUSH;
curr_target->sync.have_remote_incomplete_ops = 0;
curr_target->sync.outstanding_acks++;
}
curr_target->win_complete_flag = 1;
......@@ -1090,7 +1088,6 @@ int MPIDI_Win_unlock(int dest, MPID_Win * win_ptr)
sync_flag = MPIDI_RMA_SYNC_UNLOCK;
if (target->sync.sync_flag < sync_flag) {
target->sync.sync_flag = sync_flag;
target->sync.have_remote_incomplete_ops = 0;
target->sync.outstanding_acks++;
}
......@@ -1211,7 +1208,6 @@ int MPIDI_Win_flush(int dest, MPID_Win * win_ptr)
/* Set sync_flag in sync struct. */
if (target->sync.sync_flag < MPIDI_RMA_SYNC_FLUSH) {
target->sync.sync_flag = MPIDI_RMA_SYNC_FLUSH;
target->sync.have_remote_incomplete_ops = 0;
target->sync.outstanding_acks++;
}
......@@ -1318,7 +1314,6 @@ int MPIDI_Win_flush_local(int dest, MPID_Win * win_ptr)
if (target->disable_flush_local) {
if (target->sync.sync_flag < MPIDI_RMA_SYNC_FLUSH) {
target->sync.sync_flag = MPIDI_RMA_SYNC_FLUSH;
target->sync.have_remote_incomplete_ops = 0;
target->sync.outstanding_acks++;
}
}
......@@ -1531,7 +1526,6 @@ int MPIDI_Win_unlock_all(MPID_Win * win_ptr)
while (curr_target != NULL) {
if (curr_target->sync.sync_flag < sync_flag) {
curr_target->sync.sync_flag = sync_flag;
curr_target->sync.have_remote_incomplete_ops = 0;
curr_target->sync.outstanding_acks++;
}
curr_target = curr_target->next;
......@@ -1551,7 +1545,6 @@ int MPIDI_Win_unlock_all(MPID_Win * win_ptr)
if (curr_target != NULL) {
if (curr_target->sync.sync_flag < sync_flag) {
curr_target->sync.sync_flag = sync_flag;
curr_target->sync.have_remote_incomplete_ops = 0;
curr_target->sync.outstanding_acks++;
}
}
......@@ -1673,7 +1666,6 @@ int MPIDI_Win_flush_all(MPID_Win * win_ptr)
while (curr_target != NULL) {
if (curr_target->sync.sync_flag < MPIDI_RMA_SYNC_FLUSH) {
curr_target->sync.sync_flag = MPIDI_RMA_SYNC_FLUSH;
curr_target->sync.have_remote_incomplete_ops = 0;
curr_target->sync.outstanding_acks++;
}
......@@ -1769,7 +1761,6 @@ int MPIDI_Win_flush_local_all(MPID_Win * win_ptr)
if (curr_target->disable_flush_local) {
if (curr_target->sync.sync_flag < MPIDI_RMA_SYNC_FLUSH) {
curr_target->sync.sync_flag = MPIDI_RMA_SYNC_FLUSH;
curr_target->sync.have_remote_incomplete_ops = 0;
curr_target->sync.outstanding_acks++;
}
disable_flush_local_cnt++;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment