tapioca.cpp 14.5 KB
Newer Older
1
#include "tapioca.hpp"
Francois Tessier's avatar
Francois Tessier committed
2

Francois Tessier's avatar
Francois Tessier committed
3
Tapioca::Tapioca ()
Francois Tessier's avatar
Francois Tessier committed
4 5 6 7
{
}


Francois Tessier's avatar
Francois Tessier committed
8
Tapioca::~Tapioca ()
Francois Tessier's avatar
Francois Tessier committed
9 10 11 12
{
}


13 14 15 16 17 18 19
void Tapioca::Finalize ()
{
  this->chunksIndexMatching.clear();
  free (this->chunkCount_);
  free (this->chunkSize_);
  free (this->chunkOffset_);
  this->excludedNode.clear();
Francois Tessier's avatar
Francois Tessier committed
20

21 22
  this->commDataSize_ = 0;

23 24
  this->memBuffer0.memFree ();
  this->memBuffer1.memFree ();
25
  MPI_Comm_free (&this->subComm_);
Francois Tessier's avatar
Francois Tessier committed
26 27 28
}


29
void Tapioca::GlobalFence () 
Francois Tessier's avatar
Francois Tessier committed
30 31 32 33 34 35 36 37
{
  int buffer;

  buffer = this->currentRound_ % NBUFFERS;

  switch (buffer)
    {
    case 0:
38
      this->memBuffer0.memFlush ();
Francois Tessier's avatar
Francois Tessier committed
39 40
      break;
    case 1:
41
      this->memBuffer1.memFlush ();
Francois Tessier's avatar
Francois Tessier committed
42 43 44 45 46 47 48 49
      break;
    }
  
#ifdef TIMING
  this->endAggrTime = MPI_Wtime();
  
  if ( this->startAggrTime != 0 ) {
    this->totAggrTime = this->endAggrTime - this->startAggrTime;
50 51
    fprintf (stdout, "[TIMING][AGG][AGGR] Rank %d, Rnd %d - %.2f ms\n",
     	     this->commRank_, this->currentRound_, this->totAggrTime * 1000);
Francois Tessier's avatar
Francois Tessier committed
52
  }
53

Francois Tessier's avatar
Francois Tessier committed
54 55 56 57 58 59 60 61 62
  this->startAggrTime = 0;
#endif

}


/***********************/
/*  INITIALIZATION     */
/***********************/
Francois Tessier's avatar
Francois Tessier committed
63
void Tapioca::SetDefaultValues ()
Francois Tessier's avatar
Francois Tessier committed
64 65 66 67
{
  this->rankDataSize_ = 0;
  this->strategy_ = SHORTEST_PATH;
  this->nAggr_ = 8;
68
  this->bufferSize_ = 16777216;
Francois Tessier's avatar
Francois Tessier committed
69
  this->amAnAggr_ = false;
70
  this->commSplit_ = true;
Francois Tessier's avatar
Francois Tessier committed
71
  this->currentRound_ = 0;
72
  this->totalRounds_ = 0;
73 74
  this->readRound_ = 0;
  this->firstRead_ = false;
Francois Tessier's avatar
Francois Tessier committed
75 76 77
  this->currentDataSize_ = 0;
  this->nCommit_ = 0;
  this->writeDevNull_ = false;
78
  this->pipelinedBuffers_ = true;
Francois Tessier's avatar
Francois Tessier committed
79 80 81
}


Francois Tessier's avatar
Francois Tessier committed
82
void Tapioca::ParseEnvVariables ()
Francois Tessier's avatar
Francois Tessier committed
83
{
84 85 86 87 88
  char *envStrategy   = getenv("TAPIOCA_STRATEGY");
  char *envNAggr      = getenv("TAPIOCA_NBAGGR");
  char *envBufferSize = getenv("TAPIOCA_BUFFERSIZE");
  char *envSplit      = getenv("TAPIOCA_COMMSPLIT");
  char *envDevNull    = getenv("TAPIOCA_DEVNULL");
89
  char *envPipelining = getenv("TAPIOCA_PIPELINING");
Francois Tessier's avatar
Francois Tessier committed
90 91 92 93 94 95 96
  
  if (envStrategy != NULL) {
    strcmp(envStrategy, "SHORTEST_PATH")    ? 0 : this->strategy_ = SHORTEST_PATH;
    strcmp(envStrategy, "LONGEST_PATH")     ? 0 : this->strategy_ = LONGEST_PATH;
    strcmp(envStrategy, "TOPOLOGY_AWARE")   ? 0 : this->strategy_ = TOPOLOGY_AWARE;
    strcmp(envStrategy, "CONTENTION_AWARE") ? 0 : this->strategy_ = CONTENTION_AWARE;
    strcmp(envStrategy, "UNIFORM")          ? 0 : this->strategy_ = UNIFORM;
97
    strcmp(envStrategy, "RANDOM")           ? 0 : this->strategy_ = RANDOM;
Francois Tessier's avatar
Francois Tessier committed
98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116
  }

  if (envNAggr != NULL) {
    this->nAggr_ = atoi(envNAggr);
  }

  if (envBufferSize != NULL) {
    this->bufferSize_ = atoi(envBufferSize);
  }

  if (envSplit != NULL) {
    strcmp(envSplit, "true")  ? 0 : this->commSplit_ = true;
    strcmp(envSplit, "false") ? 0 : this->commSplit_ = false;
  }

  if (envDevNull != NULL) {
    strcmp(envDevNull, "true")  ? 0 : this->writeDevNull_ = true;
    strcmp(envDevNull, "false") ? 0 : this->writeDevNull_ = false;
  }
117 118 119 120 121

  if (envPipelining != NULL) {
    strcmp(envPipelining, "true")  ? 0 : this->pipelinedBuffers_ = true;
    strcmp(envPipelining, "false") ? 0 : this->pipelinedBuffers_ = false;
  }
Francois Tessier's avatar
Francois Tessier committed
122 123 124
}


Francois Tessier's avatar
Francois Tessier committed
125
void Tapioca::SetCommValues ()
Francois Tessier's avatar
Francois Tessier committed
126 127 128 129 130 131 132 133 134
{
  MPI_Comm_rank (this->subComm_, &this->commRank_);
  MPI_Comm_size (this->subComm_, &this->commSize_);
  MPI_Comm_rank (MPI_COMM_WORLD, &this->worldRank_);

  MPI_Allreduce (&this->rankDataSize_, &this->commDataSize_, 1, MPI_LONG_LONG, MPI_SUM, this->subComm_);
}


Francois Tessier's avatar
Francois Tessier committed
135
void Tapioca::SetOffsets ()
Francois Tessier's avatar
Francois Tessier committed
136 137 138 139 140 141 142 143
{
  MPI_Exscan (&this->rankDataSize_, &this->offsetInAggrData_, 1, 
	      MPI_LONG_LONG, MPI_SUM, this->subComm_);
  if (this->commRank_ == 0)
    this->offsetInAggrData_ = 0;
}


Francois Tessier's avatar
Francois Tessier committed
144
void Tapioca::SetNodesList ()
Francois Tessier's avatar
Francois Tessier committed
145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
{
  int *coords, *myCoords, i, worldSize, dimensions;
  
  MPI_Comm_size ( MPI_COMM_WORLD, &worldSize );
  coords = (int *)malloc (worldSize * sizeof (int));

  dimensions = topology.NetworkDimensions () + 1;
  myCoords = (int *)malloc (dimensions * sizeof (int));

  topology.RankToCoordinates (this->worldRank_, myCoords);
  this->intCoords_ = this->CoordsToInt (myCoords, dimensions - 1);
  
  MPI_Allgather(&this->intCoords_, 1, MPI_INT, coords, 1, MPI_INT, MPI_COMM_WORLD);

  for ( i = 0; i < worldSize; i++ )
    this->excludedNode[coords[i]] = false;
161

162 163
  this->nNodes_ = this->excludedNode.size();

164 165
  free (coords);
  free (myCoords);
Francois Tessier's avatar
Francois Tessier committed
166 167 168 169 170 171
}


/***********************/
/*    AGGREGATION      */
/***********************/
Francois Tessier's avatar
Francois Tessier committed
172
int Tapioca::NumberOfAggregators ()
Francois Tessier's avatar
Francois Tessier committed
173 174 175 176 177
{
  return 0;
}


Francois Tessier's avatar
Francois Tessier committed
178
void Tapioca::IdentifyMyAggregators ()
Francois Tessier's avatar
Francois Tessier committed
179
{
180
  int i, j, c, globalRoundId, upperBound, index = 0, nAggr;
Francois Tessier's avatar
Francois Tessier committed
181 182 183
  int64_t remainingData, offsetInAggrData;
  std::vector<Round_t> rounds;
  
184
  this->totalNeededBuffers_  = ceil ( (double)this->commDataSize_ / (double)this->bufferSize_ );
185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205

  /*
   * If we have more aggregators (and buffers) than needed, decrease the number of aggregators
   */
  nAggr = this->nAggr_;
  
  if ( nAggr > this->nNodes_ )
    nAggr = this->nNodes_;
  
  if ( nAggr > this->totalNeededBuffers_ )
    nAggr = this->totalNeededBuffers_;
  
  if ( nAggr != this->nAggr_ ) {
    if ( this->commRank_ == 0 )
      fprintf ( stdout, "[INFO] Number of aggregators decreased from %d to %d\n",
		this->nAggr_, nAggr);
    
    this->nAggr_ = nAggr;      
  }

  this->totalRounds_ = ceil ( (double)this->totalNeededBuffers_ / (double)this->nAggr_ );
Francois Tessier's avatar
Francois Tessier committed
206

207
  for ( i = 0; i < this->totalNeededBuffers_; i++ ) {
Francois Tessier's avatar
Francois Tessier committed
208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239
    Round_t r;
    r.aggr = i % this->nAggr_;
    r.round = i / this->nAggr_;
    rounds.push_back(r);
  }

  for ( c = 0; c < this->nChunks_; c++ ) {
    remainingData    = this->chunkCount_[c] * this->chunkSize_[c];
    offsetInAggrData = this->chunkOffset_[c] - this->offsetInFile_;
    globalRoundId = floor ( offsetInAggrData / this->bufferSize_ );
    upperBound = ( offsetInAggrData % this->bufferSize_ ) + remainingData;
    
    while ( remainingData > 0 ) {
      this->globalAggregatorsRanks.push_back ( rounds[globalRoundId].aggr );
      this->roundsIds.push_back ( rounds[globalRoundId].round );
      this->chunksIndexMatching[c].push_back ( index );
      
      if ( upperBound > this->bufferSize_) {
	remainingData = (upperBound - this->bufferSize_);
	this->dataSize.push_back ( this->chunkCount_[c] * this->chunkSize_[c] - remainingData );
      }
      else {
	this->dataSize.push_back ( remainingData );
	remainingData = 0;
      }
      
      upperBound -= this->bufferSize_;
      globalRoundId++;
      index++;
    }
  }
  
240
#ifdef DBG
Francois Tessier's avatar
Francois Tessier committed
241
  if (this->commRank_ == 4) {
242
    printMsg ( DEBUG, "Rounds distrib. on %d aggregators: AGG ", this->nAggr_);
243
    for ( i = 0; i < this->totalNeededBuffers_; i++ )
Francois Tessier's avatar
Francois Tessier committed
244 245
      fprintf (stdout, "%d ", rounds[i].aggr);
    fprintf (stdout, "\n                                          RND ");
246
    for ( i = 0; i < this->totalNeededBuffers_; i++ )
Francois Tessier's avatar
Francois Tessier committed
247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269
      fprintf (stdout, "%d ", rounds[i].round);
    fprintf (stdout, "\n                                          AGG ");
    for ( i = 0; i < this->globalAggregatorsRanks.size(); i++ )
      fprintf (stdout, "%d ", this->globalAggregatorsRanks[i]);
    fprintf (stdout, "\n                                          RID ");
    for ( i = 0; i < this->roundsIds.size(); i++ )
      fprintf (stdout, "%d ", this->roundsIds[i]);
    fprintf (stdout, "\n                                          DAS ");
    for ( i = 0; i < this->dataSize.size(); i++ )
      fprintf (stdout, "%d ", this->dataSize[i]);
    fprintf (stdout, "\n                                          CIM ");
    for ( i = 0; i < this->chunksIndexMatching.size(); i++ ) {
      fprintf (stdout, "{ ");
      for ( j = 0; j < this->chunksIndexMatching[i].size(); j++ )
	fprintf (stdout, "%d ", this->chunksIndexMatching[i][j]);
      fprintf (stdout, "}");
    }
    fprintf (stdout, "\n");
  }
#endif
}


Francois Tessier's avatar
Francois Tessier committed
270
void Tapioca::ElectAggregators ()
Francois Tessier's avatar
Francois Tessier committed
271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349
{
  int aggr, aggrRank, rankAggrComm, sizeAggrComm, aggrRankAggrComm, i, j, aggrCoords, worldSize;
  int64_t color;
  double startTime, endTime, totTime = 0.0;
  MPI_Comm aggrComm;
  MPI_Request request;
  MPI_Status status;
  /* Groups */
  MPI_Group commGroup, aggrGroup;
  int *ranks, *join, *groupRanks, groupSize, groupRank, joinGroup;

  MPI_Comm_size (MPI_COMM_WORLD, &worldSize);

  this->aggregatorsRanks.resize ( this->globalAggregatorsRanks.size() );
  
  for ( aggr = 0; aggr < this->nAggr_; aggr++ ) {
    color = this->DataSizeSentToAggr (aggr);
    
    startTime = MPI_Wtime();

    if ( this->commSplit_ )
      MPI_Comm_split (this->subComm_, color > 0, this->commRank_, &aggrComm);
    else {
      
      MPI_Comm_group (this->subComm_, &commGroup);

      if ( color > 0 ) {
	joinGroup = 1;
	MPI_Allreduce (&joinGroup, &groupSize, 1, MPI_INT, MPI_SUM, this->subComm_ );
      }
      else {
	joinGroup = 0;
	MPI_Allreduce (&joinGroup, &groupSize, 1, MPI_INT, MPI_SUM, this->subComm_ );
	groupSize = this->commSize_ - groupSize;
      }

      join = (int *)malloc (this->commSize_ * sizeof (int));
      MPI_Allgather(&joinGroup, 1, MPI_INT, join, 1, MPI_INT, this->subComm_);
      groupRanks = (int *)malloc (groupSize * sizeof (int));
      
      j = 0;
      for ( i = 0; i < this->commSize_; i++ ) {
	if (join[i] == joinGroup) {
	  groupRanks[j] = i;
	  j++;
	}
      }

      MPI_Group_incl (commGroup, groupSize, groupRanks, &aggrGroup);
      MPI_Comm_create (this->subComm_, aggrGroup, &aggrComm);
      
      free (join);
      free (groupRanks);
    }
    
    MPI_Comm_rank (aggrComm, &rankAggrComm);
    MPI_Comm_size (aggrComm, &sizeAggrComm);

    endTime = MPI_Wtime();
    totTime += ( endTime - startTime );
    
    if ( color > 0 ) {
      switch ( this->strategy_ )
	{
	case SHORTEST_PATH:
	  aggrRank = this->RankShortestPath (aggrComm, color);
	  break;
	case LONGEST_PATH:
	  aggrRank = this->RankLongestPath (aggrComm, color);
	  break;
	case TOPOLOGY_AWARE:
	  aggrRank = this->RankTopologyAware (aggrComm, color);
	  break;
	case CONTENTION_AWARE:
	  aggrRank = this->RankContentionAware (aggrComm, color);
	  break;
	case UNIFORM:
	  aggrRank = this->RankUniformDistribution (aggrComm, color);
	  break;
350 351 352
	case RANDOM:
	  aggrRank = this->RankRandom (aggrComm, color);
	  break;
Francois Tessier's avatar
Francois Tessier committed
353 354 355 356 357 358 359 360 361 362 363 364 365
	}

      if ( this->commRank_ == aggrRank ) {
	this->totalWrites_     = ceil ( (double)this->aggrDataSize_ / (double)this->bufferSize_);
	this->globalAggrRank_  = aggr;
	aggrCoords             = this->intCoords_;
	MPI_Isend ( &aggrCoords, 1, MPI_INT, 0, 0, MPI_COMM_WORLD, &request );
      }

      for ( i = 0; i < this->aggregatorsRanks.size(); i++ )
	if ( this->globalAggregatorsRanks[i] == aggr )
	  this->aggregatorsRanks[i] = aggrRank;

366
#ifdef DBG
Francois Tessier's avatar
Francois Tessier committed
367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392
      int coords[topology.NetworkDimensions() + 1];
      if ( this->commRank_ == aggrRank ) {
	topology.RankToCoordinates (this->worldRank_, coords);
	fprintf (stdout, "[DEBUG] AggRank %d, (", this->worldRank_);
	for ( i = 0; i < topology.NetworkDimensions() + 1; i++ )
	  fprintf (stdout, "%u ", coords[i]);
	fprintf (stdout, ") -> %d, part %d, %lld B from %d ranks, %d rounds\n",
		 this->intCoords_, topology.BridgeNodeId(), this->aggrDataSize_, sizeAggrComm, this->totalWrites_);
      }
#endif
    }

    /*
     *  TODO: Compute this... 
     *              - Vesta: 16 nodes/bridge node
     *              - Mira : 64 nodes/bridge node
     */
    for ( i = 0; i < ( (worldSize / topology.ProcessPerNode ()) / (this->commSize_ / topology.ProcessPerNode ()) ); i++ ) {
      if ( this->worldRank_ == 0 )
	MPI_Recv ( &aggrCoords, 1, MPI_INT, MPI_ANY_SOURCE, 0, MPI_COMM_WORLD, &status );
      
      MPI_Bcast ( &aggrCoords, 1, MPI_INT, 0, MPI_COMM_WORLD);
      this->excludedNode[aggrCoords] = true;
    }
  }

Francois Tessier's avatar
Francois Tessier committed
393
#ifdef TIMING
Francois Tessier's avatar
Francois Tessier committed
394
  this->PrintTime( 0, totTime, " |-> Create subcommunicator");
Francois Tessier's avatar
Francois Tessier committed
395
#endif
Francois Tessier's avatar
Francois Tessier committed
396 397 398
}


Francois Tessier's avatar
Francois Tessier committed
399
int64_t Tapioca::DataSizeSentToAggr (int aggrId)
Francois Tessier's avatar
Francois Tessier committed
400 401 402 403 404 405 406 407 408 409 410 411
{
  int i;
  int64_t dataSize = 0;

  for ( i = 0; i < this->aggregatorsRanks.size(); i++ )
    if ( this->globalAggregatorsRanks[i] == aggrId )
      dataSize += this->dataSize[i];

  return dataSize;
}


Francois Tessier's avatar
Francois Tessier committed
412
void Tapioca::InitAggregators () 
Francois Tessier's avatar
Francois Tessier committed
413 414 415
{
  int aggr, retval;
  
416 417
  this->memBuffer0.memAlloc ( this->bufferSize_, HBM, this->amAnAggr_, "", this->subComm_ );
  this->memBuffer1.memAlloc ( this->bufferSize_, HBM, this->amAnAggr_, "", this->subComm_ );
Francois Tessier's avatar
Francois Tessier committed
418

419
#ifdef DBG
Francois Tessier's avatar
Francois Tessier committed
420 421 422 423 424 425 426 427
  if (this->commRank_ == MASTER) {
    fprintf (stdout, "[DEBUG] %d RMA windows created (%d aggr., %d buffers)\n", 
	     NBUFFERS, this->nAggr_, NBUFFERS);
  }
#endif
}


Francois Tessier's avatar
Francois Tessier committed
428
int Tapioca::CoordsToInt (int *coords, int dim)
Francois Tessier's avatar
Francois Tessier committed
429 430 431 432 433 434 435 436 437 438 439 440
{
  int i, res = 0;

  for ( i = 0; i < dim; i++ )
    res += coords[i] * pow (10.0, (double)i);

  return res;
}

/***********************/
/*        MISC.        */
/***********************/
Francois Tessier's avatar
Francois Tessier committed
441
const char* Tapioca::getStrategyName ()
Francois Tessier's avatar
Francois Tessier committed
442 443 444 445 446 447 448 449
{
  switch (this->strategy_)
    {
    case SHORTEST_PATH:    return "Shortest path";
    case LONGEST_PATH:     return "Longest path";
    case TOPOLOGY_AWARE:   return "Topology-aware placement";
    case CONTENTION_AWARE: return "Contention-aware placement";
    case UNIFORM:          return "Uniform placement";
450
    case RANDOM :          return "Random placement";
Francois Tessier's avatar
Francois Tessier committed
451 452 453 454 455
    default:               return "No placement strategy defined!";
    }
}


Francois Tessier's avatar
Francois Tessier committed
456
void Tapioca::HandleMPIError (int retval) 
Francois Tessier's avatar
Francois Tessier committed
457
{
458
#ifdef DBG
Francois Tessier's avatar
Francois Tessier committed
459 460 461 462
  char msg[MPI_MAX_ERROR_STRING];
  int resultlen;
  if (retval != MPI_SUCCESS) {
    MPI_Error_string(retval, msg, &resultlen);
463
    fprintf(stderr, "[ERR] %s\n", msg);
Francois Tessier's avatar
Francois Tessier committed
464 465 466 467 468 469 470
  }
#endif

  return;
}


Francois Tessier's avatar
Francois Tessier committed
471
void Tapioca::PrintTime ( double startTime, double endTime, char* func )
Francois Tessier's avatar
Francois Tessier committed
472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491
{
  double totTime, avgTime, minTime, maxTime;
  int commSize, commRank;
  
  MPI_Comm_rank(MPI_COMM_WORLD, &commRank);
  MPI_Comm_size(MPI_COMM_WORLD, &commSize);
  
  totTime = endTime - startTime;
  totTime = totTime * 1000;
  MPI_Reduce(&totTime, &avgTime, 1, MPI_DOUBLE, MPI_SUM, 0, MPI_COMM_WORLD);
  MPI_Reduce(&totTime, &maxTime, 1, MPI_DOUBLE, MPI_MAX, 0, MPI_COMM_WORLD);
  MPI_Reduce(&totTime, &minTime, 1, MPI_DOUBLE, MPI_MIN, 0, MPI_COMM_WORLD);
  if (commRank == 0) {
    avgTime = avgTime / commSize;
    fprintf (stdout, "[TIMING][AGG] %s: %.2f ms [%.2f ; %.2f]\n",
             func, avgTime, minTime, maxTime);
  }
}


Francois Tessier's avatar
Francois Tessier committed
492
void Tapioca::MPIIOInfo ( MPI_File fileHandle )
Francois Tessier's avatar
Francois Tessier committed
493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518
{
  MPI_Info info;
  int flag;
  char value[1024];

  if ( this->worldRank_ == 0 ) {
    MPI_File_get_info ( fileHandle, &info );
    
    fprintf ( stdout, "[INFO] MPI Two-phases I/O\n");
    
    MPI_Info_get ( info, "cb_buffer_size", 1024, value, &flag );
    fprintf ( stdout, "[INFO] cb_buffer_size = %s\n", value );
    
    MPI_Info_get ( info, "cb_nodes", 1024, value, &flag );
    fprintf ( stdout, "[INFO] cb_nodes = %s\n", value );

    MPI_Info_get ( info, "romio_cb_read", 1024, value, &flag );
    fprintf ( stdout, "[INFO] romio_cb_read = %s\n", value );
    
    MPI_Info_get ( info, "romio_cb_write", 1024, value, &flag );
    fprintf ( stdout, "[INFO] romio_cb_write = %s\n", value );
    
    MPI_Info_get ( info, "romio_no_indep_rw", 1024, value, &flag );
    fprintf ( stdout, "[INFO] romio_no_indep_rw = %s\n", value );
  }
}