Commit fae57be9 authored by Philip Carns's avatar Philip Carns
Browse files

experimental performance calculation fix: if files are partially shared,

then don't count the cumulative time for a file when computing the
slowest rank time


git-svn-id: https://svn.mcs.anl.gov/repos/darshan/trunk@399 3b7491f3-a168-0410-bf4b-c445ed680a29
parent bd5863f0
...@@ -775,21 +775,38 @@ void accum_perf(struct darshan_file *dfile, ...@@ -775,21 +775,38 @@ void accum_perf(struct darshan_file *dfile,
{ {
if (mpi_file) if (mpi_file)
{ {
#if 0
hfile->cumul_time += dfile->fcounters[CP_F_MPI_META_TIME] + hfile->cumul_time += dfile->fcounters[CP_F_MPI_META_TIME] +
dfile->fcounters[CP_F_MPI_READ_TIME] + dfile->fcounters[CP_F_MPI_READ_TIME] +
dfile->fcounters[CP_F_MPI_WRITE_TIME]; dfile->fcounters[CP_F_MPI_WRITE_TIME];
hfile->meta_time += dfile->fcounters[CP_F_MPI_META_TIME]; hfile->meta_time += dfile->fcounters[CP_F_MPI_META_TIME];
#else
pdata->rank_cumul_io_time[dfile->rank] += dfile->fcounters[CP_F_MPI_META_TIME] +
dfile->fcounters[CP_F_MPI_READ_TIME] +
dfile->fcounters[CP_F_MPI_WRITE_TIME];
pdata->rank_cumul_md_time[dfile->rank] += dfile->fcounters[CP_F_MPI_META_TIME];
#endif
} }
else else
{ {
#if 0
hfile->cumul_time += dfile->fcounters[CP_F_POSIX_META_TIME] + hfile->cumul_time += dfile->fcounters[CP_F_POSIX_META_TIME] +
dfile->fcounters[CP_F_POSIX_READ_TIME] + dfile->fcounters[CP_F_POSIX_READ_TIME] +
dfile->fcounters[CP_F_POSIX_WRITE_TIME]; dfile->fcounters[CP_F_POSIX_WRITE_TIME];
hfile->meta_time += dfile->fcounters[CP_F_POSIX_META_TIME]; hfile->meta_time += dfile->fcounters[CP_F_POSIX_META_TIME];
#else
pdata->rank_cumul_io_time[dfile->rank] += dfile->fcounters[CP_F_POSIX_META_TIME] +
dfile->fcounters[CP_F_POSIX_READ_TIME] +
dfile->fcounters[CP_F_POSIX_WRITE_TIME];
pdata->rank_cumul_md_time[dfile->rank] += dfile->fcounters[CP_F_POSIX_META_TIME];
#endif
} }
#if 0
pdata->rank_cumul_io_time[dfile->rank] += hfile->cumul_time; pdata->rank_cumul_io_time[dfile->rank] += hfile->cumul_time;
pdata->rank_cumul_md_time[dfile->rank] += hfile->meta_time; pdata->rank_cumul_md_time[dfile->rank] += hfile->meta_time;
#endif
} }
return; return;
...@@ -811,6 +828,7 @@ void calc_perf(struct darshan_job *djob, ...@@ -811,6 +828,7 @@ void calc_perf(struct darshan_job *djob,
if (pdata->rank_cumul_io_time[i] > pdata->slowest_rank_time) if (pdata->rank_cumul_io_time[i] > pdata->slowest_rank_time)
{ {
pdata->slowest_rank_time = pdata->rank_cumul_io_time[i]; pdata->slowest_rank_time = pdata->rank_cumul_io_time[i];
pdata->slowest_rank_meta_time = pdata->rank_cumul_md_time[i];
} }
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment