Commit ce78d6b2 authored by Tyler Reddy's avatar Tyler Reddy
Browse files

MAINT: rm pass statements

* `darshan/report.py` contains many pointless `pass`
statements; they may have served a placeholding purpose
early in development, but they are no longer of any use
so remove them
parent 65ff2d3f
...@@ -66,7 +66,6 @@ class DarshanRecordCollection(collections.abc.MutableSequence): ...@@ -66,7 +66,6 @@ class DarshanRecordCollection(collections.abc.MutableSequence):
self._type = "collection" # collection => list(), single => [record], nested => [[], ... ,[]] self._type = "collection" # collection => list(), single => [record], nested => [[], ... ,[]]
self._records = list() # internal format before user conversion self._records = list() # internal format before user conversion
pass
def __len__(self): def __len__(self):
return len(self._records) return len(self._records)
...@@ -224,7 +223,6 @@ class DarshanRecordCollection(collections.abc.MutableSequence): ...@@ -224,7 +223,6 @@ class DarshanRecordCollection(collections.abc.MutableSequence):
elif mod in ['DXT_POSIX', 'DXT_MPIIO']: elif mod in ['DXT_POSIX', 'DXT_MPIIO']:
# format already in a dict format, but may offer switches for expansion # format already in a dict format, but may offer switches for expansion
logger.warn("WARNING: The output of DarshanRecordCollection.to_dict() may change in the future.") logger.warn("WARNING: The output of DarshanRecordCollection.to_dict() may change in the future.")
pass
else: else:
for i, rec in enumerate(records): for i, rec in enumerate(records):
rec['counters'] = dict(zip(counters['counters'], rec['counters'])) rec['counters'] = dict(zip(counters['counters'], rec['counters']))
...@@ -544,7 +542,6 @@ class DarshanReport(object): ...@@ -544,7 +542,6 @@ class DarshanReport(object):
for mod in self.data['modules']: for mod in self.data['modules']:
self.mod_read_all_records(mod, dtype=dtype, warnings=False) self.mod_read_all_records(mod, dtype=dtype, warnings=False)
pass
def read_all_dxt_records(self, reads=True, writes=True, dtype=None): def read_all_dxt_records(self, reads=True, writes=True, dtype=None):
...@@ -563,7 +560,6 @@ class DarshanReport(object): ...@@ -563,7 +560,6 @@ class DarshanReport(object):
for mod in self.data['modules']: for mod in self.data['modules']:
self.mod_read_all_dxt_records(mod, warnings=False, reads=reads, writes=writes, dtype=dtype) self.mod_read_all_dxt_records(mod, warnings=False, reads=reads, writes=writes, dtype=dtype)
pass
def mod_read_all_records(self, mod, dtype=None, warnings=True): def mod_read_all_records(self, mod, dtype=None, warnings=True):
...@@ -643,7 +639,6 @@ class DarshanReport(object): ...@@ -643,7 +639,6 @@ class DarshanReport(object):
'fcounters': combined_fc 'fcounters': combined_fc
}] }]
pass
def mod_read_all_apmpi_records(self, mod, dtype=None, warnings=True): def mod_read_all_apmpi_records(self, mod, dtype=None, warnings=True):
""" """
...@@ -694,7 +689,6 @@ class DarshanReport(object): ...@@ -694,7 +689,6 @@ class DarshanReport(object):
if self.lookup_name_records: if self.lookup_name_records:
self.update_name_records() self.update_name_records()
pass
def mod_read_all_apxc_records(self, mod, dtype=None, warnings=True): def mod_read_all_apxc_records(self, mod, dtype=None, warnings=True):
""" """
...@@ -744,7 +738,6 @@ class DarshanReport(object): ...@@ -744,7 +738,6 @@ class DarshanReport(object):
if self.lookup_name_records: if self.lookup_name_records:
self.update_name_records() self.update_name_records()
pass
def mod_read_all_dxt_records(self, mod, dtype=None, warnings=True, reads=True, writes=True): def mod_read_all_dxt_records(self, mod, dtype=None, warnings=True, reads=True, writes=True):
""" """
...@@ -798,7 +791,6 @@ class DarshanReport(object): ...@@ -798,7 +791,6 @@ class DarshanReport(object):
if self.lookup_name_records: if self.lookup_name_records:
self.update_name_records() self.update_name_records()
pass
...@@ -877,7 +869,6 @@ class DarshanReport(object): ...@@ -877,7 +869,6 @@ class DarshanReport(object):
'counters': combined_c, 'counters': combined_c,
}] }]
pass
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment