Commit ace2260c authored by Philip Carns's avatar Philip Carns

fix segfault in common val counters

parent 8a6a35b0
...@@ -10,6 +10,9 @@ Darshan-3.1.3-pre1 ...@@ -10,6 +10,9 @@ Darshan-3.1.3-pre1
* skip instrumentation attempts for anonymous mmap() calls; this avoids a * skip instrumentation attempts for anonymous mmap() calls; this avoids a
potentential deadlock condition when used with hugepages on Cray systems. potentential deadlock condition when used with hugepages on Cray systems.
Reported by Glenn Lockwood and Cristian Simarro. Reported by Glenn Lockwood and Cristian Simarro.
* fix segmentation fault in statistics collection for applications that issue
operations with a large number of distince access sizes or strides on the
same file. Reported by Glenn Lockwood.
Darshan-3.1.2 Darshan-3.1.2
============= =============
......
...@@ -267,9 +267,13 @@ void darshan_common_val_counter(void **common_val_root, int *common_val_count, ...@@ -267,9 +267,13 @@ void darshan_common_val_counter(void **common_val_root, int *common_val_count,
(*common_val_count)++; (*common_val_count)++;
} }
/* update common access counters as we go */ /* update common access counters as we go, as long as we haven't already
DARSHAN_COMMON_VAL_COUNTER_INC(common_val_p, common_cnt_p, * hit the limit in the number we are willing to track */
found->val, found->freq, 1); if(found)
{
DARSHAN_COMMON_VAL_COUNTER_INC(common_val_p, common_cnt_p,
found->val, found->freq, 1);
}
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment