From 5e1a0963a498aebfa583d4b653561f1fd29c6b59 Mon Sep 17 00:00:00 2001 From: Shane Snyder Date: Mon, 16 May 2016 14:20:38 -0500 Subject: [PATCH] bug fix in agg_perf_by_slowest perf calculation this calculation was inadvertently accounting for metadata time twice. also, clarified timing descriptions for slowest unique file perf calculations. --- darshan-util/darshan-parser.c | 3 +-- darshan-util/doc/darshan-util.txt | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/darshan-util/darshan-parser.c b/darshan-util/darshan-parser.c index ffd338c..5112d92 100644 --- a/darshan-util/darshan-parser.c +++ b/darshan-util/darshan-parser.c @@ -558,7 +558,7 @@ int main(int argc, char **argv) printf("# I/O timing for unique files (seconds):\n"); printf("# ...........................\n"); printf("# unique files: slowest_rank_io_time: %lf\n", pdata.slowest_rank_time); - printf("# unique files: slowest_rank_meta_time: %lf\n", pdata.slowest_rank_meta_time); + printf("# unique files: slowest_rank_meta_only_time: %lf\n", pdata.slowest_rank_meta_time); printf("# unique files: slowest rank: %d\n", pdata.slowest_rank_rank); printf("#\n"); printf("# I/O timing for shared files (seconds):\n"); @@ -1350,7 +1350,6 @@ void calc_perf(perf_data_t *pdata, if (pdata->slowest_rank_time + pdata->shared_time_by_slowest) pdata->agg_perf_by_slowest = ((double)pdata->total_bytes / 1048576.0) / (pdata->slowest_rank_time + - pdata->slowest_rank_meta_time + pdata->shared_time_by_slowest); return; diff --git a/darshan-util/doc/darshan-util.txt b/darshan-util/doc/darshan-util.txt index 53cb886..576fb48 100644 --- a/darshan-util/doc/darshan-util.txt +++ b/darshan-util/doc/darshan-util.txt @@ -394,7 +394,7 @@ Job performance information can be generated using the `--perf` command-line opt # I/O timing for unique files (seconds): # ........................... # unique files: slowest_rank_io_time: 0.000000 -# unique files: slowest_rank_meta_time: 0.000000 +# unique files: slowest_rank_meta_only_time: 0.000000 # unique files: slowest_rank: 0 # # I/O timing for shared files (seconds): @@ -430,7 +430,7 @@ type of file access. * unique files: slowest_rank_io_time: total I/O time for unique files (including both metadata + data transfer time) -* unique files: slowest_rank_meta_time: metadata time for unique files +* unique files: slowest_rank_meta_only_time: metadata time for unique files * unique files: slowest_rank: the rank of the slowest process .I/O timing for shared files -- 2.26.2