Commit 8516435a authored by Swann Perarnau's avatar Swann Perarnau

[fix] remove unused pipe in subprocess

For some reason this seems to be triggering a leak of a open file
descriptor, even though it should be garbage collected.

As for why it's there...well there was a time when I had hoped of
implementing support for stdin.
parent 0d73d31b
Pipeline #5103 failed with stages
in 5 minutes and 34 seconds
...@@ -248,7 +248,7 @@ class DummyRuntime(ContainerRuntime): ...@@ -248,7 +248,7 @@ class DummyRuntime(ContainerRuntime):
def execute(self, container_uuid, args, environ): def execute(self, container_uuid, args, environ):
import tornado.process as process import tornado.process as process
return process.Subprocess(args, stdin=process.Subprocess.STREAM, return process.Subprocess(args,
stdout=process.Subprocess.STREAM, stdout=process.Subprocess.STREAM,
stderr=process.Subprocess.STREAM, stderr=process.Subprocess.STREAM,
env=environ) env=environ)
......
...@@ -118,7 +118,7 @@ class NodeOSClient(object): ...@@ -118,7 +118,7 @@ class NodeOSClient(object):
for envname, envval in environ.items()] for envname, envval in environ.items()]
cmd += " env:'"+" ".join(env)+"'" cmd += " env:'"+" ".join(env)+"'"
args.append(cmd) args.append(cmd)
return process.Subprocess(args, stdin=process.Subprocess.STREAM, return process.Subprocess(args,
stdout=process.Subprocess.STREAM, stdout=process.Subprocess.STREAM,
stderr=process.Subprocess.STREAM) stderr=process.Subprocess.STREAM)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment