Valentin Reis authored Feb 12, 2019 and Swann Perarnau committed Feb 25, 2019

close_fds only defaults to true on python 3, leading to leaking open
file descriptors every time we fork a process.

[doc] Removes mention of Nix in the README.md file.

See merge request !67

That is too much of a development workflow and shouldn't appear
on the landing page.

[ci] fix typo: gitlab-ci file should point to argopkgs master.

See merge request !66

Add License to repository

See merge request !63

This commit simplifies greatly the CI logic and improves its
maintability. argopkgs/master becomes the single maintained
authoritative soure of content for CI and packaging.

BSD3, as discussed.

[fix] Resolve open files leaks

See merge request !57

The nix-env used for CI is being poluted by gitlab CI environ variables,
which ends up crashing argo_nodeos_config.

The real fix would be probably involve figuring out what kind of env
variable value crashes the whole thing and fixing our wrapping logic,
but at the same time, there's no reason for nix to use the CI env in the
first place.

This also resets the CI pointers to 'base'/'basic.yaml'.

[ci] stylechecks should pass first

See merge request !59

Reorder the CI pipeline to style check first, so that we don't wait for
the entire integration tests before failing on code formatting.

For some reason this seems to be triggering a leak of a open file
descriptor, even though it should be garbage collected.

As for why it's there...well there was a time when I had hoped of
implementing support for stdin.

pyzmq recommends the use of a single context for all objects in the same
application:
https://pyzmq.readthedocs.io/en/latest/api/zmq.html#zmq.Context.instance

More importantly, each context creates at least one thread, resulting in
a lot of threads with a lot of open file descriptors. This path reduces
that number by quite a bit.

Code refactoring in Container management

See merge request !54

Add a container runtime that doesn't create containers, but can still
launch commands.

That should make it possible, once we figure out how to change it in the
configuration, to actually run the NRM without a setuid binary.

Extract the container runtime interface from the container manager, and
use a hierarchy of classes to enforce a runtime interface that makes
sense.

This will allow us to create alternative runtime implementations without
major changes to the container manager code.

Missing checks in aci resulted in features absent from the manifest to
be counted as enabled.

Just to make it easy to debug binding issues.

!27 replaced the resource field of the `container` named tuple by a
dictionary. Restore the old type, a `resources` named tuple and make
sure to propagate this across all the code.

Refactor the container creation code to isolate the building/retrieving
of a container namedtuple out of the core container creation code.

This simplifies quite a bit the different branches of this code, and
makes the core create method almost entirely dedicated to just launching
a command.

Some of these commands prefix were in a bit of a weird order. In
particular, it makes sense to have perfwrapper at the end.

!27 caused the perfwrapper to only be activated for the command that
creates a container, and never for the other commands launched in an
already running container. This patch restore this feature.

The container creation code was starting to repeat the same logic for
testing that a container manifest was enabling a specific feature.

Instead we add a method to the image manifest to check for that.
Also adds tests for that feature.

Bump CI.

See merge request !56

Refactors Nix code to be even simpler.

See merge request !53

nix-shell -A nrm for a nrm development environment.
nix-shell -A test for an versioned integration test environment.
nix-build -A <tab> to build a package from the versioned test environment.
nix-shell -A <tab> for other shell options.
nix-build -A <tab> for other build options.

Resolve "Tests are too permissive -> master broken"

Closes #28

See merge request !52

The last merge changed the API visual style to increase readability.

The manual merging was not done in a proper way however, and some of the
changes from its previous merges were reverted. This commit fixes this.

[refactor] messaging code style + cmd_listen application_uuid relaxing

See merge request !48

container.

This commit does two things:
- re-indents the message schema to be more readable
- lets `cmd listen --filter` print any incoming message, without
discriminating on container_uuid. This makes cmd listen usable until
a proper application_uuid management is written into nrm.

[fix] stylecheck issues

See merge request !50

Some inconsistencies in the CI let a merge request go through without
stylechecking.

[ci] Removes branch filtering based on `wip-*`.

See merge request !49