- 21 Dec, 2017 1 commit
-
-
Swann Perarnau authored
Recent work has added and renamed binaries to the repository. This patch syncs the setup.py file to match the current state. This fixes missing binaries from path inside virtual environments.
-
- 20 Dec, 2017 6 commits
-
-
Swann Perarnau authored
Implement control loop See merge request !12
-
Swann Perarnau authored
Change the PowerActuator to be able to lower the power limit. Because RAPL doesn't provide an actual lower limit, we use 0 as the minimal power.
-
Swann Perarnau authored
This patch adds a poweractuator based on rapl settings available through the sensor manager. Adding this actuator forces us to use a list of actuators in the controller, changing a bit the structure of the code.
-
Swann Perarnau authored
-
Swann Perarnau authored
This patch introduce one more level of abstraction to the controller: an actuator. Actuators will act as the middleman between specific managers and the controller, while providing enough info to implement actual models on top. For now, we only have the application threads actuator.
-
Swann Perarnau authored
Initial support for perf wrapper See merge request !11
-
- 19 Dec, 2017 12 commits
-
-
Kamil Iskra authored
-
Kamil Iskra authored
-
Swann Perarnau authored
The "control" part of the NRM is bound to change and become more complex in the near future, so move it in its own module. This refactor also introduce some controller logic. Control is split into 3 steps: planning, execution and updates. The goal is to use this new code organization as a way to abstract different control policies that could be implemented later. Note that we might at some point move into a "control manager" and a bunch of "policies" and "actuators", as a way of matching typical control theory vocabulary.
-
Kamil Iskra authored
-
Swann Perarnau authored
Small things like spacing and extra semicolon. It is also recommended to use the 0o notation for octal, as a way to make them stand out in the code.
-
Kamil Iskra authored
-
Swann Perarnau authored
Bugfixes for recently implemented features See merge request !10
-
Swann Perarnau authored
Fixes a copy/paste mistake on the name of the callback to trigger on stderr events.
-
Swann Perarnau authored
This patch fixes the daemon code to include the container uuid in the environment of the command, while changing that environment variable to use a better suited name.
-
Swann Perarnau authored
Improve the downstream API See merge request !9
-
Swann Perarnau authored
This patch replace the client code (bin/client and nrm/client) by a new application code that integrates progress reports and uses the new downstream API. While git is reporting that both codes are different, the app code is basically a refactoring and adaptation of the client code. This is directly related to issue #2.
-
Swann Perarnau authored
This patch moves the tracking of applications clients of the downstream API into a ApplicationManager, that is able to track progress and thread management. This change is necessary in the long term to build a comprehensive downstream API and centralize the management of application tracking. Note that this tracking is currently independent of the container and pid tracking, and that might be a problem in the long term.
-
- 18 Dec, 2017 6 commits
-
-
Swann Perarnau authored
This patch refactors the downstream API to use pub/sub socket pair, like the upstream API. This is part of the effort to improve the downstream API. See #2. This patch doesn't touch the client module, which will be adapted in future commits.
-
Swann Perarnau authored
Fix upstream publishers messaging issues See merge request !8
-
Swann Perarnau authored
The way 0MQ works on PUB/SUB sockets, publishers might drop messages if subscribers are not detected faster enough. One way to fix it is to have the "server" always bind sockets, and the "client" use connect. This way, the handshake is initiated properly, and the client can publish as soon as the connection is done. This patch makes the daemon bind on the upstream API and the CLI connect, fixing in the process the message dropping we were experiencing before. Long term, we might have a think of using 2 types of sockets for the upstream API: pub/sub for actual events published from the daemon, and a REQ/REP or ROUTER/DEALER pair for "commands".
-
Swann Perarnau authored
Fix recent coolr issues and start building tests for it See merge request !7
-
Swann Perarnau authored
This patch adds a test for the nrm/coolr/clr_rapl.py code, based on the __main__ code added to it recently. This is an example of how the modules should be tested automatically, instead of relying on __main__ snippets everywhere. We should replace those snippets bits by bits by tests similar to this one. The end goal is to able to active a gitlab pipeline that validate merge requests automatically.
-
Swann Perarnau authored
Previous commit 0c93ce6a broke the sample code used by the daemon, by reverting the sample function to a json message generator. This is due to inconsistencies between the coolr code and the NRM import: we removed json generation from coolr, to push it on the messaging side, while upstream still does it on sensor reading. This commit fixes that, but doesn't touch the new test code embedded in clr_rapl.py We will move that the test infrastructure later.
-
- 17 Dec, 2017 1 commit
-
-
Kazutomo Yoshii authored
-
- 15 Dec, 2017 3 commits
-
-
Swann Perarnau authored
Switch to subprocess See merge request !6
-
Swann Perarnau authored
This patch implements a small finite state machine on the cmd side to be able to run a command, wait for all of its output, and then exit. As the daemon can send those message in any order, we need to wait them properly, in particular the closing of stdout/stderr before exiting. This patch also fixes the read_until_close callback creation to ensure that the stream EOF is handled as a distinct message.
-
Swann Perarnau authored
The daemon code was maintaining its own container tracker using pids, instead of using the one in the container manager. This patch removes this additional tracking, and let the daemon side deal with an actual namedtuple.
-
- 14 Dec, 2017 10 commits
-
-
Swann Perarnau authored
This patch adds stdout/stderr streaming capabilities, based on partial evaluation of a tornado.iostream callback. The bin/cmd CLI is updated to wait until an exit message, although that doesn't guaranty anything on message ordering... The next step is obviously to figure out a message flow that allows the CLI to send and receive the command IO properly, in order...
-
Swann Perarnau authored
This patch propagates the process object into the container namedtuple, fix a couple of bad function calls and adapt the run command handler to use that process object instead of just the pid of it.
-
Swann Perarnau authored
Use the new argo_nodeos_config --exec feature in development. Allow us to delegate fork+attach+exec to argo_nodeos_config, and simplifying the create command as a result. We use tornado.process to wrap this command, as we want to able to stream stdout/stderr in the future. This patch also misuse, the 'pid' field of the container namedtuple to save the tornado.process.Subprocess object itself, so some functions need to be adapted.
-
Swann Perarnau authored
The logging improvement patch missed a few calls.
-
Swann Perarnau authored
Code cleanup improvements See merge request !5
-
Swann Perarnau authored
# Conflicts: # nrm/containers.py
-
Swann Perarnau authored
Remove unused import, commas at the end of dictionaries.
-
Swann Perarnau authored
The logging module allow us to configure logging facilities once per process using basicConfig, and then to use globally defined, named, logger objects. This simplifies access to logger objects, their configuration and remove pointers from all objects. This patch refactor all the logging calls to use a single 'nrm' logger object, using those facilities.
-
Swann Perarnau authored
Add more container commands See merge request !4
-
Swann Perarnau authored
Implement an update allocation function to be able to update resource tracking when containers are created and deleted. The commit should make it easier to improve the resource manager later on.
-
- 13 Dec, 2017 1 commit
-
-
Swann Perarnau authored
This patch adds a command to kill the parent process of a container based on the container uuid, triggering the death of the container. The os.kill command interacts pretty badly with the custom built children handling, causing us to catch unwanted exceptions in an effort to keep the code running. The waitpid code was also missing a bit about catching children exiting because of signals, so we fixed that. At this point, two things should be paid attention to: - we don't distinguish properly between a container and a command. This will probably cause issues later, as it should be possible to launch multiple programs in the same container, and for partitions to survive the death of the parent process. - the message format is growing more complex, but without any component having strong ownership over it. This will probably cause stability issues in the long term, as the format complexifies and we lose track of the fields expected from everyone.
-