GitLab

Resolve "`cmd run` SIGTERM handling"

Closes #46

See merge request !79

[code quality] adds flake8 tests to /bin

See merge request !74

Deal with connection issues

See merge request !71

high-water marks, the mechanism used by zmq to avoid buffer bloat and
start dropping messages, has been causing all sorts of problems. Set all
of them to `infinite`, to avoid these issues.

Note that the recent changes seems to cause the messaging tests to
block, so we disable them for now.

Change the `wait_connected` method to a `connect` method with an
optional wait. Ensure that the actual connect call on the socket is done
after the monitor is created, otherwise the monitor might miss the
connection event.

[feature] Adds --verbose argument to the daemon.

See merge request !73

[fix] Fixes ratelimit reading from manifest file.

See merge request !72

[feature] change libnrm ratelimit in manifest

See merge request !70

Add a "monitoring" section to the manifest, that allows users to modify
libnrm through environment variables.

[ci] Adds Applications to the gitlab CI pipeline.

See merge request !69

Cleanup open file descriptors on forks

See merge request !61

Valentin Reis authored Feb 12, 2019 and Swann Perarnau committed Feb 25, 2019

close_fds only defaults to true on python 3, leading to leaking open
file descriptors every time we fork a process.

[doc] Removes mention of Nix in the README.md file.

See merge request !67

That is too much of a development workflow and shouldn't appear
on the landing page.

[ci] fix typo: gitlab-ci file should point to argopkgs master.

See merge request !66

Add License to repository

See merge request !63

This commit simplifies greatly the CI logic and improves its
maintability. argopkgs/master becomes the single maintained
authoritative soure of content for CI and packaging.

BSD3, as discussed.

[fix] Resolve open files leaks

See merge request !57

The nix-env used for CI is being poluted by gitlab CI environ variables,
which ends up crashing argo_nodeos_config.

The real fix would be probably involve figuring out what kind of env
variable value crashes the whole thing and fixing our wrapping logic,
but at the same time, there's no reason for nix to use the CI env in the
first place.

This also resets the CI pointers to 'base'/'basic.yaml'.

[ci] stylechecks should pass first

See merge request !59

Reorder the CI pipeline to style check first, so that we don't wait for
the entire integration tests before failing on code formatting.

For some reason this seems to be triggering a leak of a open file
descriptor, even though it should be garbage collected.

As for why it's there...well there was a time when I had hoped of
implementing support for stdin.

pyzmq recommends the use of a single context for all objects in the same
application:
https://pyzmq.readthedocs.io/en/latest/api/zmq.html#zmq.Context.instance

More importantly, each context creates at least one thread, resulting in
a lot of threads with a lot of open file descriptors. This path reduces
that number by quite a bit.

Code refactoring in Container management

See merge request !54

Add a container runtime that doesn't create containers, but can still
launch commands.

That should make it possible, once we figure out how to change it in the
configuration, to actually run the NRM without a setuid binary.

Extract the container runtime interface from the container manager, and
use a hierarchy of classes to enforce a runtime interface that makes
sense.

This will allow us to create alternative runtime implementations without
major changes to the container manager code.

Missing checks in aci resulted in features absent from the manifest to
be counted as enabled.

Just to make it easy to debug binding issues.

!27 replaced the resource field of the `container` named tuple by a
dictionary. Restore the old type, a `resources` named tuple and make
sure to propagate this across all the code.

Refactor the container creation code to isolate the building/retrieving
of a container namedtuple out of the core container creation code.

This simplifies quite a bit the different branches of this code, and
makes the core create method almost entirely dedicated to just launching
a command.

Some of these commands prefix were in a bit of a weird order. In
particular, it makes sense to have perfwrapper at the end.