Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
argo
cuttr
Commits
ff5858b2
Commit
ff5858b2
authored
Oct 02, 2018
by
Alexis Janon
Browse files
"TODO" commens cleanup
parent
2ea286a9
Pipeline
#4085
failed with stage
in 2 minutes and 24 seconds
Changes
5
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
src/configuration/sysfscontroller.rs
View file @
ff5858b2
...
...
@@ -47,7 +47,6 @@ impl SysFsControllerList {
}
pub
fn
find_path
(
&
self
,
slice
:
&
str
,
key
:
&
str
)
->
Result
<
path
::
PathBuf
>
{
// TODO: check that the path is still in an authorized sysfs
let
mut
path_list
=
self
.values
()
.map
(
SysFsController
::
get_path
)
...
...
src/error.rs
View file @
ff5858b2
...
...
@@ -54,7 +54,6 @@ impl StdError for Error {
match
*
self
.0
{
ErrorKind
::
Io
(
ref
err
)
=>
Some
(
err
),
ErrorKind
::
Json
(
ref
err
)
=>
Some
(
err
),
// TODO: add cause to String errors?
ErrorKind
::
Simple
(
_
)
=>
None
,
ErrorKind
::
Placeholder
(
_
)
=>
None
,
ErrorKind
::
List
{
cur
:
_
,
ref
next
}
=>
Some
(
next
),
...
...
src/parsing.rs
View file @
ff5858b2
...
...
@@ -151,7 +151,6 @@ impl InCommand {
impl
Arguments
{
pub
fn
parse
(
self
,
controllers
:
Rc
<
SysFsControllerList
>
)
->
Result
<
CommandList
>
{
// TODO: move in a specific check module?
// checks that there is only one exec or remove, and only at the end of the chain
if
self
.commands
.iter
()
.map
(|
cmd
|
&
cmd
.command
==
"remove"
||
&
cmd
.command
==
"exec"
||
&
cmd
.command
==
"spawn"
||
&
cmd
.command
==
"fork_exec"
)
...
...
src/result.rs
View file @
ff5858b2
...
...
@@ -36,7 +36,6 @@ impl From<()> for CommandResult {
}
}
// TODO: display messages
impl
fmt
::
Display
for
CommandResult
{
fn
fmt
(
&
self
,
f
:
&
mut
fmt
::
Formatter
)
->
fmt
::
Result
{
match
*
self
.0
{
...
...
src/transaction/fs/remove_dir.rs
View file @
ff5858b2
...
...
@@ -5,8 +5,6 @@ use std::path;
use
std
::
rc
::
Rc
;
use
transaction
::
*
;
// TODO: use an "inverse" wrapper struct for CreateDir with deref and newtype pattern?
#[derive(Clone,
Eq,
PartialEq,
Debug)]
pub
struct
RemoveDir
{
path
:
path
::
PathBuf
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment