Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Contribute to GitLab
  • Sign in
C
containers
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 1
    • Issues 1
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • argo
  • containers
  • Merge Requests
  • !5

Merged
Opened Oct 08, 2018 by Kamil Iskra@iskra
  • Report abuse
Report abuse

Strengthen tests for invalid input

Fix issue #2 (closed)

When creating containers, we would before accept input with empty or missing cpu or memory lists. CPU list was also wrongly assumed to be non-exclusive by default.

Input validation is still grossly incomplete (we don't check for invalid keys, alter commands probably need similar fixes as well) but it's an improvement.

  • Discussion 0
  • Commits 1
  • Changes 1
Kamil Iskra
Assignee
Kamil Iskra @iskra
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: argo/containers!5

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.